[plasmashell] [Bug 484546] Plasma crashes when drag'n'dropping file from notifications menu

2024-05-14 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=484546

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/-/commi
   ||t/bf8545946cc340c262911c0ba
   ||94e28661a7feb8a

--- Comment #2 from Kai Uwe Broulik  ---
Git commit bf8545946cc340c262911c0ba94e28661a7feb8a by Kai Uwe Broulik.
Committed on 14/05/2024 at 12:30.
Pushed by broulik into branch 'master'.

Notifications: Restore custom DragHelper

When the notification popup closes, the ListView mode is unloaded to
save some resources. On Wayland, during drag and drop another window
might be raised and focussed causing the notification popup to close.

QtQuick's built-in drag handling does not take kind to having the
item it's operating on destroyed behind its back, particularly because
it uses a freaking' nested event loop inside of dragStarted!

Restore the original DragHandler which detaches the drag operation
entirely from the item that triggered it. It also creates a proper
drag pixmap for dragging the file icon and keeps it for the entire
duration of the drag.

As a bonus this also lets us export the URL to the Document portal
to enable drag and drop of thumbnails to sandboxed apps.
Related: bug 486665

M  +3-0applets/notifications/CMakeLists.txt
A  +84   -0applets/notifications/draghelper.cpp [License: GPL(3+eV)
GPL(v3.0) GPL(v2.0)]
A  +42   -0applets/notifications/draghelper.h [License: GPL(3+eV)
GPL(v3.0) GPL(v2.0)]
M  +4-0applets/notifications/notificationapplet.cpp
M  +10   -9applets/notifications/package/contents/ui/DraggableFileArea.qml
M  +2-5applets/notifications/package/contents/ui/JobItem.qml
M  +2-5applets/notifications/package/contents/ui/ThumbnailStrip.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/bf8545946cc340c262911c0ba94e28661a7feb8a

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 484546] Plasma crashes when drag'n'dropping file from notifications menu

2024-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=484546

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 484546] Plasma crashes when drag'n'dropping file from notifications menu

2024-05-09 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=484546

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #1 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4295

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 484546] Plasma crashes when drag'n'dropping file from notifications menu

2024-04-21 Thread Petrov Egor
https://bugs.kde.org/show_bug.cgi?id=484546

Petrov Egor  changed:

   What|Removed |Added

 CC||dikey0fic...@disroot.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 484546] Plasma crashes when drag'n'dropping file from notifications menu

2024-03-26 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=484546

Bug Janitor Service  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.