[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2020-01-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.19.0
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #15 from Nate Graham  ---
The confusing text and its confusing feature have been removed in Plasma 5.19!

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2019-09-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

Nate Graham  changed:

   What|Removed |Added

 CC||felixbra...@gmail.com

--- Comment #14 from Nate Graham  ---
*** Bug 411941 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2019-03-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

Nate Graham  changed:

   What|Removed |Added

 CC||pe...@hack-libre.org

--- Comment #13 from Nate Graham  ---
*** Bug 405359 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2019-02-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=403499

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2018-12-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

--- Comment #12 from Nate Graham  ---
Git commit 7bd7f38400b953a988a2cc942a518339e0b094a8 by Nate Graham.
Committed on 23/12/2018 at 04:14.
Pushed by ngraham into branch 'master'.

[KRun] when asked to open link in external browser, fall back to mimeapps.list
if nothing is set in kdeglobals

Summary:
Right now, when KRun is invoked to open an `http` or `https` link in a browser,
it checks the `BrowserApplication` key in `~/.config/kdeglobals`. If nothing is
set there (which is the default), then it introspects the link and figures out
for itself what app to open, which is slow and can cause problems with certain
links (see CCBUGs below).

This patch improves the browser discovery logic by additionally looking for a
default browser in `~/.config/mimeapps.list`, which is the XDG file and it's
where browsers set themselves as the default. So if there is a default browser
set in there, KRun will consume that information immediately instead of doing
the time-consuming and possibly error-inducing link introspection round-trip.
Related: bug 347870

Test Plan:
1. Open System Settings > Applications > Default Applications > Browser and
click "In an application based on the contents of the url" (which is the
default setting, but you might have changed it)
2. Set `BrowserApplication[$e]=` in `~/.config/kdeglobals`
3. Ensure that `~/.config/mimeapps/list` has a default browser set
4. Open any KDE app > Help menu > About KDE > Click on one of the links in the
dialog

Without this patch, a KRun job is spawned that shows up in the notification
widget and the link may take a second or two to open in your default browser.

With this patch, the link instantly opens in the browser.

Reviewers: #frameworks, broulik, cfeck, elvisangelaccio, dfaure

Reviewed By: dfaure

Subscribers: dfaure, rdieter, achauvel, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17371

M  +13   -0src/widgets/krun.cpp

https://commits.kde.org/kio/7bd7f38400b953a988a2cc942a518339e0b094a8

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2018-12-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

--- Comment #11 from Nate Graham  ---
Ok, what I think makes sense is to fall back on KIO when there are no web
browsers installed (unlikely). When one is manually installed, it will usually
set itself as the default--but in ~/.config/mimeapps.list, not
~/.config/kdeglobals. Which is fine, since changing the browser setting in
componentchooser updates mimeapps.list too so that don't get out of sync.

It will be up to distros to pre-populate these files with their desired default
browsers, but that's already the case, so no regressions should be introduced.
I'll also change the componentchooser KCM so that the default browser shown in
the combobox is identical to what's listed in ~/.config/mimeapps.list if
there's nothing in kdeglobals.

Here are the patches:
- KIO: https://phabricator.kde.org/D17371
- Plasma: https://phabricator.kde.org/D17372

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2018-12-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

Nate Graham  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #10 from Nate Graham  ---
Following supportive comments on the mailing list, I'm preparing a patch to
remove the "in an application based on the contents of the url" feature, which
is confusing, imposes a speed penalty, and apparently doesn't work for certain
URLs. The patch is fairly simple but there's a conceptual issue: what's a good
default setting now?

Right now the default setting is "let KIO figure it out", and presumably this
should move to "default to browser X". But what is Browser X? Should we really
be in the business of picking preference orders for 3rd-party software? What
about if 1st-party software is also installed, like Falkon or Konqueror? Should
we leave it up to distros to populate ~/.config/kdeglobals with a sensible
default for BrowserApplication[$e]?

Any ideas or guidance would be appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2018-11-25 Thread Martin van Es
https://bugs.kde.org/show_bug.cgi?id=100016

Martin van Es  changed:

   What|Removed |Added

 CC||b...@mrvanes.com

--- Comment #9 from Martin van Es  ---
And please, let it be clear that the 'in an application based on the contents
of the url' option is broken. It destroys any link while inspecting the content
as reported here: https://bugs.kde.org/show_bug.cgi?id=354822

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2018-11-25 Thread Anguo
https://bugs.kde.org/show_bug.cgi?id=100016

--- Comment #8 from Anguo  ---

Logically, the settings should be split into two different settings:

- One setting to select the default browser.
- One setting to select default action, with A) as above and B) reading: "in
the default browser".


Where are the relevant settings saved?
I checked ~/.config/systemsettingsrc  but it does not appear to be there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2018-11-25 Thread Anguo
https://bugs.kde.org/show_bug.cgi?id=100016

--- Comment #7 from Anguo  ---
In KDE systemsettings > Personalization > Applications > Default applications >
Web browser,
there are two settings:
A) "in an application based on the contents of the URL".
B) "in the following browser".

There are two problems with the interface:
1- if A) is selected, then the name of the default browser is not visible.

2- It is not possible to change the default browser and keep A) selected.
To do so, the workaround is to select B), type in the browser name, save, then
select A) again, save again. When coming back later to the same screen, the
first problem occurs again.

http://linux.overshoot.tv/wiki/default_browser_kde

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2018-11-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

Nate Graham  changed:

   What|Removed |Added

 CC||kde_b...@overshoot.tv

--- Comment #6 from Nate Graham  ---
*** Bug 380133 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2018-11-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability
 CC||n...@kde.org
   Severity|normal  |major

--- Comment #5 from Nate Graham  ---
Lots of good info in Bug 347870.

It's not real clear to me what value this feature even provides in this day and
age...

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 100016] unclear text explanation in default browser dialog

2018-11-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=100016

Nate Graham  changed:

   What|Removed |Added

 CC||skierp...@gmail.com

--- Comment #4 from Nate Graham  ---
*** Bug 347870 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.