[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368600

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.15.0  |5.14.0
  Latest Commit|https://commits.kde.org/kde |https://commits.kde.org/kde
   |-gtk-config/b943d4ac6e2c752 |-gtk-config/c44527bb678e160
   |14e24c7d7e352d54e08181ddd   |d9c4b8401cc96c4b59072a0f5

--- Comment #18 from Nate Graham  ---
Git commit c44527bb678e160d9c4b8401cc96c4b59072a0f5 by Nathaniel Graham.
Committed on 24/09/2018 at 22:34.
Pushed by ngraham into branch 'Plasma/5.14'.

Sort icon and cursor themes case-insensitively

Summary:
Stick a QSortFilterProxyModel between the model and the view, and tell it to
sort case-insensitively. Thanks to https://stackoverflow.com/a/5732026/2934226
for providing the solution.
FIXED-IN: 5.14.0

Test Plan: Could not test as I was unable to locate a working GTK 2 or 3 theme
that started with a lowercase letter. But theoretically this code should do the
trick, and it does not appear to cause any regressions at least.

Reviewers: apol, #plasma, broulik

Reviewed By: apol

Subscribers: wbauer, cfeck, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15598

M  +0-2src/cursorthemesmodel.cpp
M  +16   -3src/gtkconfigkcmodule.cpp
M  +0-2src/iconthemesmodel.cpp

https://commits.kde.org/kde-gtk-config/c44527bb678e160d9c4b8401cc96c4b59072a0f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368600

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.14.0  |5.15.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368600

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.14.0
  Latest Commit|https://commits.kde.org/kde |https://commits.kde.org/kde
   |-gtk-config/7b56c23870798ad |-gtk-config/b943d4ac6e2c752
   |beb3f110eacae7f1020dcad6f   |14e24c7d7e352d54e08181ddd
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #17 from Nate Graham  ---
Git commit b943d4ac6e2c75214e24c7d7e352d54e08181ddd by Nathaniel Graham.
Committed on 20/09/2018 at 15:25.
Pushed by ngraham into branch 'master'.

Sort icon and cursor themes case-insensitively

Summary:
Stick a QSortFilterProxyModel between the model and the view, and tell it to
sort case-insensitively. Thanks to https://stackoverflow.com/a/5732026/2934226
for providing the solution.
FIXED-IN: 5.14.0

Test Plan: Could not test as I was unable to locate a working GTK 2 or 3 theme
that started with a lowercase letter. But theoretically this code should do the
trick, and it does not appear to cause any regressions at least.

Reviewers: apol, #plasma, broulik

Reviewed By: apol

Subscribers: wbauer, cfeck, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15598

M  +0-2src/cursorthemesmodel.cpp
M  +16   -3src/gtkconfigkcmodule.cpp
M  +0-2src/iconthemesmodel.cpp

https://commits.kde.org/kde-gtk-config/b943d4ac6e2c75214e24c7d7e352d54e08181ddd

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368600

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #16 from Nate Graham  ---
This patch oughta fix that right up: https://phabricator.kde.org/D15598

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368600

Nate Graham  changed:

   What|Removed |Added

 Status|ASSIGNED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #15 from Dr. Chapatin  ---
Right. Thank you for your help.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #14 from Wolfgang Bauer  ---
(In reply to Dr. Chapatin from comment #13)
> Created attachment 114966 [details]
> cursor drop down in plasma 5.13.5
> 
> Sorting must be case-insensitive.

I agree that it should be case-insensitive, but let's summarize the current
state to avoid confusion.

So, as I see it:

The icon and cursor themes list are sorted now (not in 5.14 beta because the
fix got "lost", that's fixed in 5.14 branch too meanwhile).
But they are sorted case-sensitive (i.e. 'a' comes after 'Z', not before 'B'),
it should rather be case-insensitive.

The GTK2/3 themes lists are apparently still not sorted and appear in the order
they are in the directory list.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #13 from Dr. Chapatin  ---
Created attachment 114966
  --> https://bugs.kde.org/attachment.cgi?id=114966=edit
cursor drop down in plasma 5.13.5

Sorting must be case-insensitive.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #12 from Wolfgang Bauer  ---
(In reply to Dr. Chapatin from comment #11)
> Plasma 5.13.5 had the same bug shown in the screenshot from comment 7.

All right, that's the (GTK2) theme list though.

I only looked at the cursors and icon-themes list as the title of this bug
report says, and the commit from comment#4 was supposed to fix.

Although, the themes lists seem to be correctly sorted here too (even
case-insensitive), may be just "luck" though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #11 from Dr. Chapatin  ---
Plasma 5.13.5 had the same bug shown in the screenshot from comment 7.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #10 from Wolfgang Bauer  ---
(In reply to Dr. Chapatin from comment #9)
> Plasma 5.13.5 had the same bug.

Which one?

On your screenshot from 5.13.3 the only problem that can be seen is that the
search is case-sensitive.(O->P->e)
And that's what I see here with 5.13.5 too.

In 5.14 beta it probably is completely unsorted though, but current 5.14 branch
should be in the same state as 5.13.5.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #9 from Dr. Chapatin  ---
Plasma 5.13.5 had the same bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #8 from Wolfgang Bauer  ---
(In reply to Dr. Chapatin from comment #7)
> Created attachment 114964 [details]
> R comes before O in plasma 5.14 beta, Arch Linux

That's likely because the fix never was merged to master, it only was in the
5.13 branch.
Has been fixed an hour ago though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #7 from Dr. Chapatin  ---
Created attachment 114964
  --> https://bugs.kde.org/attachment.cgi?id=114964=edit
R comes before O in plasma 5.14 beta, Arch Linux

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=368600

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||wba...@tmo.at

--- Comment #6 from Wolfgang Bauer  ---
(In reply to Dr. Chapatin from comment #5)
> Created attachment 113891 [details]
> screenshot taken on Arch, plasma 5.13.3
> 
> unfortunately it's not fixed in plasma 5.13.3, Arch Linux.

It actually is sorted, but the sorting is case-sensitive, i.e. 'a' comes after
'Z'.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

Dr. Chapatin  changed:

   What|Removed |Added

Version|5.13.0  |5.13.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

--- Comment #5 from Dr. Chapatin  ---
Created attachment 113891
  --> https://bugs.kde.org/attachment.cgi?id=113891=edit
screenshot taken on Arch, plasma 5.13.3

unfortunately it's not fixed in plasma 5.13.3, Arch Linux.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

Dr. Chapatin  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=368600

Aleix Pol  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kde
   ||-gtk-config/7b56c23870798ad
   ||beb3f110eacae7f1020dcad6f
 Status|CONFIRMED   |RESOLVED

--- Comment #4 from Aleix Pol  ---
Git commit 7b56c23870798adbeb3f110eacae7f1020dcad6f by Aleix Pol.
Committed on 03/07/2018 at 15:44.
Pushed by apol into branch 'Plasma/5.13'.

Keep Cursor and Icon themes lists sorted

M  +2-0src/cursorthemesmodel.cpp
M  +2-0src/iconthemesmodel.cpp

https://commits.kde.org/kde-gtk-config/7b56c23870798adbeb3f110eacae7f1020dcad6f

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

Dr. Chapatin  changed:

   What|Removed |Added

Version|5.12.4  |5.13.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368600

Dr. Chapatin  changed:

   What|Removed |Added

Version|5.11.0  |5.12.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 368600] GTK Application Style cursors/icons themes lists should be in alphabetical order

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368600

Nate Graham  changed:

   What|Removed |Added

Summary|Put cursors/icons themes|GTK Application Style
   |lists in alphabetical order |cursors/icons themes lists
   |please  |should be in alphabetical
   ||order
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.