[systemsettings] [Bug 427935] Make Highlight Changed Settings More Consistent

2020-10-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=427935

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.21
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/systemsettings/commit/fc
   ||dfc86d40794621e80c9c05be0b9
   ||6f3f6211a5a
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Nate Graham  ---
Git commit fcdfc86d40794621e80c9c05be0b96f3f6211a5a by Nate Graham.
Committed on 21/10/2020 at 13:26.
Pushed by ngraham into branch 'master'.

[sidebar view] Re-position defaults indicators

Previously, they were always the right-most item in their list items,
and could cause the arrow to move around. Now they're left of the arrow
so nothing moves around. The indicators still line up vertically.
FIXED-IN: 5.21

M  +17   -12   sidebar/package/contents/ui/CategoryItem.qml

https://invent.kde.org/plasma/systemsettings/commit/fcdfc86d40794621e80c9c05be0b96f3f6211a5a

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 427935] Make Highlight Changed Settings More Consistent

2020-10-20 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=427935

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/systemsettings/-/merge_requests/34

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 427935] Make Highlight Changed Settings More Consistent

2020-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=427935

--- Comment #3 from Nate Graham  ---
Created attachment 132590
  --> https://bugs.kde.org/attachment.cgi?id=132590&action=edit
Proposal

Here's how that would look. Do you think it's better?

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 427935] Make Highlight Changed Settings More Consistent

2020-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=427935

Nate Graham  changed:

   What|Removed |Added

 CC||plasma-b...@kde.org
  Component|general |sidebarview
   Assignee|plasma-b...@kde.org |notm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 427935] Make Highlight Changed Settings More Consistent

2020-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=427935

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #2 from Nate Graham  ---
The problem with that approach is that it looks really weird for items and
sections that don't have arrows.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 427935] Make Highlight Changed Settings More Consistent

2020-10-20 Thread Andres Betts
https://bugs.kde.org/show_bug.cgi?id=427935

--- Comment #1 from Andres Betts  ---
Through discussion, the team also proposed placing the highlight dot just
before the arrow icon. This will keep a straight consistent line and there
would not be a shift with the arrows.

-- 
You are receiving this mail because:
You are watching all bug changes.