https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #23 from Bug Janitor Service ---
A possibly relevant merge request was started @
https://invent.kde.org/sdk/umbrello/-/merge_requests/12
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #22 from Ralf Habacker ---
(In reply to Robert Hairgrove from comment #8)
> (In reply to Ralf Habacker from comment #4)
> > (In reply to Robert Hairgrove from comment #3)
> > > Is there any reason why the type must be a UMLClassifier?
> >
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #21 from Ralf Habacker ---
(In reply to Robert Hairgrove from comment #20)
> In the fixed version, the "type" attribute of the parameter now contains the
> xmi.id value of the template (as it should).
I can see that:
...
--
You are
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #20 from Robert Hairgrove ---
In the fixed version, the "type" attribute of the parameter now contains the
xmi.id value of the template (as it should).
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #19 from Robert Hairgrove ---
Yes, this is what I see as well. Of course, the XMI file was malformed because
there is no datatype "pkg1::pkg2::pkg3::ClassBase::CharType" listed in the
datatypes. It was probably created without the fix in
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #18 from Ralf Habacker ---
(In reply to Ralf Habacker from comment #17)
> Created attachment 130847 [details]
> testcase
With your patches applied and after loading the testcase in the tree view now I
see
operation(param:undef)
I need to
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #17 from Ralf Habacker ---
Created attachment 130847
--> https://bugs.kde.org/attachment.cgi?id=130847=edit
testcase
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #16 from Ralf Habacker ---
(In reply to Ralf Habacker from comment #15)
> I'm going to try that with a different merge request.
It works as expected: see latest commits in release/20.08 branch how it should
be used.
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #15 from Ralf Habacker ---
(In reply to Robert Hairgrove from comment #12)
> There should be an additional "FIXED-IN" line in the comments, but I didn't
> know exactly what version to write. I saw a reference to "20.08.1"
> somewhere, but
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #14 from Robert Hairgrove ---
Well, I did test these things, and it seems to work OK:
1. Saving and loading from XMI works, AFAICT.
2. Code generation works, as far as the templates go in C++; I don't know
enough about other languages to
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #13 from Ralf Habacker ---
(In reply to Robert Hairgrove from comment #12)
You wrote in the merge request:
> Needs testing in other modules, e.g. code generation and XMI load/save
> operations.
Then this merge request is not ready for
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #12 from Robert Hairgrove ---
If no one has any requests for changes, could somebody with write access please
merge this for me?
There should be an additional "FIXED-IN" line in the comments, but I didn't
know exactly what version to
https://bugs.kde.org/show_bug.cgi?id=425156
Robert Hairgrove changed:
What|Removed |Added
Status|CONFIRMED |ASSIGNED
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #11 from Robert Hairgrove ---
Removed the WIP. Added two commits today.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #10 from Robert Hairgrove ---
Added another commit to existing merge request yesterday.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #9 from Robert Hairgrove ---
Thank you again for all your help, Ralf!
I have a fix now for this -- XMI loads and saves OK, code generation and import
seems to work. The only thing I noticed is that the generated code, instead of
making
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #8 from Robert Hairgrove ---
(In reply to Ralf Habacker from comment #4)
> (In reply to Robert Hairgrove from comment #3)
> > Is there any reason why the type must be a UMLClassifier?
>
> Types may be classes and therefore need to be a
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #7 from Robert Hairgrove ---
Thank you, Ralf -- sorry for all the trouble I have caused.
I hope it is OK now. I added "WIP:" to the title.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #6 from Ralf Habacker ---
(In reply to Bug Janitor Service from comment #1)
> A possibly relevant merge request was started @
> https://invent.kde.org/sdk/umbrello/-/merge_requests/9
The mr shows 6 commits where it should have only one.
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #5 from Ralf Habacker ---
(In reply to Robert Hairgrove from comment #2)
> XMI doesn't seem to understand this. Loading and saving to/from XMI does not
> set the proper data type as template typename.
>
> At the moment, I cannot tell where
https://bugs.kde.org/show_bug.cgi?id=425156
Ralf Habacker changed:
What|Removed |Added
CC||ralf.habac...@freenet.de
--- Comment #4 from
https://bugs.kde.org/show_bug.cgi?id=425156
Robert Hairgrove changed:
What|Removed |Added
Status|ASSIGNED|CONFIRMED
--- Comment #3 from Robert
https://bugs.kde.org/show_bug.cgi?id=425156
--- Comment #2 from Robert Hairgrove ---
XMI doesn't seem to understand this. Loading and saving to/from XMI does not
set the proper data type as template typename.
At the moment, I cannot tell where the parsing fails, so maybe this merge
request was
https://bugs.kde.org/show_bug.cgi?id=425156
Bug Janitor Service changed:
What|Removed |Added
Ever confirmed|0 |1
Status|REPORTED
24 matches
Mail list logo
