[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 Carl Love changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 Carl Love changed: What|Removed |Added Resolution|--- |FIXED

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #35 from Carl Love --- testsuite fix to give more unique values. In testing issues with the new ISA 3.0 instructions in BE mode, it was found that we needed some more unique values in the operands to catch various errors.

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #34 from Carl Love --- ISA 3.0 BE fixes for various new instructions patch committed VEX commit 3260 -- You are receiving this mail because: You are watching all bug changes.

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #33 from Carl Love --- Created attachment 101482 --> https://bugs.kde.org/attachment.cgi?id=101482=edit ISA 3.0 BE fixes for various new instructions This is an additional commit to fix issues found with the new Power

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #32 from Carl Love --- Patch to fix missing fnptr_to_fnentry() wrapper funion calls for clean and dirty helpers was committed, VEX commit 3251. The BE fixes for the function FPU_rounding_mode_isOdd(), stxvl and stxvx

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #31 from Carl Love --- Created attachment 101364 --> https://bugs.kde.org/attachment.cgi?id=101364=edit Some BE fixes The BE simulator runs found a few more issues that cause Valgrind to fail. These are minor things

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #30 from Mark Wielaard --- (In reply to Carl Love from comment #29) > Please review the patch and let me know if you see any issues. If everyone > approves the patch and the ISA 3.0 Big endian test passes, I will commit

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #29 from Carl Love --- Created attachment 101332 --> https://bugs.kde.org/attachment.cgi?id=101332=edit Patch to fix missing fnptr_to_fnentry() wrapper function calls for clean and dirty helpers The attached patch fixes

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #28 from Carl Love --- Posted a patch to replace the bcdadd instruction generation in Valgrind with vand. This patch allows us to run a bcd add test on a power 7 (big endian) machine to test the ISA 3.0 code that calls

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #27 from Carl Love --- Created attachment 101300 --> https://bugs.kde.org/attachment.cgi?id=101300=edit binary for bcd_add.c test Binary for the bcd_test.c program. Runs under valgrind on Power 7 with the valgrind

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #26 from Carl Love --- Created attachment 101299 --> https://bugs.kde.org/attachment.cgi?id=101299=edit patch, replace isa2_07 bcdadd/bcdsub with isa2_06 vand inst to we can run bcdadd test on Power 7 Replace bcdadd,

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #25 from Ulrich Weigand --- (In reply to Julian Seward from comment #24) > (In reply to Ulrich Weigand from comment #23) > > However, adding calls to fnptr_to_fnentry at a high level likewise seems > > wrong, since once

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #24 from Julian Seward --- (In reply to Ulrich Weigand from comment #23) > However, adding calls to fnptr_to_fnentry at a high level likewise seems > wrong, since once you've done that, you've forgotten where the function >

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 Ulrich Weigand changed: What|Removed |Added CC||uweig...@de.ibm.com ---

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #22 from Julian Seward --- Looking for helper calls in the the whole of guest_ppc_toIR.c, by searching for the string "mkIRExprVec_", I found the following non-wrapped uses of function pointers. They should all be wrapped

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #21 from Mark Wielaard --- Created attachment 101296 --> https://bugs.kde.org/attachment.cgi?id=101296=edit Patch to wrap _BCDstring128_helper address in fnptr_to_fnentry After some debugging Julian suggested this fix.

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #20 from Mark Wielaard --- Created attachment 101295 --> https://bugs.kde.org/attachment.cgi?id=101295=edit Trace for smaller badness2 reproducer Trace output for a smaller reproducer: $ cat badness2.c #include

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #19 from Will Schmidt --- Chased this one around under gdb for a while, looking for where the R2 or the stack frame are getting messed up.Something seems to be going horribly wrong here, but it's possible

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #17 from Mark Wielaard --- Since some of the output looks as if we jump into (or just read from?) the ODP and that gives a permission error/SEGV, could you provide the section and segments of the tool to double check

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #18 from Mark Wielaard --- Never mind the objdump -h gives the right information. The 0x3824B2B0 is indeed in the middle of the ODP. The ODP is loaded and DATA (not CODE), which I assume means it is readable (so we can

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #16 from Will Schmidt --- A bit of an info dump from the IRC discussions occurring on this bug: A gdb session revealed: Program received signal SIGSEGV, Segmentation fault. 0x3824b2b0 in

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 Will Schmidt changed: What|Removed |Added Attachment #101244|0 |1 is

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #14 from Carl Love --- Created attachment 101245 --> https://bugs.kde.org/attachment.cgi?id=101245=edit simple test program The attachment is a stripped down test for the bcdadd instruction. It was pulled out of the

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #13 from Will Schmidt --- Created attachment 101244 --> https://bugs.kde.org/attachment.cgi?id=101244=edit comment 3 step 3 output results from comment3 step 3 -- You are receiving this mail because: You are

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #12 from Will Schmidt --- Created attachment 101243 --> https://bugs.kde.org/attachment.cgi?id=101243=edit output from monitor v.translate on segfaulting instruction -- You are receiving this mail because: You

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #11 from Will Schmidt --- (In reply to Mark Wielaard from comment #9) > Assuming that is with remote vgdb attached then you should be able to get > the generated IR and assembly with: > monitor v.translate

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #10 from Will Schmidt --- Created attachment 101242 --> https://bugs.kde.org/attachment.cgi?id=101242=edit trace flags output last portion of output from a run in attachment. $ ./vg-in-place --tool=none

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #9 from Mark Wielaard --- Assuming that is with remote vgdb attached then you should be able to get the generated IR and assembly with: monitor v.translate 0x100016dc 0b0011 (See the manual or valgrind

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #8 from Will Schmidt --- off-by-one on my disassembly "==>" pointer, the SIGSEGV is actually on the bcdadd instruction. (showed up differently while single-stepping). 0x100016d4 <+64>:lxvd2x

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #7 from Will Schmidt --- (gdb) c Continuing. Program received signal SIGSEGV, Segmentation fault. 0x100016d8 in test_bcdadd () at test_isa_2_07_part1.c:710 710 __asm__ __volatile__ ("bcdadd. %0,

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #6 from Mark Wielaard --- (In reply to Julian Seward from comment #3) > I tried to reproduce this on gcc112.fsffrance.org (a P8 system) but failed -- > it runs OK. I'd be happy to chase this if I could reproduce on a

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #5 from Julian Seward --- Still can't repro it, but with a test case for this insn, the two calls look like this: IR and virtual-registerised code: -- t127 =

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #4 from Julian Seward --- Comment 3 assumes that the block that segfaults is the same one where the (we assume) mis-translation occurred. It might be that some previous block was mis-translated and causes the simulated

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #3 from Julian Seward --- This kind of thing could well be due to incorrect register allocation around the calls, perhaps corrupting the values passed to the calls or corrupting values in registers around the call site,

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 Carl Love changed: What|Removed |Added CC||c...@us.ibm.com,

[valgrind] [Bug 369175] jm_vec_isa_2_07 test crashes on ppc64

https://bugs.kde.org/show_bug.cgi?id=369175 --- Comment #1 from Mark Wielaard --- Note that running the program itself (not under valgrind) seems fine. It is only when ran under valgrind that it produces the SIGSEGV: ==28394== Process terminating with default action of signal