[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-23 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=377698 Ivo Raisr changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-23 Thread Diane M
https://bugs.kde.org/show_bug.cgi?id=377698 --- Comment #8 from Diane M --- Created attachment 104704 --> https://bugs.kde.org/attachment.cgi?id=104704&action=edit updated patch I hope this patch works better. -- You are receiving this mail because: You are watching all bug changes.

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-22 Thread Julian Seward
https://bugs.kde.org/show_bug.cgi?id=377698 --- Comment #7 from Julian Seward --- (In reply to Diane M from comment #6) > I believe the if is necessary, because it is checking whether the function > pointer is defined, [..] Oh, you're right. I missed that. r+ then; can you attach a patch that

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-22 Thread Diane M
https://bugs.kde.org/show_bug.cgi?id=377698 --- Comment #6 from Diane M --- Julian, I encountered the problem while implementing and testing futex() for sparc linux. + if (VG_(tdict).track_pre_reg_read) { + PRA6("futex",int,val3); + } I believe the if is necessary, because it

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-22 Thread Julian Seward
https://bugs.kde.org/show_bug.cgi?id=377698 Julian Seward changed: What|Removed |Added CC||jsew...@acm.org --- Comment #5 from Julian Sewa

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-22 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=377698 --- Comment #4 from Ivo Raisr --- Diane, your patch does not apply to Valgrind SVN trunk. 1. It is malformed. Line 48 seems to be split somehow. 2. After correcting item 1 manually, 2 hunks in coregrind/m_syswrap/syswrap-linux.c fail to apply. Ple

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-21 Thread Diane M
https://bugs.kde.org/show_bug.cgi?id=377698 Diane M changed: What|Removed |Added CC||diane.meirow...@oracle.com --- Comment #3 from Diane

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-21 Thread Diane M
https://bugs.kde.org/show_bug.cgi?id=377698 Diane M changed: What|Removed |Added Component|general |memcheck -- You are receiving this mail because: You

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-21 Thread Diane M
https://bugs.kde.org/show_bug.cgi?id=377698 --- Comment #2 from Diane M --- Here is the final updated patch. Problems: 1. Memcheck does not do a memory check on the uaddr argument for futex for FUTEX_WAKE and FUTEX_WAKE_BITSET cases. 2. FUTEX_WAKE_BITSET should not do scalar read check on all

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

2017-03-20 Thread Diane M
https://bugs.kde.org/show_bug.cgi?id=377698 Diane M changed: What|Removed |Added Summary|Missing memory check for|Missing memory check for |futex() u

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET

2017-03-20 Thread Diane M
https://bugs.kde.org/show_bug.cgi?id=377698 --- Comment #1 from Diane M --- In addition to the previously-described problems: - FUTEX_WAKE_BITSET should not do scalar read check on all 6 arguments; it should check uaddr, op, val, and val3 only. - FUTEX_TRYLOCK_PI should check only uaddr and o

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET

2017-03-16 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=377698 Ivo Raisr changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET

2017-03-16 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=377698 Ivo Raisr changed: What|Removed |Added Assignee|jsew...@acm.org |iv...@ivosh.net -- You are receiving this mail bec

[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET

2017-03-16 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=377698 Ivo Raisr changed: What|Removed |Added Version|unspecified |3.13 SVN Component|memcheck