[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[Rhys Kidd]

https://bugs.kde.org/show_bug.cgi?id=385279

Rhys Kidd  changed:

   What|Removed |Added

 CC||magda.schwa...@gmail.com

--- Comment #14 from Rhys Kidd  ---
*** Bug 395136 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[Rhys Kidd]

https://bugs.kde.org/show_bug.cgi?id=385279

Rhys Kidd  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #13 from Rhys Kidd  ---
Thanks for the patch and testing!

Fixed in dcb83cf84 ("macos: Fix unhandled syscall: mach:43
(mach_generate_activity_id). bz#385279" which will be part of the next Valgrind
release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[Chris Wilson]

https://bugs.kde.org/show_bug.cgi?id=385279

Chris Wilson  changed:

   What|Removed |Added

 CC||chris+...@qwirx.com

--- Comment #12 from Chris Wilson  ---
I would like to echo comment #5: the patch works for me too, thank you Louis
and FX!

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385279

lou.salk...@gmail.com changed:

   What|Removed |Added

 CC||lou.salk...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[FX]

https://bugs.kde.org/show_bug.cgi?id=385279

--- Comment #11 from FX  ---
(In reply to Rhys Kidd from comment #10)
> Helpfully, there's a bug report tracking that too and a draft patch for that
> at https://bugs.kde.org/show_bug.cgi?id=380269

That's what I was saying. I'm seeing that error, after applying the draft patch
at 380269.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[Rhys Kidd]

https://bugs.kde.org/show_bug.cgi?id=385279

--- Comment #10 from Rhys Kidd  ---
We know there's some low-level threading state we aren't handling properly.
Sounds like you're hitting that.

Helpfully, there's a bug report tracking that too and a draft patch for that at
https://bugs.kde.org/show_bug.cgi?id=380269

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[FX]

https://bugs.kde.org/show_bug.cgi?id=385279

--- Comment #9 from FX  ---
The lpq issue: with the patch from this PR, I trigger 383723. Adding the patch
at 383723, I get 380269. Adding the tentative patch posted at 380269, I still
get an error:

==63832== Thread 2:
==63832== Invalid read of size 4
==63832==at 0x1014E1E9B: _pthread_wqthread (in
/usr/lib/system/libsystem_pthread.dylib)
==63832==by 0x1014E1C4C: start_wqthread (in
/usr/lib/system/libsystem_pthread.dylib)
==63832==  Address 0x18 is not stack'd, malloc'd or (recently) free'd
==63832== 
==63832== 
==63832== Process terminating with default action of signal 11 (SIGSEGV)
==63832==  Access not within mapped region at address 0x18
==63832==at 0x1014E1E9B: _pthread_wqthread (in
/usr/lib/system/libsystem_pthread.dylib)
==63832==by 0x1014E1C4C: start_wqthread (in
/usr/lib/system/libsystem_pthread.dylib)
==63832==  If you believe this happened as a result of a stack
==63832==  overflow in your program's main thread (unlikely but
==63832==  possible), you can try to increase the size of the
==63832==  main thread stack using the --main-stacksize= flag.
==63832==  The main thread stack size used in this run was 8388608.
--63832:0:schedule VG_(sema_down): read returned -4

valgrind: m_scheduler/scheduler.c:952 (void run_thread_for_a_while(HWord *, Int
*, ThreadId, HWord, Bool)): Assertion 'VG_(in_generated_code) == False' failed.

host stacktrace:
==63832==at 0x258053C2B: ???
==63832==by 0x258053FBC: ???
==63832==by 0x258053F93: ???
==63832==by 0x2580EADFB: ???
==63832==by 0x2580E9788: ???
==63832==by 0x2580FB7DE: ???
==63832==by 0x2580FBAAA: ???

sched status:
  running_tid=3

Thread 1: status = VgTs_WaitSys (lwpid 771)
==63832==at 0x1014AC562: __workq_kernreturn (in
/usr/lib/system/libsystem_kernel.dylib)
==63832==by 0x1014E1C27: _pthread_workqueue_addthreads (in
/usr/lib/system/libsystem_pthread.dylib)
==63832==by 0x1010D1E4D: _dispatch_global_queue_poke_slow (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1010D91BD: _dispatch_mach_send_push (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1010DD8C8: _voucher_activity_debug_channel_init (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1010DBAFC: _dispatch_kq_poll (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1010DB735: _dispatch_kq_drain (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1010DAB03: _dispatch_kq_unote_update (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1010D5E33: _dispatch_source_refs_register (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1010D5F5D: _dispatch_source_finalize_activation (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1010CEF49: _dispatch_queue_resume_finalize_activation (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1014734F6: _notify_lib_init (in
/usr/lib/system/libsystem_notify.dylib)
==63832==by 0x101473B89: notify_register_dispatch (in
/usr/lib/system/libsystem_notify.dylib)
==63832==by 0x100332C27: CFUserNotificationCreate (in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==63832==by 0x1010BDD4F: _dispatch_client_callout (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x1010BDD02: dispatch_once_f (in
/usr/lib/system/libdispatch.dylib)
==63832==by 0x100332ADD: CFUserNotificationGetTypeID (in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==63832==by 0x1001ED210: -[CFPrefsPlistSource createSynchronizeMessage] (in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==63832==by 0x100375F96: -[NSOrderedSet objectsWithOptions:passingTest:]
(in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==63832==by 0x10037723E: +[NSOrderedSet orderedSetWithObject:] (in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==63832==by 0x100375CD2: -[NSOrderedSet objectWithOptions:passingTest:] (in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==63832==by 0x100375B64: -[NSOrderedSet isSubsetOfSet:] (in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==63832==by 0x10039BCE2: __CFGenerateReport (in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==63832==by 0x1001F5252: +[_CFXNotificationTokenRegistration
createTokenRegistration:token:connection:notifyToken:options:queue:handler:]
(in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==63832==by 0x1000E33E8: cupsLangGet (in /usr/lib/libcups.2.dylib)
==63832==by 0x1000E2A42: _cupsSetLocale (in /usr/lib/libcups.2.dylib)
==63832==by 0x10B72: ??? (in /usr/bin/lpq)
==63832==by 0x101131114: start (in /usr/lib/system/libdyld.dylib)

Thread 2: status = VgTs_Yielding (lwpid 4107)
==63832==at 0x1014E1E9B: _pthread_wqthread (in

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[Rhys Kidd]

https://bugs.kde.org/show_bug.cgi?id=385279

--- Comment #8 from Rhys Kidd  ---
(In reply to FX from comment #7)
> ==55783== valgrind: Unrecognised instruction at address 0x1010bfd93.
> ==55783==at 0x1010BFD93: _dispatch_kq_init (in
> /usr/lib/system/libdispatch.dylib)
> ==55783==by 0x1010BDD4F: _dispatch_client_callout (in
> /usr/lib/system/libdispatch.dylib)
> ==55783==by 0x1010BDD02: dispatch_once_f (in
> /usr/lib/system/libdispatch.dylib)
> ==55783==by 0x1010DBAAE: _dispatch_kq_poll (in
> /usr/lib/system/libdispatch.dylib)
> ==55783==by 0x1010DB735: _dispatch_kq_drain (in
> /usr/lib/system/libdispatch.dylib)
> ==55783==by 0x1010DAB03: _dispatch_kq_unote_update (in
> /usr/lib/system/libdispatch.dylib)
> ==55783==by 0x1010D5E33: _dispatch_source_refs_register (in
> /usr/lib/system/libdispatch.dylib)
> ==55783==by 0x1010D5F5D: _dispatch_source_finalize_activation (in
> /usr/lib/system/libdispatch.dylib)
> ==55783==by 0x1010CEF49: _dispatch_queue_resume_finalize_activation (in
> /usr/lib/system/libdispatch.dylib)
> ==55783==by 0x1014734F6: _notify_lib_init (in
> /usr/lib/system/libsystem_notify.dylib)
> ==55783==by 0x101473B89: notify_register_dispatch (in
> /usr/lib/system/libsystem_notify.dylib)
> ==55783==by 0x100332C27: CFUserNotificationCreate (in
> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/
> CoreFoundation)
> ==55783== Your program just tried to execute an instruction that Valgrind
> ==55783== did not recognise.  There are two possible reasons for this.
> 
> Several other native Apple programs (Preview, TextEdit) as well as non-Apple
> (Atom) give the same crash and error stack (with different addresses).
That's also another known issue: tracked at
https://bugs.kde.org/show_bug.cgi?id=383723

There is a draft patch available, which needs further testing and review.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[FX]

https://bugs.kde.org/show_bug.cgi?id=385279

--- Comment #7 from FX  ---
No, wrote to fast :)
I found another issue:

$ /tmp/bin/valgrind /usr/bin/lpq
==55783== Memcheck, a memory error detector
==55783== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==55783== Using Valgrind-3.14.0.GIT and LibVEX; rerun with -h for copyright
info
==55783== Command: /usr/bin/lpq
==55783== 
--55783-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option
--55783-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 2
times)
--55783-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 4
times)
--55783-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 8
times)
==55783== valgrind: Unrecognised instruction at address 0x1010bfd93.
==55783==at 0x1010BFD93: _dispatch_kq_init (in
/usr/lib/system/libdispatch.dylib)
==55783==by 0x1010BDD4F: _dispatch_client_callout (in
/usr/lib/system/libdispatch.dylib)
==55783==by 0x1010BDD02: dispatch_once_f (in
/usr/lib/system/libdispatch.dylib)
==55783==by 0x1010DBAAE: _dispatch_kq_poll (in
/usr/lib/system/libdispatch.dylib)
==55783==by 0x1010DB735: _dispatch_kq_drain (in
/usr/lib/system/libdispatch.dylib)
==55783==by 0x1010DAB03: _dispatch_kq_unote_update (in
/usr/lib/system/libdispatch.dylib)
==55783==by 0x1010D5E33: _dispatch_source_refs_register (in
/usr/lib/system/libdispatch.dylib)
==55783==by 0x1010D5F5D: _dispatch_source_finalize_activation (in
/usr/lib/system/libdispatch.dylib)
==55783==by 0x1010CEF49: _dispatch_queue_resume_finalize_activation (in
/usr/lib/system/libdispatch.dylib)
==55783==by 0x1014734F6: _notify_lib_init (in
/usr/lib/system/libsystem_notify.dylib)
==55783==by 0x101473B89: notify_register_dispatch (in
/usr/lib/system/libsystem_notify.dylib)
==55783==by 0x100332C27: CFUserNotificationCreate (in
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation)
==55783== Your program just tried to execute an instruction that Valgrind
==55783== did not recognise.  There are two possible reasons for this.

Several other native Apple programs (Preview, TextEdit) as well as non-Apple
(Atom) give the same crash and error stack (with different addresses).

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[Rhys Kidd]

https://bugs.kde.org/show_bug.cgi?id=385279

--- Comment #6 from Rhys Kidd  ---
(In reply to FX from comment #5)
> Louis' patch fixes it for me. I've been able to run various binaries (bash,
> zsh, clang, etc.) under valgrind on macOS 10.13.2 without any error.
Thanks for the additional testing feedback -- this patch is looking good to get
into the next release of Valgrind.

> Many binaries, however, generate some messages like early in their execution:
> 
> --55772-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option
> --55772-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 2
> times)
> --55772-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 4
> times)
> --55772-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 8
> times)
That is a separate issue, which is tracked at
https://bugs.kde.org/show_bug.cgi?id=343306

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[FX]

https://bugs.kde.org/show_bug.cgi?id=385279

--- Comment #5 from FX  ---
Louis' patch fixes it for me. I've been able to run various binaries (bash,
zsh, clang, etc.) under valgrind on macOS 10.13.2 without any error.

Many binaries, however, generate some messages like early in their execution:

--55772-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option
--55772-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 2
times)
--55772-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 4
times)
--55772-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 8
times)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[Rhys Kidd]

https://bugs.kde.org/show_bug.cgi?id=385279

Rhys Kidd  changed:

   What|Removed |Added

 CC||therealbenwi...@gmail.com

--- Comment #4 from Rhys Kidd  ---
*** Bug 387690 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385279] [PATCH] unhandled syscall: mach:43 (mach_generate_activity_id)

[Rhys Kidd]

https://bugs.kde.org/show_bug.cgi?id=385279

Rhys Kidd  changed:

   What|Removed |Added

Summary|unhandled syscall: mach:43  |[PATCH] unhandled syscall:
   |(mach_generate_activity_id) |mach:43
   ||(mach_generate_activity_id)

-- 
You are receiving this mail because:
You are watching all bug changes.