[valgrind] [Bug 405403] s390x disassembler cannot be used on x86
https://bugs.kde.org/show_bug.cgi?id=405403 Andreas Arnez changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Andreas Arnez --- Pushed as commit #7e9113cb7a249e0fae2a365462c6b0164de11566. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 405403] s390x disassembler cannot be used on x86
https://bugs.kde.org/show_bug.cgi?id=405403 --- Comment #5 from Andreas Arnez --- (In reply to Ilya Leoshkevich from comment #4) > I've expanded the commit message to indicate not only what the patch is for, > but also what it does and why. > > There are also two additional changes in v2: > > - #pragma pack was removed > > - last_execute_target is now also loaded byte-by-byte All these changes look good to me. I think this is ready to push. (In reply to Julian Seward from comment #2) > This will, I assume, create rebase issues for any other unlanded s390 > front end patches. But IIUC, that's only the initial z14 work. Yes? Right, as far as I know, that is the only pending change that may be affected. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 405403] s390x disassembler cannot be used on x86
https://bugs.kde.org/show_bug.cgi?id=405403 --- Comment #4 from Ilya Leoshkevich --- I've expanded the commit message to indicate not only what the patch is for, but also what it does and why. There are also two additional changes in v2: - #pragma pack was removed - last_execute_target is now also loaded byte-by-byte -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 405403] s390x disassembler cannot be used on x86
https://bugs.kde.org/show_bug.cgi?id=405403 Ilya Leoshkevich changed: What|Removed |Added Attachment #118753|0 |1 is obsolete|| --- Comment #3 from Ilya Leoshkevich --- Created attachment 118775 --> https://bugs.kde.org/attachment.cgi?id=118775=edit patch v2 -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 405403] s390x disassembler cannot be used on x86
https://bugs.kde.org/show_bug.cgi?id=405403 --- Comment #2 from Julian Seward --- (In reply to Andreas Arnez from comment #1) Andreas, if you think the patch is OK, and won't cause regressions, then fine, land it. It is however a huge patch and it would be nice to have a few lines of description in the commit message explaining what it does. This will, I assume, create rebase issues for any other unlanded s390 front end patches. But IIUC, that's only the initial z14 work. Yes? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 405403] s390x disassembler cannot be used on x86
https://bugs.kde.org/show_bug.cgi?id=405403 --- Comment #1 from Andreas Arnez --- Ilya, thanks for the patch. Your patch makes the code independent from endianness and a bit shorter than before. In my view this is a useful clean-up, and I haven't seen any problems with it in my testing. So I'd like to push this, if there are no objections. Does anyone see any issues with Ilya's approach? -- You are receiving this mail because: You are watching all bug changes.
