https://bugs.kde.org/show_bug.cgi?id=431157
Carl Love changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--- Comment #31 from Carl Love ---
closing
https://bugs.kde.org/show_bug.cgi?id=431157
Carl Love changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #29 from Julian Seward ---
(In reply to Carl Love from comment #27)
> Created attachment 137063 [details]
> patch to add support for the scv instruction
This looks OK to me.
> One issue with the patch is the SC_FLAG and SCV_FLAG defines.
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #28 from Carl Love ---
Mark,
I was wondering if you have had a chance to try out the updated version of the
scv patch. The updated patch takes care of the synchronous and asynchronous
call paths. You do need to make sure you are testing
https://bugs.kde.org/show_bug.cgi?id=431157
Carl Love changed:
What|Removed |Added
Attachment #136175|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #26 from Carl Love ---
Julian:
Yes, that is correct, the return value for an error is negative. The
condition code register is not used.
On Fri, 2021-03-05 at 09:57 +, Julian Seward wrote:
>
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #25 from Julian Seward ---
(In reply to Tom Hughes from comment #24)
> Indeed if that is -2 that would be errno 2 aka ENOENT which would make sense.
Agreed.
So then it would seem to me that the problem is that the patch doesn't
update
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #24 from Tom Hughes ---
Indeed if that is -2 that would be errno 2 aka ENOENT which would make sense.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #23 from Julian Seward ---
(In reply to Tom Hughes from comment #22)
> So if thinks the open was a success with a negative file descriptor returned?
Ah, maybe it's trying to tell us something :-) I vaguely remember reading
that this new
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #22 from Tom Hughes ---
This just before that is pretty odd:
SYSCALL[279836,1](286) sys_openat ( -100,
0x4a6ee28(/usr/lib/locale/locale-archive), 524288 ) --> [async] ...
SYSCALL[279836,1](286) ... [async] --> Success(0xfffe)
https://bugs.kde.org/show_bug.cgi?id=431157
Tom Hughes changed:
What|Removed |Added
CC||t...@compton.nu
--- Comment #21 from Tom Hughes
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #20 from Julian Seward ---
Looking at the end of the log there:
SYSCALL[279836,1](291) sys_newfstatat ( 24, 0x4a73980(), 0x4ad2578 )[sync] -->
Failure(0x9)
SYSCALL[279836,1](90) sys_mmap ( 0x0, 0, 1, 2, 24, 0 ) --> [pre-fail]
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #19 from Mark Wielaard ---
(In reply to Carl Love from comment #18)
> Created attachment 136175 [details]
> patch to add support for the scv instruction
>
> Rebased patch on Vaglrind mainline, enabled SCV which was masked out in
> Mark's
https://bugs.kde.org/show_bug.cgi?id=431157
Carl Love changed:
What|Removed |Added
Attachment #135371|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #17 from Mark Wielaard ---
For now I have pushed this commit:
commit ea98cccb4d50a8740708507c4c72cfb1e6c88e38
Author: Mark Wielaard
Date: Tue Feb 23 16:19:26 2021 +0100
Filter out unsupported instructions from HWCAP2 on powerpc.
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #16 from Mark Wielaard ---
(In reply to Carl Love from comment #15)
> Created attachment 135371 [details]
> patch to add support for the scv instruction
>
> Cleaned up formatting, spacing and a minor functional fix.
Unfortunately this
https://bugs.kde.org/show_bug.cgi?id=431157
Carl Love changed:
What|Removed |Added
Attachment #135358|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=431157
Carl Love changed:
What|Removed |Added
Attachment #134552|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #13 from Carl Love ---
>From discussions with IBM and RedHat, the plan for the short term is mask the
HWCAPS2 to force the use of the sc instruction instead of the newer scv0
instruction. I will work on a proper fix to support the scv0
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #12 from Carl Love ---
The Power support for Valgrind treats the Hardware Transactional Memory (HTM)
instructions effectively as NOPs. The transaction begin instruction (tbegin)
is always failed in Valgrind causing the code to execute the
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #11 from Mark Wielaard ---
(In reply to Florian Weimer from comment #10)
> What's the status here? The first glibc release with scv support is coming
> up. Thanks.
The status is still as in comment #7. There is a workaround (filtering out
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #10 from Florian Weimer ---
What's the status here? The first glibc release with scv support is coming up.
Thanks.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #9 from Florian Weimer ---
I think including the HTM bit is wrong, it should always be cleared along with
HTM_NOSC. I doubt valgrind supports HTM, so this ought to be the right thing to
do. It's definitely better than what we had before,
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #8 from Mark Wielaard ---
For reference, this explains the (newer) powerpc syscall conventions of the
linux kernel: https://www.kernel.org/doc/html/v5.10/powerpc/syscall64-abi.html
--
You are receiving this mail because:
You are watching
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #7 from Mark Wielaard ---
For now I have backported Florian's patch to the Fedora rawhide valgrind
package to get things unstuck:
https://koji.fedoraproject.org/koji/buildinfo?buildID=182
I had to tweak the patch a little to remove the
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #6 from Florian Weimer ---
Hmm. If we filter HTM_NOSC, we should also filter HTM.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #5 from Mark Wielaard ---
That looks plausible:
+/* Mask unrecognized HWCAP bits. Only keep the bits that have
+ * been mentioned above.
+ */
+auxv->u.a_val &= 0xfec4ULL;
So if I
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #4 from Florian Weimer ---
Created attachment 134659
--> https://bugs.kde.org/attachment.cgi?id=134659=edit
0001-ppc64-Mask-unrecognized-AT_HWCAP2-values.patch
This is what I came up with.
It filters out DARN as well, which I think is
https://bugs.kde.org/show_bug.cgi?id=431157
Mark Wielaard changed:
What|Removed |Added
Ever confirmed|0 |1
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #2 from Florian Weimer ---
I think this does not work because the calling convention for “sc” and “scv 0”
are different.
The glibc test case misc/test-errno-linux is a good way to exercise syscall
errors. Here's how you can run it under
https://bugs.kde.org/show_bug.cgi?id=431157
Mark Wielaard changed:
What|Removed |Added
CC||m...@klomp.org
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=431157
--- Comment #1 from Carl Love ---
Created attachment 134552
--> https://bugs.kde.org/attachment.cgi?id=134552=edit
patch to add support for the scv instruction
Please test the attached patch to see if it fixes your issue. Thanks.
--
You are
https://bugs.kde.org/show_bug.cgi?id=431157
Will Schmidt changed:
What|Removed |Added
CC||c...@us.ibm.com,
|
https://bugs.kde.org/show_bug.cgi?id=431157
Florian Weimer changed:
What|Removed |Added
CC||fwei...@redhat.com
--
You are receiving this
34 matches
Mail list logo
