subject:"\[valgrind\] \[Bug 433510\] FreeBSD support, part 12"

[valgrind] [Bug 433510] FreeBSD support, part 12

2021-10-09 Thread Paul Floyd

https://bugs.kde.org/show_bug.cgi?id=433510 Paul Floyd changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|---

[valgrind] [Bug 433510] FreeBSD support, part 12

2021-10-09 Thread Paul Floyd

https://bugs.kde.org/show_bug.cgi?id=433510 --- Comment #10 from Paul Floyd --- > > I don't understand what SIGSYS is/does. This patch adds/clears it > > unconditionally, not just for freebsd. Is that correct? > It doesn't seem to make any difference. A little test that uses syscall 600 (not

[valgrind] [Bug 433510] FreeBSD support, part 12

2021-10-08 Thread Ed Maste

https://bugs.kde.org/show_bug.cgi?id=433510 --- Comment #9 from Ed Maste --- > Commit 0 is an import from p4 I believe we still have the p4 repo backed somewhere but the server is down, without any easy way to restore it. It's probably not worth it to try to find out the origin of these little

[valgrind] [Bug 433510] FreeBSD support, part 12

2021-10-08 Thread Paul Floyd

https://bugs.kde.org/show_bug.cgi?id=433510 --- Comment #8 from Paul Floyd --- > In coregrind/m_debuginfo/storage.c we have: > > +#if defined(VGO_freebsd) > + if (sym->size == 0) > + sym->size = 1; > +#endif The source of this has been lost in the mists of time. The oldest hg repo that

[valgrind] [Bug 433510] FreeBSD support, part 12

2021-10-08 Thread Paul Floyd

https://bugs.kde.org/show_bug.cgi?id=433510 --- Comment #7 from Paul Floyd --- (In reply to Mark Wielaard from comment #5) > (In reply to Paul Floyd from comment #4) > > > - TRACE_SYMTAB("rx_map: avma %#lx size %lu foff %ld\n", > > > + TRACE_SYMTAB("rx_map: avma %#lx size

[valgrind] [Bug 433510] FreeBSD support, part 12

2021-10-08 Thread Julian Seward

https://bugs.kde.org/show_bug.cgi?id=433510 --- Comment #6 from Julian Seward --- (In reply to Mark Wielaard from comment #5) > (In reply to Paul Floyd from comment #4) > > > - TRACE_SYMTAB("rx_map: avma %#lx size %lu foff %ld\n", > > > + TRACE_SYMTAB("rx_map: avma %#lx

[valgrind] [Bug 433510] FreeBSD support, part 12

2021-10-08 Thread Mark Wielaard

https://bugs.kde.org/show_bug.cgi?id=433510 --- Comment #5 from Mark Wielaard --- (In reply to Paul Floyd from comment #4) > > - TRACE_SYMTAB("rx_map: avma %#lx size %lu foff %ld\n", > > + TRACE_SYMTAB("rx_map: avma %#lx size %lu foff %lld\n", > > ^^^ generates warnings

[valgrind] [Bug 433510] FreeBSD support, part 12

2021-10-08 Thread Paul Floyd

https://bugs.kde.org/show_bug.cgi?id=433510 --- Comment #4 from Paul Floyd --- (In reply to Mark Wielaard from comment #3) > We really should rename coregrind/m_aspacemgr/aspacemgr-linux.c one day... > > This code formatting is really ugly/unreadable: { VKI_MAP_STACK } I'll see what I can do.