[xdg-desktop-portal-kde] [Bug 466108] Quickly clicking "Show All Installed Apps" repeatedly in the app chooser makes it confuse states

2023-03-03 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=466108

Harald Sitter  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/xdg-desktop-portal-kde/c
   ||ommit/207c96aaeaf448c9a8c77
   ||f52e809611c6e5763cd

--- Comment #4 from Harald Sitter  ---
Git commit 207c96aaeaf448c9a8c77f52e809611c6e5763cd by Harald Sitter.
Committed on 03/03/2023 at 22:04.
Pushed by sitter into branch 'master'.

don't react on clicks for checkable buttons

clicked is distinct from doubleclicked and not the correct handler to
use for checkable buttons because of that. use toggle instead.

M  +1-3src/AppChooserDialog.qml

https://invent.kde.org/plasma/xdg-desktop-portal-kde/commit/207c96aaeaf448c9a8c77f52e809611c6e5763cd

-- 
You are receiving this mail because:
You are watching all bug changes.

[xdg-desktop-portal-kde] [Bug 466108] Quickly clicking "Show All Installed Apps" repeatedly in the app chooser makes it confuse states

2023-02-28 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=466108

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/170

-- 
You are receiving this mail because:
You are watching all bug changes.

[xdg-desktop-portal-kde] [Bug 466108] Quickly clicking "Show All Installed Apps" repeatedly in the app chooser makes it confuse states

2023-02-21 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=466108

Harald Sitter  changed:

   What|Removed |Added

 Status|ASSIGNED|CONFIRMED
 CC||sit...@kde.org

--- Comment #2 from Harald Sitter  ---
This is giving me a headache.

What happens is that we handle onClicked but if you click quickly enough the
second click issues onDoubleClicked. The state confusion then occurs because
clicks directly influence the checked state (though I have to admit I don't
understand how.

More specifically it appears the following happens for single click:
- click
- onCheckedChanged
- onClicked
- checked binding reevaluates

For a double click it is:
- click
- click
- onCheckedChanged
- onClicked
- checked binding reevaluates
- onCheckedChanged (the result of the second click)
- onDoubleClick

What I don't quite get is how the checked state can be directly manipulated
while also being a binding. I'd either expect the binding to break or
onCheckedChanged to not get emitted on clicks (without first running
onClicked).

I think this needs further investigation.

The fix at face value would be to not have checked be a binding and instead of
onclicked react to oncheckedchanged but that also seems a bit weird.

-- 
You are receiving this mail because:
You are watching all bug changes.

[xdg-desktop-portal-kde] [Bug 466108] Quickly clicking "Show All Installed Apps" repeatedly in the app chooser makes it confuse states

2023-02-20 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=466108

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #1 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/166

-- 
You are receiving this mail because:
You are watching all bug changes.