[yakuake] [Bug 313841] No keyboard shortcut for "Find" action

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=313841

Kurt Hindenburg  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://commits.kde.org/kon
   ||sole/6ba044c145a68b0356fde5
   ||cf210d9db812eba310
 Resolution|--- |FIXED

--- Comment #8 from Kurt Hindenburg  ---
Git commit 6ba044c145a68b0356fde5cf210d9db812eba310 by Kurt Hindenburg, on
behalf of Nicolas Fella.
Committed on 14/03/2019 at 03:25.
Pushed by hindenburg into branch 'master'.

Define shortcuts for Find actions also for konsolepart

Summary:
The find action in Yakuake (and other konsolepart users) is missing
a shortcut. This is because the shortcut is only defined for Konsole
and not for the part.

Test Plan: Press Ctrl + Shift + F in Yakuake, search bar opens

Reviewers: #konsole, hindenburg, hein

Reviewed By: #konsole, hindenburg

Subscribers: konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D19451

M  +10   -13   src/SessionController.cpp

https://commits.kde.org/konsole/6ba044c145a68b0356fde5cf210d9db812eba310

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 313841] No keyboard shortcut for "Find" action

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=313841

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 313841] No keyboard shortcut for "Find" action

[zhulik]

https://bugs.kde.org/show_bug.cgi?id=313841

--- Comment #7 from zhulik  ---
Seems like it's not possible to add a shortcut to run "Find" because the
terminal widget in yakuake works via KParts plugin system. I thinks it's needed
to change konsolepart itself and hell knows what else in KDE=(. Maybe it can be
done via some monkey patching through Qt reflections, but I don't have a time
to investigate it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 313841] No keyboard shortcut for "Find" action

[zhulik]

https://bugs.kde.org/show_bug.cgi?id=313841

zhulik  changed:

   What|Removed |Added

 CC||zhulik.g...@gmail.com

--- Comment #6 from zhulik  ---
I'm a Qt developer with 5 years experience and I've just spent two hours trying
to find where is "Find" action defined is sources. But I did't find neither in
yakuake source nor in konsole. I give up. If somebody helps me to find it I
will make a pull request with fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 313841] No keyboard shortcut for "Find" action

[Alexander Mentyu]

https://bugs.kde.org/show_bug.cgi?id=313841

Alexander Mentyu  changed:

   What|Removed |Added

 CC||notux...@gmail.com

--- Comment #5 from Alexander Mentyu  ---
Confirming this bug on Yakuake 3.0.4+ . Think 'Ctrl+Alt+F' key combination
would fit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 313841] No keyboard shortcut for "Find" action

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=313841

Eike Hein  changed:

   What|Removed |Added

 CC||digikam-b...@reg.valik.sk

--- Comment #3 from Eike Hein  ---
*** Bug 382009 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 313841] No keyboard shortcut for "Find" action

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=313841

Eike Hein  changed:

   What|Removed |Added

 CC||j...@noorman.info

--- Comment #4 from Eike Hein  ---
*** Bug 382709 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 313841] No keyboard shortcut for "Find" action

[arcanis via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=313841

arcanis  changed:

   What|Removed |Added

 CC||darkarca...@mail.ru

--- Comment #2 from arcanis  ---
same here, using latest git build for frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.