[Falkon] [Bug 391370] bundled qtsingleapplication

2019-03-14 Thread David Rosca
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #20 from David Rosca  ---
In next few days.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2019-03-14 Thread Kevin Kofler
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #19 from Kevin Kofler  ---
When will this (and the other post-3.0 changes) get released? The 3.0.1 release
is now more than 10 months old.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2019-03-14 Thread David Rosca
https://bugs.kde.org/show_bug.cgi?id=391370

David Rosca  changed:

   What|Removed |Added

 Resolution|--- |INTENTIONAL
 Status|REPORTED|RESOLVED

--- Comment #18 from David Rosca  ---
It now uses DBus on Linux, so it's now completely different from upstream
QtSingleApplication.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-10-01 Thread Moonchild
https://bugs.kde.org/show_bug.cgi?id=391370

Moonchild  changed:

   What|Removed |Added

 CC|private2@yandex.com |

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #17 from private2@yandex.com ---
That's a list of the functions colled from the embeded api:

On start:

QtSingleApplication
setAppId
sysInit
QtLockedFile
QtLocalPeer
open
isRunning
isClient
isLocked
lock

On exit:
removeLockFile
removeLockedFile
~QtLockedFile

Unfortunately, i failed to get that from the external library.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-06 Thread Kevin Kofler
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #16 from Kevin Kofler  ---
So I think I see where the issue is. First, we construct the
QtSingleApplication with the default appId, which calls sysInit() once. Then,
setAppId is called, which calls sysInit(appId) and creates a new socket,
without deleting the old one first.

I would blame the modifications from QupZilla/Falkon adding that setAppId
method. But the bundled version in QupZilla/Falkon has that too, so I don't see
why you are not seeing this bug with that version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #15 from private2@yandex.com ---
I was focused most likely to the added „curly braces“
Also, i'm not a developer, so i really don't know what makes that difference.
I only can see the fact that the bundled app cleans the tmp file, which is the
right behavior for me.
If i'm wrong, really sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-06 Thread Kevin Kofler
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #14 from Kevin Kofler  ---
Comment on attachment 111214
  --> https://bugs.kde.org/attachment.cgi?id=111214
Difference

The added braces around one-line conditionals do not change anything.
QT_VERSION >= QT_VERSION_CHECK(4,5,0) is also always true. The addition of
removeLockedFile() is already in the patch that we carry. The socket-related
changes, I doubt they make any difference either.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #13 from private2@yandex.com ---
Ah ha, when it works in Open suse the same way, we should accept that is the
right way!?
I just attached a diff file between original „qtlocalpeer.cpp“ and Falkon
„qtlocalpeer.cpp". You can see the difference yourself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #12 from private2@yandex.com ---
Created attachment 111214
  --> https://bugs.kde.org/attachment.cgi?id=111214=edit
Difference

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-05 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #11 from Christoph Feck  ---
QtSingleApplication also leaves temporary files on Tumbleweed (e.g. for
SMPlayer and Otter Browser), so it does not look like a downstream bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #10 from private2@yandex.com ---
(In reply to Kevin Kofler from comment #9)
Done: https://bugzilla.redhat.com/show_bug.cgi?id=1551678

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-05 Thread Kevin Kofler
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #9 from Kevin Kofler  ---
Can you please file a bug against qtsingleapplication at bugzilla.redhat.com?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #8 from private2@yandex.com ---
I noticed that the QupZill/Falkon qtsingleapplication source has a lot of
corrections which are not applied in the original source, so probably there is
the reason.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #7 from private2@yandex.com ---
I'm absolutely sure. „qtsingleapp-qupzil--xxx-lockfile“ is always remains
in /tmp with this package:
http://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Everything/source/tree/Packages/q/qtsingleapplication-2.6.1-32.fc28.src.rpm
If build QupZilla with bundled qtsingleapplication, it is always deleted.
So what is the reason that file to stays undeleted!?
Sorry for the bad English!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-05 Thread David Rosca
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #6 from David Rosca  ---
No, that patch is fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-05 Thread Kevin Kofler
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #5 from Kevin Kofler  ---
Huh? Are you sure? The patch adds the missing removeLockFile function to the
system QtSingleApplication. This looks no different to me from what the bundled
QtSingleApplication in QupZilla/Falkon does. Am I missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391370

private2@yandex.com changed:

   What|Removed |Added

 CC||private2@yandex.com

--- Comment #4 from private2@yandex.com ---
„qtsingleapplication-qupzilla.patch“ is sucks, because QupZilla does not clean
tmp file on quit with it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-04 Thread Kevin Kofler
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #3 from Kevin Kofler  ---
Created attachment 89
  --> https://bugs.kde.org/attachment.cgi?id=89=edit
falkon-3.0.0-system-qtsingleapplication.patch

This patch, along with "rm -fr src/lib/3rdparty/qtsingleapplication", works for
me on Fedora. (Of course, this will only work if you use a system
QtSingleApplication with the aforementioned API patch.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-04 Thread Kevin Kofler
https://bugs.kde.org/show_bug.cgi?id=391370

Kevin Kofler  changed:

   What|Removed |Added

 CC||kevin.kof...@chello.at

--- Comment #2 from Kevin Kofler  ---
On some distros you can, because they carry the required API addition patch in
QtSingleApplication, e.g.:
https://src.fedoraproject.org/cgit/rpms/qtsingleapplication.git/tree/qtsingleapplication-qupzilla.patch

We have been building QupZilla against the system QtSingleApplication in Fedora
all this time.

For QupZilla, we used:

# unbundle qtsingleapplication
rm -fr src/lib/3rdparty/qtsingleapplication
ln -s %{_qt5_headerdir}/QtSolutions src/lib/3rdparty/qtsingleapplication
sed -i 's,include.*qtsingleapplication.*,,' src/plugins.pri
sed -i 's,include.*qtsingleapplication.*,,' src/lib/lib.pro

but now I have to adapt this for CMake.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 391370] bundled qtsingleapplication

2018-03-04 Thread David Rosca
https://bugs.kde.org/show_bug.cgi?id=391370

--- Comment #1 from David Rosca  ---
It uses modified QtSingleApplication, so you can't build it against system
version.

-- 
You are receiving this mail because:
You are watching all bug changes.