[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 Vlad Zagorodniy changed: What|Removed |Added Assignee|vladz...@gmail.com |hugo.pereira.da.costa@gmail ||.com URL|https://phabricator.kde.org | |/D21432 | |https://phabricator.kde.org | |/D21433 | Version Fixed In||5.17.0 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 Vlad Zagorodniy changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #21 from Vlad Zagorodniy --- I think it can be marked as fixed, at least Breeze/Oxygen part. Aurorae part has to be fixed in KWin itself. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 --- Comment #20 from Hugo Pereira Da Costa --- Git commit 72a70ceacc0434c04ddd795b5f2c093cba588b26 by Hugo Pereira Da Costa. Committed on 03/06/2019 at 10:38. Pushed by hpereiradacosta into branch 'master'. Disable extended resize borders for maximized windows M +3-3kdecoration/oxygendecoration.cpp https://commits.kde.org/oxygen/72a70ceacc0434c04ddd795b5f2c093cba588b26 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 --- Comment #19 from Vlad Zagorodniy --- > Sorry if I missed some existing review requests on this: No problemo. :-) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 --- Comment #18 from Hugo Pereira Da Costa --- Git commit c95b7652b7afbcc1bfc54f9185d2be4953acc119 by Hugo Pereira Da Costa. Committed on 03/06/2019 at 10:25. Pushed by hpereiradacosta into branch 'master-kde'. Disable extended resize borders for maximized windows M +3-3kdecoration/breezedecoration.cpp https://commits.kde.org/breeze/c95b7652b7afbcc1bfc54f9185d2be4953acc119 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 --- Comment #16 from Vlad Zagorodniy --- Not exactly, you cannot resize shaded windows because kwin doesn't allow that. Perhaps kwin could reset the decoration input window for shaded clients without relying on the decoration theme to update resize-only borders accordingly... In either case, your patch is good to go. :-) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 --- Comment #17 from Hugo Pereira Da Costa --- (In reply to Vlad Zagorodniy from comment #16) > Not exactly, you cannot resize shaded windows because kwin doesn't allow > that. Right ! confirmed. (I thought it was possible with non zero side borders, but indeed it is not, even in that case) > Perhaps kwin could reset the decoration input window for shaded > clients without relying on the decoration theme to update resize-only > borders accordingly... > > In either case, your patch is good to go. :-) ok. I'll push for both oxygen and breeze. Sorry if I missed some existing review requests on this: I don't automatically get the notificatiosn of those anymore after having stepped down from maintainership (and because of being annoyed by some people commenting excessively on those in the past). Hugo -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 --- Comment #15 from Hugo Pereira Da Costa --- > > > Heh, it's more simpler than the one I proposed. Perhaps we need to unset > resize-only borders for shaded clients too, so there is no dead zone around > each shaded client. Interesting: right now, in breeze, if I set the window borders to no-sides or no-borders, in fact the extended sides do not apply to the decoration title (whether the window is shaded or not), and shaded windows cannot be resized at all. Not from the top or bottom, by construction, but also not on the sides, because there is no extended sides. So: I don't see a dead zone around shaded clients, but there is no way to resize them either. This is true whether or not you allow resizing maximized windows. Do you confirm ? Should this be considered a bug ? -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 --- Comment #14 from Vlad Zagorodniy --- (In reply to Hugo Pereira Da Costa from comment #12) > I think it can be disabled inside the window decoration code itself. But > should it not better be disabled upstream ? (in kdecoration or kwin) ? It can be disabled in kdecoration, but I'm personally more in favor leaving this decision to the decoration theme. (In reply to Hugo Pereira Da Costa from comment #13) > Patch for breeze: > Heh, it's more simpler than the one I proposed. Perhaps we need to unset resize-only borders for shaded clients too, so there is no dead zone around each shaded client. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989
--- Comment #13 from Hugo Pereira Da Costa ---
Patch for breeze:
diff --git a/kdecoration/breezedecoration.cpp
b/kdecoration/breezedecoration.cpp
index 10686506..d5526ce2 100644
--- a/kdecoration/breezedecoration.cpp
+++ b/kdecoration/breezedecoration.cpp
@@ -423,10 +423,10 @@ namespace Breeze
int extBottom = 0;
if( hasNoBorders() )
{
-extSides = extSize;
-extBottom = extSize;
+if( !isMaximizedHorizontally() ) extSides = extSize;
+if( !isMaximizedVertically() ) extBottom = extSize;
-} else if( hasNoSideBorders() ) {
+} else if( hasNoSideBorders() && !isMaximizedHorizontally() ) {
extSides = extSize;
--
You are receiving this mail because:
You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pereira.da.costa@gmail ||.com --- Comment #12 from Hugo Pereira Da Costa --- for oxygen and breeze at least, this is probably due to the "extended window borders", the ability to resize windows from "outside" the window. It is enabled only when there is no border drawn. It is not disabled for maximized windows it seems. When you have only one monitor, this is not an issue because outside of the window for a maximized window means outside of the screen. This is not the case in multimonitor setup. I think it can be disabled inside the window decoration code itself. But should it not better be disabled upstream ? (in kdecoration or kwin) ? Hugo -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 --- Comment #11 from Vlad Zagorodniy --- Tracking this bugs becomes a bit messy. Can you please file corresponding bug against Plastik? (product: kwin, component: Aurorae) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 --- Comment #10 from Vlad Zagorodniy --- Can confirm with the Plastik decoration theme, but not with other Aurorae decoration themes. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 Vlad Zagorodniy changed: What|Removed |Added URL|https://phabricator.kde.org |https://phabricator.kde.org |/D21432,https://phabricator |/D21432 |.kde.org/D21433 |https://phabricator.kde.org ||/D21433 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 Vlad Zagorodniy changed: What|Removed |Added URL|https://phabricator.kde.org |https://phabricator.kde.org |/D21432 |/D21432,https://phabricator ||.kde.org/D21433 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 407989] Maximized windows can be resized on multi monitor setups
https://bugs.kde.org/show_bug.cgi?id=407989 Vlad Zagorodniy changed: What|Removed |Added Product|kwin|Breeze Component|general |window decoration Flags|ReviewRequest+ | -- You are receiving this mail because: You are watching all bug changes.
