[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In|5.18|5.18.1 Resolution|--- |FIXED Latest Commit|https://commits.kde.org/bre |https://cgit.kde.org/breeze |eze-gtk/c9ac507ff3c2e700b37 |-gtk.git/commit/?id=d3e9aa7 |ed4394de6ce1356025f6c |37502b06e9080a87059f8b40660 ||08c589 --- Comment #18 from Nate Graham --- author Carson Black 2020-02-13 20:23:43 -0500 committer Carson Black 2020-02-14 10:38:13 -0500 commit d3e9aa737502b06e9080a87059f8b4066008c589 (patch) tree8e20d455586c3b7e0be554f583dd379766746407 parent 63584449cd7131f4293fb004d16e5293ce073c72 (diff) [GTK3] Fix menubar coloursPlasma/5.18 Summary: This patch uses strictly content fg/bg for menubars instead of a mix, and moves the window titlebar colours into the CSD class. Reviewers: #breeze Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27390 Diffstat -rw-r--r-- src/gtk3/applications/_chromium.scss8 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Carson Black changed: What|Removed |Added CC||sakii...@aosc.io --- Comment #17 from Carson Black --- *** Bug 417612 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Nate Graham changed: What|Removed |Added Severity|normal |major Status|REOPENED|CONFIRMED CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Nico Dorn changed: What|Removed |Added CC||nicod...@posteo.de --- Comment #16 from Nico Dorn --- (In reply to Ivan Safonov from comment #14) > It seems like "Active Titlebar Text" has a wrong colour in the Breeze theme Changing that option makes things even worse. The menu of the Electron app would be fine, but the titlebar text would be unrecognizable in all and every window. I'm dispatching the following on autostart which fixes the issue for me: sed -i 's/theme_titlebar_foreground.*/theme_titlebar_foreground rgb(35,38,39);/' "$HOME/.config/gtk-3.0/colors.css" -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #15 from Ivan Safonov --- Or '@theme_titlebar_foreground' should be changed to something else -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #14 from Ivan Safonov --- Created attachment 125847 --> https://bugs.kde.org/attachment.cgi?id=125847&action=edit Breeze and Breeze Light colour difference It seems like "Active Titlebar Text" has a wrong colour in the Breeze theme -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Ivan Safonov changed: What|Removed |Added CC||safonov.iva...@gmail.com --- Comment #13 from Ivan Safonov --- Same issue. It works properly with colour schemes like "Breeze Dark" or "Breeze Light", but with "Breeze" scheme menu text is barely visible. Operating System: KDE neon 5.18 KDE Plasma Version: 5.18.0 KDE Frameworks Version: 5.67.0 Qt Version: 5.13.2 Kernel Version: 5.3.0-28-generic OS Type: 64-bit -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com Ever confirmed|0 |1 Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #12 from Patrick Silva --- I can confirm that this bug persists on Plasma 5.18 beta. :( Operating System: Arch Linux KDE Plasma Version: 5.17.90 KDE Frameworks Version: 5.66.0 Qt Version: 5.14.0 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #11 from hexchain --- Forgot to say that I'm on Arch Linux, Plasma 5.18 beta now. The active color scheme is Breeze. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #10 from hexchain --- Created attachment 125209 --> https://bugs.kde.org/attachment.cgi?id=125209&action=edit The said script in #c8 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #9 from hexchain --- Created attachment 125208 --> https://bugs.kde.org/attachment.cgi?id=125208&action=edit Electron6 menu bar (7 looks the same) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915
hexchain changed:
What|Removed |Added
CC||i...@hexchain.org
--- Comment #8 from hexchain ---
I'm afraid this change did not fix anything for me. Now the menu bar items in
Electron are hardly readable. A screenshot is attached.
It could be stale configurations on my side, but I am sure I have a fresh
~/.config/gtk-3.0/colors.css.
Electron uses a set of CSS selectors to get color for the menubar item text
from the current theme, see [1]. I've written a simple script to replicate most
of this logic according to [1] and [2], and the result is indeed
unsatisfactory.
Currently, to work around this issue, I have the following lines in
~/.config/gtk-3.0/gtk.css:
window.background.chromium menubar, window.background.chromium .menubar {
color: @theme_fg_color;
}
[1]
https://sourcegraph.com/github.com/electron/electron@v7.1.9/-/blob/shell/browser/ui/views/menu_bar.cc#L294-297
[2]
https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/libgtkui/gtk_util.cc;l=474;drc=3085f123db39ded55bccebcd1e508ad94bc8ef50?originalUrl=https:%2F%2Fcs.chromium.org%2F
--
You are receiving this mail because:
You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #7 from Carson Black --- (In reply to Eric Donkersloot from comment #6) > Thank you for picking this one up; much appreciated. No problem :) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #6 from Eric Donkersloot --- Thank you for picking this one up; much appreciated. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915
Carson Black changed:
What|Removed |Added
Resolution|--- |FIXED
Version Fixed In||5.18
Latest Commit||https://commits.kde.org/bre
||eze-gtk/c9ac507ff3c2e700b37
||ed4394de6ce1356025f6c
Status|REPORTED|RESOLVED
--- Comment #5 from Carson Black ---
Git commit c9ac507ff3c2e700b37ed4394de6ce1356025f6c by Carson Black.
Committed on 11/01/2020 at 17:46.
Pushed by cblack into branch 'master'.
[GTK3] Improve Electron menubar legibility
Summary:
Electron apps using a menubar are now more legible. This has the side effect of
forcing background tabs in Chrome/ium to not have an inactive appearance, as
`window > menubar`
provides the styling for both Electron's menubar and Chrome/ium's tabs.
FIXED-IN: 5.18
Test Plan:
Before: {F7877561} {F7877562}
After: {F7877563} {F7877564}
Reviewers: #vdg, #breeze, ndavis
Reviewed By: #vdg, #breeze, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26587
M +1-1src/gtk3/applications/_chromium.scss
https://commits.kde.org/breeze-gtk/c9ac507ff3c2e700b37ed4394de6ce1356025f6c
--
You are receiving this mail because:
You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #4 from Eric Donkersloot --- Still an issue on 5.17.5: Operating System: Arch Linux KDE Plasma Version: 5.17.5 KDE Frameworks Version: 5.65.0 Qt Version: 5.14.0 Kernel Version: 5.4.10-arch1-1 OS Type: 64-bit Processors: 8 × Intel® Core™ i7-8550U CPU @ 1.80GHz Memory: 15,4 GiB of RAM -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Eric Donkersloot changed: What|Removed |Added Version|5.17.4 |5.17.5 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #3 from Eric Donkersloot --- Still an issue using breeze-gtk 5.17.4-1 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Eric Donkersloot changed: What|Removed |Added Version|5.17.2 |5.17.4 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Eric Donkersloot changed: What|Removed |Added Attachment #123775|0 |1 is obsolete|| --- Comment #2 from Eric Donkersloot --- Created attachment 123776 --> https://bugs.kde.org/attachment.cgi?id=123776&action=edit Screenshot (the correct one this time) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 Eric Donkersloot changed: What|Removed |Added CC||eric.donkersl...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 413915] All electron apps have grey menus when using breeze gtk3 theme
https://bugs.kde.org/show_bug.cgi?id=413915 --- Comment #1 from Eric Donkersloot --- Created attachment 123775 --> https://bugs.kde.org/attachment.cgi?id=123775&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes.
