[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #23 from Emilio Cobos Álvarez (:emilio) --- (In reply to Emilio Cobos Álvarez (:emilio) from comment #22) > (In reply to Fushan Wen from comment #21) > Negative margins aren't considered > [here](https://searchfox.org/mozilla-central/rev/ > f4d3fe187cf7dffa4c13b354bbde9bc47b5ccd3f/widget/gtk/gtk3drawing.cpp#285-297), > so probably it's a matter of tweaking that code appropriately. I was wrong and margins are accounted for elsewhere (see `buttonMargin` in that file), so it needs some more debugging, but I'd be happy to help either way. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Emilio Cobos Álvarez (:emilio) changed: What|Removed |Added CC||emi...@crisal.io --- Comment #22 from Emilio Cobos Álvarez (:emilio) --- (In reply to Fushan Wen from comment #21) > When Firefox draws its window controls, margins and paddings are > also considered, so we can't use button padding hack to expand the > control areas of window controls. FWIW if Firefox was the only app affected I'd be happy to help making it work. Negative margins aren't considered [here](https://searchfox.org/mozilla-central/rev/f4d3fe187cf7dffa4c13b354bbde9bc47b5ccd3f/widget/gtk/gtk3drawing.cpp#285-297), so probably it's a matter of tweaking that code appropriately. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #20 from Fushan Wen --- Git commit cbab51eebfe21827830ada2ee4b339c43371ca86 by Fushan Wen. Committed on 10/05/2023 at 04:28. Pushed by fusionfuture into branch 'master'. gtk3: revert button padding hack When Firefox draws its window controls, margins and paddings are also considered, so we can't use button padding hack to expand the control areas of window controls. M +0-35 src/gtk3/widgets/_window_decorations.scss https://invent.kde.org/plasma/breeze-gtk/commit/cbab51eebfe21827830ada2ee4b339c43371ca86 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #21 from Fushan Wen --- Git commit 2f2923c2a5ce8b656e2f531bb0791c1ec105873a by Fushan Wen. Committed on 22/05/2023 at 14:39. Pushed by fusionfuture into branch 'Plasma/5.27'. gtk3: revert button padding hack When Firefox draws its window controls, margins and paddings are also considered, so we can't use button padding hack to expand the control areas of window controls. (cherry picked from commit cbab51eebfe21827830ada2ee4b339c43371ca86) M +0-35 src/gtk3/widgets/_window_decorations.scss https://invent.kde.org/plasma/breeze-gtk/commit/2f2923c2a5ce8b656e2f531bb0791c1ec105873a -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #19 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/83 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added Version Fixed In||5.27.4 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Fushan Wen changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/breeze-gtk/commit/0f8871 |ma/breeze-gtk/commit/83f4f7 |27b929ac2d50b22af1bb97fc254 |c184954eb89aaea52684f1ce076 |11b40aa |873e8c3 --- Comment #18 from Fushan Wen --- Git commit 83f4f7c184954eb89aaea52684f1ce076873e8c3 by Fushan Wen. Committed on 29/03/2023 at 16:56. Pushed by fusionfuture into branch 'Plasma/5.27'. gtk4/windowcontrols: extend control area to window borders This makes GTK4 window control buttons follow Fitts' law. (cherry picked from commit 0f887127b929ac2d50b22af1bb97fc25411b40aa) M +42 -152 src/gtk4/widgets/_window_decorations.scss https://invent.kde.org/plasma/breeze-gtk/commit/83f4f7c184954eb89aaea52684f1ce076873e8c3 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #17 from Fushan Wen --- Git commit 59448164f7df462ae4a2c1119f6be59146d60399 by Fushan Wen. Committed on 29/03/2023 at 16:56. Pushed by fusionfuture into branch 'Plasma/5.27'. gtk3/titlebutton: extend control area to window borders (cherry picked from commit d11333a830a4fdf6482c176e9a036e236bc80134) M +21 -9src/gtk3/widgets/_window_decorations.scss M +7-3src/gtk4/widgets/_window_decorations.scss https://invent.kde.org/plasma/breeze-gtk/commit/59448164f7df462ae4a2c1119f6be59146d60399 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #16 from Fushan Wen --- Git commit d11333a830a4fdf6482c176e9a036e236bc80134 by Fushan Wen. Committed on 29/03/2023 at 16:52. Pushed by fusionfuture into branch 'master'. gtk3/titlebutton: extend control area to window borders M +21 -9src/gtk3/widgets/_window_decorations.scss M +7-3src/gtk4/widgets/_window_decorations.scss https://invent.kde.org/plasma/breeze-gtk/commit/d11333a830a4fdf6482c176e9a036e236bc80134 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Fushan Wen changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/breeze-gtk/commit/0f8871 ||27b929ac2d50b22af1bb97fc254 ||11b40aa Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #15 from Fushan Wen --- Git commit 0f887127b929ac2d50b22af1bb97fc25411b40aa by Fushan Wen. Committed on 29/03/2023 at 16:52. Pushed by fusionfuture into branch 'master'. gtk4/windowcontrols: extend control area to window borders This makes GTK4 window control buttons follow Fitts' law. M +42 -152 src/gtk4/widgets/_window_decorations.scss https://invent.kde.org/plasma/breeze-gtk/commit/0f887127b929ac2d50b22af1bb97fc25411b40aa -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added Resolution|UPSTREAM|--- Status|RESOLVED|REPORTED Ever confirmed|1 |0 --- Comment #14 from Nate Graham --- In progress with https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/71 since it turns out we *can* work around it in breeze-gtk and the GTK folks don't seem interested in fixing it generically. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added CC||david.cortes.rivera@gmail.c ||om --- Comment #13 from Nate Graham --- *** Bug 467021 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |UPSTREAM URL||https://gitlab.gnome.org/GN ||OME/gtk/-/issues/583 --- Comment #12 from Nate Graham --- Unfortunately this is an upstream bug in GTK itself that we can't work around in the Breeze GTK theme. See https://gitlab.gnome.org/GNOME/gtk/-/issues/583 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added CC||jchevar...@gmail.com --- Comment #11 from Nate Graham --- *** Bug 450946 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added Priority|VHI |HI -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added Priority|NOR |VHI --- Comment #10 from Nate Graham --- Fair enough! -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #9 from guimarcalsi...@gmail.com --- After reading Nate's blog post about the 15-Minute Bug Initiative (https://pointieststick.com/2022/01/18/the-15-minute-bug-initiative/), I believe this bug is a nice candidate for the list. GTK apps are a big part of the Linux desktop and this issue can be seen pretty quickly by any user who switches to using Plasma from other GTK DEs and want to keep using the programs they were used to. This also has 4 duplicates, so it's something that has been affecting a considerable amount of people. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #8 from Ninguém --- Created attachment 138012 --> https://bugs.kde.org/attachment.cgi?id=138012=edit margin This still happens in KDE 5.21.4. It seems that there's a margin in the window buttons panel. If Qogir theme (square version) is applied, this problem gets more noticeable. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Ninguém changed: What|Removed |Added Version|5.17.3 |5.21.4 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #7 from Lua <7d8ec5ed-2c18-46c5-9aec-31c49a4b2...@anonaddy.me> --- Also, this still happens in KDE 5.21.4 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #6 from Lua <7d8ec5ed-2c18-46c5-9aec-31c49a4b2...@anonaddy.me> --- I forgot to mention: I opened Spectacle and Firefox to show this bug while I'm using Qogir window decoration theme. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #5 from Lua <7d8ec5ed-2c18-46c5-9aec-31c49a4b2...@anonaddy.me> --- Created attachment 137696 --> https://bugs.kde.org/attachment.cgi?id=137696=edit bug It seems that there are some margins preventing the buttons to fully expand. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 --- Comment #4 from Nate Graham --- *** Bug 434897 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added CC||toadfi...@tutanota.com --- Comment #3 from Nate Graham --- *** Bug 434734 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added CC||guimarcalsi...@gmail.com --- Comment #2 from Nate Graham --- *** Bug 430632 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Mathew changed: What|Removed |Added CC||model...@outlook.com.au -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added CC||oceanodefol...@pm.me --- Comment #1 from Nate Graham --- *** Bug 421937 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 414777] Top-right-most pixel does not trigger right-most button in a GTK3 CSD headerbar app
https://bugs.kde.org/show_bug.cgi?id=414777 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
