[Breeze] [Bug 450870] Zoom icons in FreeCAD toolbar fall back to `zoom` due to lack of more specific icons
https://bugs.kde.org/show_bug.cgi?id=450870 Nate Graham changed: What|Removed |Added Version Fixed In||5.93 Latest Commit||https://invent.kde.org/fram ||eworks/breeze-icons/commit/ ||ff66b122c49a4ce33567c78c836 ||7a0f68834c0a4 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #6 from Nate Graham --- Git commit ff66b122c49a4ce33567c78c8367a0f68834c0a4 by Nate Graham. Committed on 21/03/2022 at 14:03. Pushed by ngraham into branch 'master'. Add some more symlinks for zoom icons Now we also have `zoom-selection` (which is the same as `zoom-select) and `zoom-all` (which is the same as zoom-original). These icon names are used by FreeCAD. FIXED-IN: 5.93 A +1-0icons-dark/actions/16/zoom-all.svg A +1-0icons-dark/actions/16/zoom-selection.svg A +1-0icons-dark/actions/22/zoom-all.svg A +1-0icons-dark/actions/22/zoom-selection.svg A +1-0icons-dark/actions/32/zoom-all.svg A +1-0icons-dark/actions/32/zoom-selection.svg A +1-0icons/actions/16/zoom-all.svg A +1-0icons/actions/16/zoom-selection.svg A +1-0icons/actions/22/zoom-all.svg A +1-0icons/actions/22/zoom-selection.svg A +1-0icons/actions/32/zoom-all.svg A +1-0icons/actions/32/zoom-selection.svg https://invent.kde.org/frameworks/breeze-icons/commit/ff66b122c49a4ce33567c78c8367a0f68834c0a4 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 450870] Zoom icons in FreeCAD toolbar fall back to `zoom` due to lack of more specific icons
https://bugs.kde.org/show_bug.cgi?id=450870 --- Comment #5 from Nate Graham --- Thanks, that's very helpful! I was right, it's asking for `zoom-all` and `zoom-selection` which don't exist in the Breeze icon theme, so we fall back to `zoom`, which is sort of ugly. We do have `zoom-select` and `zoom-fit-selection` which are clearly in the same ballpark as `zoom-selection`. And `zoom-original` seems like a reasonable match for `zoom-all`. I will make some symlinks in the Breeze icon theme so that the icons FreeCad is asking for will map to icons we have. After that, we would need to fix Bug 435671 to get better zoom iconography in general. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 450870] Zoom icons in FreeCAD toolbar fall back to `zoom` due to lack of more specific icons
https://bugs.kde.org/show_bug.cgi?id=450870 --- Comment #4 from Giorgio --- (In reply to Nate Graham from comment #3) > 2. We don't have an exact match for whatever icon FreeCad is using. I don't > know what it is though. I think we'd need to read the source code in FreeCAD > to find out You can probably find it here https://forum.openmandriva.org/t/freecad-wont-install/4262/32?u=giorgio thanks to excellent work of mandian -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 450870] Zoom icons in FreeCAD toolbar fall back to `zoom` due to lack of more specific icons
https://bugs.kde.org/show_bug.cgi?id=450870 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED Product|kde |Breeze Summary|FreeCAD GUI icon missing|Zoom icons in FreeCAD ||toolbar fall back to `zoom` ||due to lack of more ||specific icons Assignee|[email protected] |[email protected] Component|general |Icons CC||[email protected], ||[email protected] --- Comment #3 from Nate Graham --- The icons aren't missing; those *are* the icons in the Breeze theme. I agree that they aren't very good though. Looks like that icon being used for both buttons is `zoom`, which would be the fallback icon in the case of the requested icon not being found in the Breeze icon theme. For example if FreeCAD asks for `zoom-rectangle` (random example) that icon would not exist in the theme so it would fall back to just `zoom`, which does not look very good. So there are a few issues here: 1. Our Zoom icons are not very good. See Bug 435671 2. We don't have an exact match for whatever icon FreeCad is using. I don't know what it is though. I think we'd need to read the source code in FreeCAD to find out 3. (possibly) FreeCAD is not using the right icon names and should switch to names that are more standard. Would also need to read the source code for this -- You are receiving this mail because: You are watching all bug changes.
