[Discover] [Bug 437681] "Successfully updated n packages" notification following offline update is unnecessary

2021-06-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437681

Nate Graham  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.23
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/discover/commit/3f6cfb02
   ||f751aa59d9e4bff06964103c37c
   ||28a08

--- Comment #4 from Nate Graham  ---
Git commit 3f6cfb02f751aa59d9e4bff06964103c37c28a08 by Nate Graham.
Committed on 14/06/2021 at 23:46.
Pushed by ngraham into branch 'master'.

Only show "Successful Offline Update" notification on mobile

In general, our HIG recommends against showing notifications for success,
because the user expects actions that they initiate to succeed. However
apparently things are different in mobile-land, where user expectations
are different.

Therefore, we should only show the "Successful Offline Update"
notification for mobile, where people expect it, and not on the desktop,
where people do not.
FIXED-IN: 5.23

M  +16   -11   libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp

https://invent.kde.org/plasma/discover/commit/3f6cfb02f751aa59d9e4bff06964103c37c28a08

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 437681] "Successfully updated n packages" notification following offline update is unnecessary

2021-06-14 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=437681

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/discover/-/merge_requests/137

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 437681] "Successfully updated n packages" notification following offline update is unnecessary

2021-05-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437681

--- Comment #2 from Nate Graham  ---
I saw this on the desktop. IMO it would be weird on the phone too, but I'll
defer to others there.

What wouldn't be weird is showing a window that actually highlights the changes
so you can see all the cool new stuff you just got. That would be a whole
'nother kettle of fish, though. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 437681] "Successfully updated n packages" notification following offline update is unnecessary

2021-05-25 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=437681

Aleix Pol  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 437681] "Successfully updated n packages" notification following offline update is unnecessary

2021-05-25 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=437681

--- Comment #1 from Aleix Pol  ---
I think it was bhushan who suggested adding it since the alternative is
seemingly no changes. I personally don't mind either way.

If it's about the phone, we can have a different setting for the notification
there.

-- 
You are receiving this mail because:
You are watching all bug changes.