[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added Version Fixed In|20.12.0 |22.04 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110
Nate Graham changed:
What|Removed |Added
Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult
|imedia/elisa/commit/904dc9f |imedia/elisa/commit/fd858ca
|bdb007b3690dd58d77307679811 |f0e780f74275c56f4083517ef9e
|256f3c |8056b4
Resolution|--- |FIXED
Status|ASSIGNED|RESOLVED
--- Comment #37 from Nate Graham ---
Git commit fd858caf0e780f74275c56f4083517ef9e8056b4 by Nate Graham, on behalf
of Olivier Trichet.
Committed on 08/03/2022 at 23:08.
Pushed by ngraham into branch 'master'.
Fix shortcut not working under non English locale
This change wraps calls to QAction::shortcut() done in QML files
to use the portable representation of QKeySequence.
The QKeySequence to QVariant operator return a string
representation using the native format not the portable format.
E.g., the sequence "Space", will be "Espace" under French locale.
The 'shortcut' attribute of QtQuick Action is stored as QVariant.
In qml file, when the QAction::shortcut() value (a QKeySequence)
is affected to a QtQuick Action shortcut, the previous operator is
used and the shortcut value may be bogus depending on translation.
// A QAction* with the Qt::Key_Space shortcut
property var playPauseAction: ElisaApplication.action("Play-Pause")
Action {
// - playPauseAction.shortcut returns QKeySequence(Qt::Key_Space).
// - QKeySequence(Qt::Key_Space) is transform into a QVariant that
//contains native text "Espace".
// - this QVariant is affected to shortcut: broken.
shortcut: playPauseAction.shortcut
onTriggered: ElisaApplication.audioControl.playPause()
}
Related: bug 424890
M +6-0src/elisaapplication.cpp
M +1-0src/elisaapplication.h
M +6-6src/qml/ApplicationMenu.qml
M +8-8src/qml/ElisaMainWindow.qml
M +1-1src/qml/MediaPlayerControl.qml
M +1-1src/qml/NativeMenuItemFromAction.qml
M +7-7src/qml/NativeTrayMenu.qml
https://invent.kde.org/multimedia/elisa/commit/fd858caf0e780f74275c56f4083517ef9e8056b4
--
You are receiving this mail because:
You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #36 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/336 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 postix changed: What|Removed |Added Status|CONFIRMED |REPORTED Ever confirmed|1 |0 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 postix changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 postix changed: What|Removed |Added Version|0.4.2 |21.12.2 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO |--- --- Comment #35 from Nate Graham --- OK, so that's not relevant, then. -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #34 from KDamian --- (In reply to Nate Graham from comment #32) > Can you please attach your ~/.config/elisarc file? on my system: [ElisaFileIndexer] RootPath[$e]=$HOME/Zenék [Views] InitialView=Radios Operating System: KDE neon 5.22 KDE Plasma Version: 5.22.5 KDE Frameworks Version: 5.85.0 Qt Version: 5.15.3 Kernel Version: 5.11.0-27-generic (64-bit) Elisa 21.08.1 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #33 from postix --- (In reply to Nate Graham from comment #32) > Can you please attach your ~/.config/elisarc file? In my case Operating System: openSUSE Tumbleweed 20210904 KDE Plasma Version: 5.22.5 KDE Frameworks Version: 5.85.0 Qt Version: 5.15.2 Elisa 21.08.1 > cat ~/.config/elisarc [ElisaFileIndexer] RootPath[$e]=$HOME -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added Status|REOPENED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #32 from Nate Graham --- Can you please attach your ~/.config/elisarc file? -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #31 from KDamian --- I forgot, to my last comment: I use Hungarian language and locale. -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 KDamian changed: What|Removed |Added CC||[email protected] --- Comment #30 from KDamian --- I can reproduce in Elisa 21.08.1 and system as below: Operating System: KDE neon 5.22 KDE Plasma Version: 5.22.5 KDE Frameworks Version: 5.85.0 Qt Version: 5.15.3 Kernel Version: 5.11.0-27-generic (64-bit) Graphics Platform: X11 Processors: 4 × Intel® Core™ i5-2520M CPU @ 2.50GHz Memory: 7.7 GiB of RAM Graphics Processor: Mesa DRI Intel® HD Graphics 3000 Problem does not appear when I start with LANG=en_US.UTF-8 LANGUAGE=en_US. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 [email protected] changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #29 from Matej Mrenica --- I used to have this issue, but not anymore. I also changed the translation so it's not translated anymore, so I am not sure what fixed it. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 postix changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #28 from postix --- I completely purged all traces of Elisa 20.08.x and reinstalled Elisa 20.12.1 and I still can reproduce the bug with a German locale. :-( -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Christoph Feck changed: What|Removed |Added Version Fixed In|20.12.1 |20.12.0 -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #27 from Nate Graham --- My pleasure! -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #26 from postix --- \o/ Thanks! -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Version Fixed In||20.12.1 Latest Commit||https://invent.kde.org/mult ||imedia/elisa/commit/904dc9f ||bdb007b3690dd58d77307679811 ||256f3c --- Comment #25 from Nate Graham --- Git commit 904dc9fbdb007b3690dd58d77307679811256f3c by Nate Graham. Committed on 03/12/2020 at 20:47. Pushed by ngraham into branch 'release/20.12'. Don't look for translated version of "Play-Pause" shortcut Shortcuts should always use bare string literals instead of translations because this causes issues in cases where the string has not been translated in some languages, or when it gets customized before or after the translation takes place. This commit fixes the problem by always searching for the string literal. FIXED-IN: 20.12.1 M +1-1src/elisaapplication.cpp https://invent.kde.org/multimedia/elisa/commit/904dc9fbdb007b3690dd58d77307679811256f3c -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added Status|REOPENED|ASSIGNED Assignee|[email protected] |[email protected] --- Comment #24 from Nate Graham --- Found the issue. Fixing shortly. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #23 from postix --- (In reply to Matej Mrenica from comment #22) > I am assuming the name for Spacebar is translated in German translation, I > remember changing the translation for Slovak so it's not translated and now > It works correctly. Yes it is translated to "Leertaste". -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #22 from Matej Mrenica --- I am assuming the name for Spacebar is translated in German translation, I remember changing the translation for Slovak so it's not translated and now It works correctly. But that might be just a coincidence, since I also changed computers. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #21 from postix --- > which involves a user with Elisa in German. This is me. I just noticed that if I click in the "files" or "radio" section on the play button so that song/radio stream starts playing, I can use the spacebar! However, the song/radio stream only pauses for a fraction of a second and then continues playing. Once I select another UI element, the spacebar does nothing anymore. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added Status|RESOLVED|REOPENED Ever confirmed|0 |1 Resolution|WORKSFORME |--- --- Comment #20 from Nate Graham --- Apparently this is still sometimes happening; see duplicate bug 429932 which involves a user with Elisa in German. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added CC||[email protected] --- Comment #19 from Nate Graham --- *** Bug 429932 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Matthieu Gallien changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |WORKSFORME --- Comment #18 from Matthieu Gallien --- Thanks for your answer. Feel free to reopen the bug if you see this bug again. Best regards -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #17 from Matej Mrenica --- I am now on a new computer and I don't have this issue anymore. There must be something messed up with the old setup. Even though the issue was not resolved I won't object if you decide to close this issue. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #16 from Matthieu Gallien --- (In reply to Matej Mrenica from comment #14) > Yes it is. I am sorry, but I have tested with 19.12.3 version and cannot reproduce if I start Elisa this way: LANG=sk_SK.UTF-8 LANGUAGE=sk_SK ./elisa The interface is correctly translated but spacebar works as long as a text entry is not focused. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Ever confirmed|1 |0 Status|NEEDSINFO |REPORTED --- Comment #15 from Nate Graham --- Darn. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 --- Comment #14 from mthw0 --- Yes it is. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|CONFIRMED |NEEDSINFO --- Comment #13 from Nate Graham --- Matej, is this still reproducible for you with Elisa 19.12.0 when the search field isn't focused? -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Patrick Silva changed: What|Removed |Added CC||[email protected] --- Comment #12 from Patrick Silva --- I have american english and portuguese languages in regional settings. Space bar works to play/pause music after I click outside of the search field even if plasma/elisa language is portuguese. elisa 19.12.2 Operating System: Arch Linux KDE Plasma Version: 5.17.90 KDE Frameworks Version: 5.67.0 Qt Version: 5.14.1 -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 410110] Spacebar to play/pause only works when using Elisa in English
https://bugs.kde.org/show_bug.cgi?id=410110 Nate Graham changed: What|Removed |Added Keywords||usability Summary|Spacebar to play/pause |Spacebar to play/pause only |doesn't work anymore|works when using Elisa in ||English Priority|NOR |HI Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
