[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Status|CLOSED |RESOLVED Latest Commit|https://commits.kde.org/kex |https://commits.kde.org/kdb |i/90c3ed3251ddcebee4ac4d2dc |/d1b31bd8a6fc6632f8eeab70b5 |e1c24c857967bd3 |e9a0f1c8630c8f Version Fixed In|3.2.0 |3.2 --- Comment #6 from Jarosław Staniek --- Git commit d1b31bd8a6fc6632f8eeab70b5e9a0f1c8630c8f by Jaroslaw Staniek. Committed on 06/01/2019 at 21:16. Pushed by staniek into branch '3.2'. Fix handling ORDER BY part of queries Summary: - new APIs - maintain relations between connections, queries and column infos - fix cloning queries with ORDER BY - update and add autotests FIXED-IN:3.2 Related: bug 393705 Test Plan: Required: KEXI & KDb 3.2 (current master) Test 1: Open report and query from https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views. Expected: works, no crashes Test 2: Try these on a standard Persons and Cars test: select id from cars order by owner; select id from cars order by owner, model, id; select id, model from cars order by 2, 1; Expected: works, no crash Reviewers: piggz Reviewed By: piggz Subscribers: Kexi-Devel-list Tags: #kdb Differential Revision: https://phabricator.kde.org/D12873 M +3-0autotests/CMakeLists.txt A +212 -0autotests/OrderByColumnTest.cpp [License: LGPL (v2+)] A +46 -0autotests/OrderByColumnTest.h [License: LGPL (v2+)] M +2-2src/KDbNativeStatementBuilder.cpp M +87 -28 src/KDbOrderByColumn.cpp M +40 -13 src/KDbOrderByColumn.h M +17 -28 src/KDbQueryColumnInfo.cpp M +25 -1src/KDbQueryColumnInfo.h M +18 -4src/KDbQuerySchema.cpp M +29 -1src/KDbQuerySchema_p.h https://commits.kde.org/kdb/d1b31bd8a6fc6632f8eeab70b5e9a0f1c8630c8f -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Version Fixed In|3.1.1 |3.2.0 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Target Milestone|3.1.1 |--- Target Milestone|--- |3.2 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Target Milestone|3.2 |3.1.1 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #5 from Jarosław Staniek --- Feel free to test the git version. -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753
Jarosław Staniek changed:
What|Removed |Added
Version Fixed In|3.2 |3.1.1
Latest Commit|https://commits.kde.org/kdb |https://commits.kde.org/kex
|/3414fbddffa433b23d43376b44 |i/90c3ed3251ddcebee4ac4d2dc
|fef5421b734250 |e1c24c857967bd3
--- Comment #4 from Jarosław Staniek ---
Git commit 90c3ed3251ddcebee4ac4d2dce1c24c857967bd3 by Jaroslaw Staniek.
Committed on 16/05/2018 at 08:23.
Pushed by staniek into branch '3.1'.
Fix crash in data fetching and aggregation scripts in reports
Summary:
FIXED-IN:3.1.1
NOTE: Reports can still crash in Design view until 393705 (ORDER BY) is fixed
(3.2).
Test Plan:
Test 1. Open report from https://bugs.kde.org/show_bug.cgi?id=392753#c0
Test 2. Create report field with data sources like these and try it:
```
=field.max("")
=field.min("")
=field.sum("")
=field.avg("")
=field.count("")
```
Reviewers: piggz
Reviewed By: piggz
Subscribers: Kexi-Devel-list
Tags: #kexi
Differential Revision: https://phabricator.kde.org/D12868
M +53 -3src/plugins/reports/KexiDBReportDataSource.cpp
M +16 -1src/plugins/reports/KexiDBReportDataSource.h
M +5-5src/plugins/reports/kexireportview.cpp
M +3-4src/plugins/reports/kexireportview.h
M +7-56 src/plugins/reports/krscriptfunctions.cpp
M +8-6src/plugins/reports/krscriptfunctions.h
https://commits.kde.org/kexi/90c3ed3251ddcebee4ac4d2dce1c24c857967bd3
--
You are receiving this mail because:
You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Version Fixed In||3.2 Latest Commit||https://commits.kde.org/kdb ||/3414fbddffa433b23d43376b44 ||fef5421b734250 --- Comment #3 from Jarosław Staniek --- Git commit 3414fbddffa433b23d43376b44fef5421b734250 by Jaroslaw Staniek. Committed on 16/05/2018 at 08:15. Pushed by staniek into branch 'master'. Fix handling ORDER BY part of queries Summary: - new APIs - maintain relations between connections, queries and column infos - fix cloning queries with ORDER BY - update and add autotests FIXED-IN:3.2 Related: bug 393705 Test Plan: Required: KEXI & KDb 3.2 (current master) Test 1: Open report and query from https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views. Expected: works, no crashes Test 2: Try these on a standard Persons and Cars test: select id from cars order by owner; select id from cars order by owner, model, id; select id, model from cars order by 2, 1; Expected: works, no crash Reviewers: piggz Reviewed By: piggz Subscribers: Kexi-Devel-list Tags: #kdb Differential Revision: https://phabricator.kde.org/D12873 M +1-1CMakeLists.txt M +3-0autotests/CMakeLists.txt A +212 -0autotests/OrderByColumnTest.cpp [License: LGPL (v2+)] A +46 -0autotests/OrderByColumnTest.h [License: LGPL (v2+)] M +2-2src/KDbNativeStatementBuilder.cpp M +87 -28 src/KDbOrderByColumn.cpp M +40 -13 src/KDbOrderByColumn.h M +17 -28 src/KDbQueryColumnInfo.cpp M +25 -1src/KDbQueryColumnInfo.h M +18 -4src/KDbQuerySchema.cpp M +29 -1src/KDbQuerySchema_p.h https://commits.kde.org/kdb/3414fbddffa433b23d43376b44fef5421b734250 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Status|CONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Target Milestone|3.1.1 |3.2 Severity|normal |crash -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Assignee|kexi-b...@kde.org |stan...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 --- Comment #2 from Adam Pigg --- #0 0x76dcecf7 in std::__atomic_base::load (__m=std::memory_order_relaxed, this=0x21) at /usr/include/c++/7/bits/atomic_base.h:396 #1 QAtomicOps::load (_q_value=...) at /usr/include/qt5/QtCore/qatomic_cxx11.h:227 #2 0x76dcec2c in QBasicAtomicInteger::load (this=0x21) at /usr/include/qt5/QtCore/qbasicatomic.h:102 #3 0x76dce92c in QtPrivate::RefCount::ref (this=0x21) at /usr/include/qt5/QtCore/qrefcount.h:55 #4 0x76dcea67 in QString::QString (this=0x7fffb148, other=...) at /usr/include/qt5/QtCore/qstring.h:942 #5 0x76e36c82 in KDbQueryColumnInfo::alias (this=0x92f190) at /home/piggz/src/kdb/src/KDbQueryColumnInfo.cpp:81 #6 0x76e2375c in KDbOrderByColumn::toSqlString (this=0xedd4e0, includeTableName=true, conn=0x989420, escapingType=KDb::DriverEscaping) at /home/piggz/src/kdb/src/KDbOrderByColumn.cpp:186 #7 0x76e246e7 in KDbOrderByColumnList::toSqlString (this=0xedae70, includeTableNames=true, conn=0x989420, escapingType=KDb::DriverEscaping) at /home/piggz/src/kdb/src/KDbOrderByColumn.cpp:400 #8 0x76e9f6ba in selectStatementInternal (target=0x7fffbd80, connection=0x989420, dialect=KDb::DriverEscaping, querySchema=0xedab90, options=..., parameters=...) at /home/piggz/src/kdb/src/KDbNativeStatementBuilder.cpp:392 #9 0x76e9fb65 in KDbNativeStatementBuilder::generateSelectStatement (this=0x7fffbd98, target=0x7fffbd80, querySchema=0xedab90, parameters=...) at /home/piggz/src/kdb/src/KDbNativeStatementBuilder.cpp:434 #10 0x7fffcda7d150 in KRScriptFunctions::KRScriptFunctions (this=0x9b5b80, datasource=0xeda900, conn=0x989420) at /home/piggz/src/kexi/src/plugins/reports/krscriptfunctions.cpp:39 #11 0x7fffcda76e02 in KexiReportView::afterSwitchFrom (this=0xe94ee0, mode=Kexi::AllViewModes) at /home/piggz/src/kexi/src/plugins/reports/kexireportview.cpp:377 #12 0x778086f6 in KexiWindow::switchToViewMode (this=0xe8cc30, newViewMode=Kexi::DataViewMode, staticObjectArgs=0x0, proposeOpeningInTextViewModeBecauseOfProblems=0x7fffc0cf) at /home/piggz/src/kexi/src/core/KexiWindow.cpp:549 #13 0x77819d80 in KexiPart::Part::openInstance (this=0x9e68e0, parent=0xe7d260, item=0xc77450, viewMode=Kexi::DataViewMode, staticObjectArgs=0x0) at /home/piggz/src/kexi/src/core/kexipart.cpp:288 #14 0x777fc822 in KexiProject::openObject (this=0x90de90, parent=0xe7d260, item=0xc77450, viewMode=Kexi::DataViewMode, staticObjectArgs=0x0) at /home/piggz/src/kexi/src/core/kexiproject.cpp:967 #15 0x77ac9b3f in KexiMainWindow::openObject (this=0x757990, item=0xc77450, viewMode=Kexi::DataViewMode, openingCancelled=0x7fffc54f, staticObjectArgs=0x0, errorMessage=0x0) at /home/piggz/src/kexi/src/main/KexiMainWindow.cpp:3274 #16 0x77aca243 in KexiMainWindow::openObjectFromNavigator (this=0x757990, item=0xc77450, viewMode=Kexi::DataViewMode, openingCancelled=0x7fffc54f) at /home/piggz/src/kexi/src/main/KexiMainWindow.cpp:3378 #17 0x77ac9fda in KexiMainWindow::openObjectFromNavigator (this=0x757990, item=0xc77450, viewMode=Kexi::DataViewMode) at /home/piggz/src/kexi/src/main/KexiMainWindow.cpp:3337 #18 0x77b2938b in KexiMainWindow::qt_static_metacall (_o=0x757990, _c=QMetaObject::InvokeMetaMethod, _id=51, _a=0x7fffc850) at /home/piggz/src/kexi-build/src/main/keximain_autogen/EWIEGA46WW/moc_KexiMainWindow.cpp:678 #19 0x7291826a in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib64/libQt5Core.so.5 #20 0x71731582 in KexiProjectNavigator::openOrActivateItem (this=0x9a7460, _t1=0xc77450, _t2=Kexi::DataViewMode) at /home/piggz/src/kexi-build/src/widget/kexiextendedwidgets_autogen/RU47RH5TZY/moc_KexiProjectNavigator.cpp:556 #21 0x716ed409 in KexiProjectNavigator::slotExecuteItem (this=0x9a7460, vitem=...) at /home/piggz/src/kexi/src/widget/navigator/KexiProjectNavigator.cpp:331 #22 0x71730e4f in KexiProjectNavigator::qt_static_metacall (_o=0x9a7460, _c=QMetaObject::InvokeMetaMethod, _id=17, _a=0x7fffcaa0) at /home/piggz/src/kexi-build/src/widget/kexiextendedwidgets_autogen/RU47RH5TZY/moc_KexiProjectNavigator.cpp:415 #23 0x7291826a in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib64/libQt5Core.so.5 #24 0x741f2cd5 in QAbstractItemView::doubleClicked(QModelIndex const&) () from /usr/lib64/libQt5Widgets.so.5 #25 0x7425f113 in QTreeView::mouseDoubleClickEvent(QMouseEvent*) () from /usr/lib64/libQt5Widgets.so.5 #26 0x73ffecb9 in QWidget::event(QEvent*) () from /usr/lib64/libQt5Widgets.so.5 #27 0x7409c1ee in QFrame::event(QEvent*) () from /usr/lib64/libQt5Widgets.so.5 #28 0x741fe04c in QAbstractItemView::viewportEvent(QEvent*) () from /usr/lib64/libQt5Widgets.so.5 #29 0x7426106c in QTreeView::viewportEvent(QEvent*) () from /usr/lib64/libQt5Widgets.so.5 #30 0x728e9e54 in QCoreA
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Target Milestone|--- |3.1.1 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392753] Crash when opening a report
https://bugs.kde.org/show_bug.cgi?id=392753 Jarosław Staniek changed: What|Removed |Added CC||stan...@kde.org --- Comment #1 from Jarosław Staniek --- Thank you very much Ray. -- You are receiving this mail because: You are watching all bug changes.
