[KScreen] [Bug 412092] Screen orientation icons have weird tooltip positioning

2019-10-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=412092

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.17.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[KScreen] [Bug 412092] Screen orientation icons have weird tooltip positioning

2019-10-16 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=412092

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/ksc
   ||reen/ae555055b2ea8e41ebd805
   ||6c2b69451b893915da

--- Comment #7 from David Edmundson  ---
Git commit ae555055b2ea8e41ebd8056c2b69451b893915da by David Edmundson.
Committed on 16/10/2019 at 20:37.
Pushed by davidedmundson into branch 'Plasma/5.17'.

[kcm] Don't transform button to show rotated icon

Summary:
Rotating a button leads to tooltips being broken, it will lead to
shadows being broken on a theme that uses shadows and is generally not
great.

This patch sets the contentItem explicitly and rotates that

Reviewers: #plasma, ngraham, romangg

Reviewed By: #plasma, ngraham, romangg

Subscribers: romangg, mart, ngraham, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24488

M  +8-10   kcm/package/contents/ui/RotationButton.qml

https://commits.kde.org/kscreen/ae555055b2ea8e41ebd8056c2b69451b893915da

-- 
You are receiving this mail because:
You are watching all bug changes.

[KScreen] [Bug 412092] Screen orientation icons have weird tooltip positioning

2019-10-08 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=412092

--- Comment #6 from David Edmundson  ---
It's due to us rotating the buttons. 

Which is already technically wrong, we're making wild assumptions about the
style. On oxygen it would rotate the shadow.

We need to have 4 icons instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

[KScreen] [Bug 412092] Screen orientation icons have weird tooltip positioning

2019-10-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=412092

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
Summary|Screen orientation icons|Screen orientation icons
   |are confusing in screen kcm |have weird tooltip
   ||positioning

-- 
You are receiving this mail because:
You are watching all bug changes.