https://bugs.kde.org/show_bug.cgi?id=370303
Peter Wu <pe...@lekensteyn.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |http://commits.kde.org/spec
| |tacle/7a5603fda8f1e591d31db
| |a1ad178c44ad6847cc2
Version Fixed In| |16.12
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Peter Wu <pe...@lekensteyn.nl> ---
Git commit 7a5603fda8f1e591d31dba1ad178c44ad6847cc2 by Peter Wu.
Committed on 14/10/2016 at 09:08.
Pushed by peterwu into branch 'master'.
Refactor pixmap grabbing, add robustness
Do not go in an infinite loop when the root window cannot be captured
(bug 370303). Avoid crashing xcb_image_destroy by checking for NULL.
Split the getWindowPixmap into three logical methods depending on the
consumer: obtaining a pixmap from KWin, obtaining a pixmap from a single
window and obtaining a pixmap from a full screen. This enables some
optimizations, like obtaining a smaller area of the screen without
cropping. Additionally, it will make fixing HiDPI support easier.
Added robustness: if KWin somehow fails, now it will fallback to a
fullscreen capture instead of an null pixmap.
REVIEW: 129176
FIXED-IN: 16.12
M +78 -30 src/PlatformBackends/X11ImageGrabber.cpp
M +7 -2 src/PlatformBackends/X11ImageGrabber.h
http://commits.kde.org/spectacle/7a5603fda8f1e591d31dba1ad178c44ad6847cc2
--
You are receiving this mail because:
You are watching all bug changes.
