[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2023-12-08 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=411290

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
 CC||noaha...@gmail.com

--- Comment #12 from Noah Davis  ---
This seems to be fixed, especially now that Spectacle use KWin to get
screenshots on Wayland and X11.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-09-13 Thread Antonio
https://bugs.kde.org/show_bug.cgi?id=411290

--- Comment #11 from Antonio  ---
(In reply to Leon De Andrade from comment #10)
> Thank you @Antonio for investigating it further. 
> 
> I'm pretty sure this is not how it supposed to be. I would take this issue
> very soon (unless you want to give it a shot?). 
> 
> Personally, which indirectly would fix this issue automatically, I would
> like to see a combined new option "Select Window" ... I believe a lot of the
> backend exists already, at least when kwin is available. 
> I might will open a task on phab to discuss how it should be, before I
> submit any change.

Go on and do it. Since I'm currently trying to implement copy to clipboard for
DBUS. Which seems to be more complicated than I expected. And I rather won't
work on two things, or else I mix up or miss something (like I did recently).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-09-13 Thread Leon De Andrade
https://bugs.kde.org/show_bug.cgi?id=411290

Leon De Andrade  changed:

   What|Removed |Added

   Assignee|m...@baloneygeek.com  |leondeandr...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-09-13 Thread Leon De Andrade
https://bugs.kde.org/show_bug.cgi?id=411290

--- Comment #10 from Leon De Andrade  ---
Thank you @Antonio for investigating it further. 

I'm pretty sure this is not how it supposed to be. I would take this issue very
soon (unless you want to give it a shot?). 

Personally, which indirectly would fix this issue automatically, I would like
to see a combined new option "Select Window" ... I believe a lot of the backend
exists already, at least when kwin is available. 
I might will open a task on phab to discuss how it should be, before I submit
any change.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-09-11 Thread Antonio
https://bugs.kde.org/show_bug.cgi?id=411290

--- Comment #8 from Antonio  ---
Created attachment 122618
  --> https://bugs.kde.org/attachment.cgi?id=122618&action=edit
WindowUnderCursor_transparency_CaptureTheCurrentPopupDISABLED

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-09-11 Thread Antonio
https://bugs.kde.org/show_bug.cgi?id=411290

--- Comment #9 from Antonio  ---
Created attachment 122619
  --> https://bugs.kde.org/attachment.cgi?id=122619&action=edit
WindowUnderCursor_transparency_CaptureTheCurrentPopupENABLED

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-09-11 Thread Antonio
https://bugs.kde.org/show_bug.cgi?id=411290

--- Comment #7 from Antonio  ---
Created attachment 122617
  --> https://bugs.kde.org/attachment.cgi?id=122617&action=edit
ActiveWindow_transparency

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-09-11 Thread Antonio
https://bugs.kde.org/show_bug.cgi?id=411290

Antonio  changed:

   What|Removed |Added

 CC||antonio.prc...@gmail.com

--- Comment #6 from Antonio  ---
I just tested this a bit..

To get the same picture with "Active Window" and "Window under cursor", you
have to check "Capture the current pop-up only" in "Window under cursor".
I'll attach 3 images. All were made with Konsole having transparency enabled.

ActiveWindow_transparency -> Screenshot made with "Active Window"
WindowUnderCursor_transparency_CaptureTheCurrentPopupENABLED -> Screenshot made
with "Window under Cursor" & "Capture the current pop-up only" ENABLED

^ Same shadows, no transparency.

WindowUnderCursor_transparency_CaptureTheCurrentPopupDISABLED -> Screenshot
made with "Window under Cursor" & "Capture the current pop-up only" DISABLED

^ No window shadow, no decorations, and transparency in Konsole active.

The difference is here:
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSWidget.cpp#n217

If we choose "Window under Cursor" & uncheck "Capture the current pop-up only",
than it switches over to "CaptureMode::TransientWithParent" mode. And that mode
forces a BLUR radius with shadow effect:

https://cgit.kde.org/spectacle.git/tree/src/Platforms/PlatformXcb.cpp#n653

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-08-26 Thread Leon De Andrade
https://bugs.kde.org/show_bug.cgi?id=411290

--- Comment #5 from Leon De Andrade  ---
No worries! I'll have a look when I'm back if the bug is tackled by someone or
not :) 

If someone is interested in fixing this bug (or giving it a shot), please
assign yourself to it, so I (and others) know that someone is working on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-08-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=411290

--- Comment #4 from Nate Graham  ---
Sorry, I was unclear. I'm definitely open to this being fixed (by someone, not
necessarily me). :)

I think the behavior for "Active window" should be used for "Window Under
Cursor" mode as well, and then we should have a user-configurable option to
omit window shadows from the screenshot when using one of those two modes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-08-26 Thread Leon De Andrade
https://bugs.kde.org/show_bug.cgi?id=411290

--- Comment #3 from Leon De Andrade  ---
What behaviour would you prefer? Or should this be determined by a checkbox. 
I think windows as they are (e.g. transparent) is what most people want/expect,
so I would make this the default behaviour and perhaps add an option in the
settings to change it. 

I suppose we have to change that beviour in kwin/Screenshot as it's implemented
there mostly? 

> Definitely open to fixing this
Lack of knowledge of the English language here, what do you mean? Do you like
to fix it or would you like to see someone fixing it? 

In case, you mean the second one, I can take a look at it. But perhaps next
week as I will be on holidays this week :) 
But if someone else want to fix it instead including you, feel free to claim
the bug as yours and assign yourself to it. It's all yours :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-08-26 Thread Jack
https://bugs.kde.org/show_bug.cgi?id=411290

Jack  changed:

   What|Removed |Added

 CC||ostroffjh@users.sourceforge
   ||.net

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-08-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=411290

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=372408

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-08-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=411290

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #2 from Nate Graham  ---
I was wondering when someone was going to file a bug for this. :)

What seems to be happening is that "Active Window" captures the window's own
shadow, while "Window under Cursor" doe snot, and adds a shadow later.

Definitely open to fixing this--and also allowing shadow inclusion to be
disabled entirely (see Bug 372408).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 411290] Capture Mode "Window Under Cursor" results in different screenshot than "Active Window"

2019-08-25 Thread Leon De Andrade
https://bugs.kde.org/show_bug.cgi?id=411290

--- Comment #1 from Leon De Andrade  ---
Created attachment 122354
  --> https://bugs.kde.org/attachment.cgi?id=122354&action=edit
Screenshot in Window under Cursor mode

-- 
You are receiving this mail because:
You are watching all bug changes.