[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 Dr. Chapatin changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||bugsefor...@gmx.com Resolution|--- |FIXED --- Comment #12 from Dr. Chapatin --- ark 17.12.2 also works as expected on Arch Linux. -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 Edmund Kasprzak changed: What|Removed |Added CC||edk...@gmail.com --- Comment #11 from Edmund Kasprzak --- I can confirm it's working correctly now. Used attached zips from ticket and also few created by myself. Neon Git Stable, Plasma 5.12.0, KF 5.43.0, Qt 5.9.3, Ark 17.12.2 -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #10 from Elvis Angelaccio --- Git commit 716e15c3c2ef122776bfa043f42f1af95fe85dbe by Elvis Angelaccio. Committed on 05/03/2017 at 20:55. Pushed by elvisangelaccio into branch 'master'. Don't quick-extract to subfolders with single-file archives This is how it used to work and what makes more sense. Differential Revision: D4942 M +1-1part/part.cpp https://commits.kde.org/ark/716e15c3c2ef122776bfa043f42f1af95fe85dbe -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #9 from Elvis Angelaccio --- Git commit a91c09d0d202fa5d8788ef3bdb85d6e7f75c061f by Elvis Angelaccio. Committed on 05/03/2017 at 18:13. Pushed by elvisangelaccio into branch 'master'. Don't check 'Extraction into subfolder' with single-file archives The ExtractionDialog only needs to know if it should enable the 'Extraction into subfolder' groupbox, not why. We rename `setIsSingleFolder()` to `setExtractToSubfolder()` and we call it with `archive->hasMultipleTopLevelEntries()` as argument. This fixes the regression with single-file archives. Differential Revision: D3873 M +1-1app/batchextract.cpp M +2-4kerfuffle/extractiondialog.cpp M +1-1kerfuffle/extractiondialog.h M +1-1part/part.cpp https://commits.kde.org/ark/a91c09d0d202fa5d8788ef3bdb85d6e7f75c061f -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #8 from Michal Ziabkowski --- Your test archive seems to be detected properly. My archive was created from the command line using zip v3.0: zip test2.zip test2/test However, a zip archive created with 7zip v16.02 also causes this bug: 7z a test2.zip test2/test The archives in question seem to be valid. A quick file comparison reveals the structure is somewhat different for some reason. -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #7 from Elvis Angelaccio --- (In reply to Michal Ziabkowski from comment #5) > Indeed, if there is a single folder with more than one file, the archive is > treated as a single folder archive. If however, the folder contains only one > file, it is not. I can reproduce this only with your test file. How did you create it? > > Another problem is that the configuration option doesn't mention "more than > one top-level folder", but "more than one top-level entry", which covers > both files and folders. At least that's one possible interpretation. So > either the string should be clarified or the behavior changed in line with > the description. > > The crucial question is why should single file archives be treated > differently than single folder ones? When extracting an archive with a > single file inside, I believe most people wouldn't expect a folder to be > created. I understand this was changed for semantic reasons, but the old > behavior made more sense in my opinion. Yes, you may argue that this is a regression and should be fixed indeed. -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #6 from Elvis Angelaccio --- Created attachment 103049 --> https://bugs.kde.org/attachment.cgi?id=103049&action=edit working singlefolder zip working singlefolder zip, 1 folder with 1 file, created with Ark. Can you test with this archive? -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #5 from Michal Ziabkowski --- Indeed, if there is a single folder with more than one file, the archive is treated as a single folder archive. If however, the folder contains only one file, it is not. Another problem is that the configuration option doesn't mention "more than one top-level folder", but "more than one top-level entry", which covers both files and folders. At least that's one possible interpretation. So either the string should be clarified or the behavior changed in line with the description. The crucial question is why should single file archives be treated differently than single folder ones? When extracting an archive with a single file inside, I believe most people wouldn't expect a folder to be created. I understand this was changed for semantic reasons, but the old behavior made more sense in my opinion. -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #4 from Michal Ziabkowski --- I've attached two test archives. However, the bug happens with all archives I've tried. -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #3 from Michal Ziabkowski --- Created attachment 103048 --> https://bugs.kde.org/attachment.cgi?id=103048&action=edit Archive with single folder -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #2 from Michal Ziabkowski --- Created attachment 103047 --> https://bugs.kde.org/attachment.cgi?id=103047&action=edit Archive with single file -- You are receiving this mail because: You are watching all bug changes.
[ark] [Bug 374253] Single file/folder archives are not detected properly
https://bugs.kde.org/show_bug.cgi?id=374253 --- Comment #1 from Elvis Angelaccio --- I cannot reproduce with single folder archives, "Extraction into subfolder" is disabled if the archive has a root folder that contains everything else. Can you attach a single-folder archive that causes this issue? IIRC what we changed is that archives with only one file are no longer treated as single folder archives (because, well, there is no folder). -- You are receiving this mail because: You are watching all bug changes.
