[digikam] [Bug 432207] After rejection, assign face to next best match
https://bugs.kde.org/show_bug.cgi?id=432207 [email protected] changed: What|Removed |Added Version Fixed In||8.7.0 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 432207] After rejection, assign face to next best match
https://bugs.kde.org/show_bug.cgi?id=432207 Michael Miller changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/digikam/-/commit/499d4 ||1cee5f7422e9951ed9c097d8985 ||68f7046d Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #6 from Michael Miller --- Git commit 499d41cee5f7422e9951ed9c097d898568f7046d by Michael Miller. Committed on 18/04/2025 at 10:55. Pushed by michmill into branch 'master'. Save rejected face data Save rejected face tags and exclude the tags from being used during face classification (matching). This MR does not include code to write the rejected face tags to the item metadata. That will be a different MR in the next several days. This MR does not include the ability to clear the reject face data. That will be a different MR in the next several days. Related: bug 502219, bug 444394, bug 415783, bug 502924 M +5-0core/libs/database/coredb/coredbconstants.cpp M +1-0core/libs/database/coredb/coredbconstants.h M +137 -13 core/libs/database/tags/facetagseditor.cpp M +15 -3core/libs/database/tags/facetagseditor.h M +135 -28 core/libs/database/tags/facetagsiface.cpp M +52 -6core/libs/database/tags/facetagsiface.h M +29 -28 core/libs/facesengine/recognition/faceclassifier.cpp M +17 -11 core/libs/facesengine/recognition/faceclassifier.h M +2-0core/libs/facesengine/recognition/faceclassifierbase.cpp M +2-0core/libs/facesengine/recognition/faceclassifierbase.h M +35 -36 core/libs/facesengine/recognition/identityprovider.cpp M +4-1core/libs/facesengine/widgets/facescansettings.cpp M +8-6core/libs/mlfoundation/mlclassifierfoundation.h M +4-3 core/libs/tags/autoassignment/classifiers/minmax/autotagsclassifierminmax.cpp M +10 -8 core/libs/tags/autoassignment/classifiers/minmax/autotagsclassifierminmax.h M +9-5 core/libs/tags/autoassignment/classifiers/multiclassyolo/autotagsclassifiermultiyolo.h M +5-3 core/libs/tags/autoassignment/classifiers/softmax/autotagsclassifiersoftmax.cpp M +10 -8 core/libs/tags/autoassignment/classifiers/softmax/autotagsclassifiersoftmax.h M +25 -0core/utilities/facemanagement/database/faceutils.cpp M +10 -1core/utilities/facemanagement/database/faceutils.h M +44 -20 core/utilities/facemanagement/pipelines/detectrecognize/facepipelinedetectrecognize.cpp M +73 -39 core/utilities/facemanagement/pipelines/edit/facepipelineedit.cpp M +7-0core/utilities/facemanagement/pipelines/edit/facepipelineedit.h M +15 -0core/utilities/facemanagement/pipelines/facepipelinebase.cpp M +1-0 core/utilities/facemanagement/pipelines/facepipelinepackagebase.h M +27 -29 core/utilities/facemanagement/pipelines/recognize/facepipelinerecognize.cpp M +1-0project/bundles/homebrew/02-build-extralibs.sh M +2-0project/bundles/homebrew/03-build-digikam.sh M +11 -8project/bundles/homebrew/config.sh https://invent.kde.org/graphics/digikam/-/commit/499d41cee5f7422e9951ed9c097d898568f7046d -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 432207] After rejection, assign face to next best match
https://bugs.kde.org/show_bug.cgi?id=432207 --- Comment #5 from Michael Miller --- (In reply to caulier.gilles from comment #4) > I'm not sure to understand. It's a bug or a wish ? > > Gilles Hi Gilles, I think this is a wish. Cheers, Mike -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 432207] After rejection, assign face to next best match
https://bugs.kde.org/show_bug.cgi?id=432207 MarcP changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 432207] After rejection, assign face to next best match
https://bugs.kde.org/show_bug.cgi?id=432207 [email protected] changed: What|Removed |Added CC||[email protected] --- Comment #4 from [email protected] --- I'm not sure to understand. It's a bug or a wish ? Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 432207] After rejection, assign face to next best match
https://bugs.kde.org/show_bug.cgi?id=432207 Chris changed: What|Removed |Added CC||[email protected] --- Comment #3 from Chris --- If possible to inject a "value" into the deep learning mechanism, a rejection could apply a large "negative" recogition value to a rejected face tag, so it would not become to top choice after a re-scan. How to keep track of rejections and cancel errornous rejections? - Similar to how face regions are related to face tags in the database, but with the meaning "rejected" instead of "matched". - A UI feature could allow you to view rejections and cancel them, in case of mistakes -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 432207] After rejection, assign face to next best match
https://bugs.kde.org/show_bug.cgi?id=432207 Thilo changed: What|Removed |Added CC||[email protected] --- Comment #2 from Thilo --- (In reply to Maik Qualmann from comment #1) > It does not work like that. We don't have a next match. You have to assign > more people first for the face engine to learn. This is not a fingerprint > comparison. > > Maik Hello, I think this is an interesting question. Labelling, that a face does not belong to a certain person is valuable information. I understand, that it is not possible to simply reject this classification result and to accept the next best match (which would work when there would be something like a "similarity" vector for a query face that gives a scalar value of similarity for every person in the database. However, wouldnt it be possible to use the end users rejection of a classification result as "negative labeling" information for a retraining, leading to an improved classification result? -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 432207] After rejection, assign face to next best match
https://bugs.kde.org/show_bug.cgi?id=432207 Maik Qualmann changed: What|Removed |Added CC||[email protected] --- Comment #1 from Maik Qualmann --- It does not work like that. We don't have a next match. You have to assign more people first for the face engine to learn. This is not a fingerprint comparison. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 432207] After rejection, assign face to next best match
https://bugs.kde.org/show_bug.cgi?id=432207 [email protected] changed: What|Removed |Added Platform|Other |Microsoft Windows CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
