[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Unknown]

https://bugs.kde.org/show_bug.cgi?id=189302

.  changed:

   What|Removed |Added

 CC|dev.rindeal+bugs.kde.org@gm |
   |ail.com |

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[David Hallas]

https://bugs.kde.org/show_bug.cgi?id=189302

David Hallas  changed:

   What|Removed |Added

   Version Fixed In||19.12.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[David Hallas]

https://bugs.kde.org/show_bug.cgi?id=189302

David Hallas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/dol
   ||phin/c3b914a7faed3a7c0195ae
   ||77b40204cbc8d31fe5
 Status|ASSIGNED|RESOLVED

--- Comment #18 from David Hallas  ---
Git commit c3b914a7faed3a7c0195ae77b40204cbc8d31fe5 by David Hallas.
Committed on 27/10/2019 at 05:52.
Pushed by hallas into branch 'master'.

Unmounting busy device doesn't tell who is blocking

Summary: Unmounting a busy device from the places panel doesn't tell which
applications have open files blocking the unmount.

Test Plan:
Mount a USB stick using Dolphin
Open a file from the USB stick
Unmount the USB stick using Dolphin
Observe the new error message.

Reviewers: #dolphin, elvisangelaccio, ngraham, broulik, meven

Reviewed By: #dolphin, elvisangelaccio, meven

Subscribers: meven, davidedmundson, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19989

M  +1-1CMakeLists.txt
M  +1-0src/CMakeLists.txt
M  +25   -1src/panels/places/placesitemmodel.cpp

https://commits.kde.org/dolphin/c3b914a7faed3a7c0195ae77b40204cbc8d31fe5

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Postix]

https://bugs.kde.org/show_bug.cgi?id=189302

Postix  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=189302

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=189302

--- Comment #17 from ncdeh...@gmail.com ---
(In reply to David Hallas from comment #16)
> (In reply to ncdehnel from comment #15)
> > Ok, I see, it doesn't work with NFS shares, only USB devices. Suppose it
> > would be possible to fix that?
> 
> It might ;D
> 
> How do you tell which files are keeping a mount blocked for a NFS mount?
> Wouldn't lsof provide the information we are looking for?

I have to run a lsof command to do it at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[David Hallas]

https://bugs.kde.org/show_bug.cgi?id=189302

--- Comment #16 from David Hallas  ---
(In reply to ncdehnel from comment #15)
> Ok, I see, it doesn't work with NFS shares, only USB devices. Suppose it
> would be possible to fix that?

It might ;D

How do you tell which files are keeping a mount blocked for a NFS mount?
Wouldn't lsof provide the information we are looking for?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=189302

--- Comment #15 from ncdeh...@gmail.com ---
Ok, I see, it doesn't work with NFS shares, only USB devices. Suppose it would
be possible to fix that?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=189302

--- Comment #14 from ncdeh...@gmail.com ---
(In reply to David Hallas from comment #13)
> (In reply to ncdehnel from comment #12)
> > (In reply to David Hallas from comment #11)
> > > I have a patch in review that implements this:
> > > 
> > > https://phabricator.kde.org/D19989
> > > 
> > > Please test, review and provide feedback :D
> > 
> > How do you get the device notifier to show what's using the volume?
> 
> We are simply using lsof :D
> 
> Currrently the patch is being split up and put into the appropriate places
> in the KDE stack, therefore this process is taken a little more time.

Are you saying device notifier runs lsof internally, or that it tells the user
to run lsof? My device notifier just spits out a "not authorized" error when I
try to eject something in use.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[David Hallas]

https://bugs.kde.org/show_bug.cgi?id=189302

--- Comment #13 from David Hallas  ---
(In reply to ncdehnel from comment #12)
> (In reply to David Hallas from comment #11)
> > I have a patch in review that implements this:
> > 
> > https://phabricator.kde.org/D19989
> > 
> > Please test, review and provide feedback :D
> 
> How do you get the device notifier to show what's using the volume?

We are simply using lsof :D

Currrently the patch is being split up and put into the appropriate places in
the KDE stack, therefore this process is taken a little more time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=189302

--- Comment #12 from ncdeh...@gmail.com ---
(In reply to David Hallas from comment #11)
> I have a patch in review that implements this:
> 
> https://phabricator.kde.org/D19989
> 
> Please test, review and provide feedback :D

How do you get the device notifier to show what's using the volume?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[David Hallas]

https://bugs.kde.org/show_bug.cgi?id=189302

David Hallas  changed:

   What|Removed |Added

   Assignee|dolphin-bugs-n...@kde.org   |da...@davidhallas.dk
 Status|CONFIRMED   |ASSIGNED
 CC||da...@davidhallas.dk

--- Comment #11 from David Hallas  ---
I have a patch in review that implements this:

https://phabricator.kde.org/D19989

Please test, review and provide feedback :D

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=189302

Nate Graham  changed:

   What|Removed |Added

 CC||ncdeh...@gmail.com

--- Comment #10 from Nate Graham  ---
*** Bug 405489 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=189302

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=189302

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=189302

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Diego via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=189302

--- Comment #8 from Diego  ---
Kai Uwe, do the changes you mention in your blog extend also to Dolphin? Or are
the just tied to Device Notifier? Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Diego via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=189302

Diego  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #7 from Diego  ---
It looks like this might be fixes in Plasma 5.6:
http://blog.broulik.de/2016/01/on-being-more-convenient/
http://blog.broulik.de/wp-content/uploads/2016/01/devicenotifierinlinefeedbackerror2.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 189302] Unmounting busy device in dolphin: missing information who is blocking

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=189302

--- Comment #9 from Kai Uwe Broulik  ---
This feature wasn't added by me, actually, and is only in the Device Notifier,
it is not part of Solid, the message in Dolphin that comes from Solid (KDE's
hardware abstraction layer) and wasn't changed. I'll see if it's possible to
move the code from Device Notifier to Solid, so all applications benefit from
this, and while at it also improve the wording; telling users to run lsof isn't
particularly user-friendly.

-- 
You are receiving this mail because:
You are watching all bug changes.