[dolphin] [Bug 312027] Natural sorting should correctly sort associated numbered and unnumbered files

2024-11-25 Thread Carl Schwan
https://bugs.kde.org/show_bug.cgi?id=312027

Carl Schwan  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/syst |https://invent.kde.org/syst
   |em/dolphin/-/commit/e4cc6e6 |em/dolphin/-/commit/06f46b9
   |9430049366434e3383b1d2ef283 |7a018133a9b9851c61c0e00622c
   |ed22cc  |6addb3

--- Comment #7 from Carl Schwan  ---
Git commit 06f46b97a018133a9b9851c61c0e00622c6addb3 by Carl Schwan.
Committed on 25/11/2024 at 12:09.
Pushed by carlschwan into branch 'release/24.12'.

natural sort: exclude extension when comparing filenames

Currently natural sort compares the entire filenames
(basename.extension) when sorting. This causes eg.
"a 2.txt" to appear before "a.txt" when sorted by ascending.
This is unintuitive since people prioritize basenames more
than file extensions.

Instead, change natural sort to compare by basename only and
fallback to comparing extensions if basenames were equal.
This change causes "a.txt" to appear before "a 2.txt" and
matches how other platforms such as GNOME and Windows behave.
Related: bug 416025, bug 470538, bug 421869


(cherry picked from commit e4cc6e69430049366434e3383b1d2ef283ed22cc)

23a12f69 natural sort: exclude extension when comparing filenames
9d2d518b natural sort: refactors based on review
46695e10 natural sort: add testcase to compare against alphabetical sort

Co-authored-by: Eren Karakas 

M  +18   -1src/kitemviews/kfileitemmodel.cpp
M  +8-2src/kitemviews/kfileitemmodel.h
M  +78   -0src/tests/kfileitemmodeltest.cpp

https://invent.kde.org/system/dolphin/-/commit/06f46b97a018133a9b9851c61c0e00622c6addb3

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312027] Natural sorting should correctly sort associated numbered and unnumbered files

2024-11-19 Thread Méven
https://bugs.kde.org/show_bug.cgi?id=312027

Méven  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/syst
   ||em/dolphin/-/commit/e4cc6e6
   ||9430049366434e3383b1d2ef283
   ||ed22cc
 Status|REPORTED|RESOLVED

--- Comment #6 from Méven  ---
Git commit e4cc6e69430049366434e3383b1d2ef283ed22cc by Méven Car, on behalf of
Eren Karakas.
Committed on 19/11/2024 at 09:08.
Pushed by meven into branch 'master'.

natural sort: exclude extension when comparing filenames

Currently natural sort compares the entire filenames
(basename.extension) when sorting. This causes eg.
"a 2.txt" to appear before "a.txt" when sorted by ascending.
This is unintuitive since people prioritize basenames more
than file extensions.

Instead, change natural sort to compare by basename only and
fallback to comparing extensions if basenames were equal.
This change causes "a.txt" to appear before "a 2.txt" and
matches how other platforms such as GNOME and Windows behave.
Related: bug 416025, bug 470538, bug 421869

M  +18   -1src/kitemviews/kfileitemmodel.cpp
M  +8-2src/kitemviews/kfileitemmodel.h
M  +78   -0src/tests/kfileitemmodeltest.cpp

https://invent.kde.org/system/dolphin/-/commit/e4cc6e69430049366434e3383b1d2ef283ed22cc

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312027] Natural sorting should correctly sort associated numbered and unnumbered files

2022-03-27 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=312027

[email protected] changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #5 from [email protected] ---
The solution frankly is less complex than everyone makes it out to be - all
that needs to be done is make the dot/period have the highest priority when
sorting. I don't believe anyone has particularly strong opinions on what the
order of punctuation would be, so a slight idiosyncracy such as

a.file.txt
a file.txt
a_file.txt

is an acceptable tradeoff IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312027] Natural sorting should correctly sort associated numbered and unnumbered files

2021-03-09 Thread Stefan Radermacher
https://bugs.kde.org/show_bug.cgi?id=312027

--- Comment #4 from Stefan Radermacher  ---
(In reply to Justin Zobel from comment #3)
> Thank you for the bug report.
> 
> As this report hasn't seen any changes in 5 years or more, we ask if you can
> please confirm that the issue still persists.
> 
> If this bug is no longer persisting or relevant please change the status to
> resolved.

The behavior is still the same as originally reported.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 312027] Natural sorting should correctly sort associated numbered and unnumbered files

2021-03-08 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=312027

--- Comment #3 from Justin Zobel  ---
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can
please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to
resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.