[dolphin] [Bug 344617] “Show Filter bar” and “Search” should be converted to toggle buttons
https://bugs.kde.org/show_bug.cgi?id=344617
Elvis Angelaccio changed:
What|Removed |Added
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit||https://commits.kde.org/dol
||phin/3a7586907ed834fb3c09d4
||7e047da305a25374a2
Version Fixed In||19.12.0
--- Comment #7 from Elvis Angelaccio ---
Git commit 3a7586907ed834fb3c09d47e047da305a25374a2 by Elvis Angelaccio, on
behalf of Ismael Asensio.
Committed on 01/09/2019 at 19:59.
Pushed by elvisangelaccio into branch 'master'.
[dolphin] Add an action to toggle the searchbar
Summary:
Make search action toggle the searchbar instead of just launching it.
The search action in dolphin did only bring up the search bar, but to close it
again you had to go to the closing button on the same searchbar.
This behavior in inconsistent with other dolphin actions which toggle panels or
tools.
BEFORE:
{F7256652}
AFTER:
{F7256862}
FIXED-IN: 19.12.0
Closes T8473
Depends on D23075
Test Plan:
- Enable the search mode: the searchbar appears and the toolbar button gets
checked
- Press the search button again, and it goes back to normal mode.
- The search button state is coherent with the searchbox
- Coherence is kept when changing to a split view or different tab
- Shorcut does not close the searchbar, but moves the focus to it.
Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio
Reviewed By: ngraham, #vdg
Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel
Tags: #dolphin
Maniphest Tasks: T8473
Differential Revision: https://phabricator.kde.org/D23232
M +26 -0src/dolphinmainwindow.cpp
M +3-0src/dolphinmainwindow.h
M +3-3src/dolphinui.rc
M +2-0src/dolphinviewcontainer.cpp
M +12 -5src/dolphinviewcontainer.h
https://commits.kde.org/dolphin/3a7586907ed834fb3c09d47e047da305a25374a2
--
You are receiving this mail because:
You are watching all bug changes.
[dolphin] [Bug 344617] “Show Filter bar” and “Search” should be converted to toggle buttons
https://bugs.kde.org/show_bug.cgi?id=344617 Elvis Angelaccio changed: What|Removed |Added CC||erist...@cryptolab.net --- Comment #6 from Elvis Angelaccio --- *** Bug 407682 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 344617] “Show Filter bar” and “Search” should be converted to toggle buttons
https://bugs.kde.org/show_bug.cgi?id=344617 Elvis Angelaccio changed: What|Removed |Added CC||ht990...@gmx.com --- Comment #5 from Elvis Angelaccio --- *** Bug 353227 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 344617] “Show Filter bar” and “Search” should be converted to toggle buttons
https://bugs.kde.org/show_bug.cgi?id=344617 Dr. Chapatin changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 344617] “Show Filter bar” and “Search” should be converted to toggle buttons
https://bugs.kde.org/show_bug.cgi?id=344617 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com --- Comment #4 from Nate Graham --- Another patch for this: https://phabricator.kde.org/D10246 User interest in this change is strong. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 344617] “Show Filter bar” and “Search” should be converted to toggle buttons
https://bugs.kde.org/show_bug.cgi?id=344617 --- Comment #3 from Don Nguyen --- The committed filter toggle patch has been reverted. https://git.reviewboard.kde.org/r/129662/ I discarded my find toggle patch submission because I think it'll be opposed for the same reason. https://git.reviewboard.kde.org/r/129972/ -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 344617] “Show Filter bar” and “Search” should be converted to toggle buttons
https://bugs.kde.org/show_bug.cgi?id=344617 Don Nguyen changed: What|Removed |Added CC||don78color...@gmail.com --- Comment #2 from Don Nguyen --- (In reply to Emmanuel Pescosta from comment #1) > Thanks for the feature request! > I agree with you that filter and find should be toggle buttons as well. > > There is already an old patch for the "find" button: > https://git.reviewboard.kde.org/r/107016/ > > Added two tasks: > https://todo.kde.org/?controller=task&action=show&task_id=966 > https://todo.kde.org/?controller=task&action=show&task_id=967 The filter toggle patch has been committed. I will work on making find a toggle. The patch above seems to not show any diffs anymore. Is todo.kde.org dead? I can't access it right now. -- You are receiving this mail because: You are watching all bug changes.
