[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #12 from Tsu Jan --- A very different method. Anyhow, it's great that Dolphin has it :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 Emmanuel Pescosta changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/dol ||phin/3749b5552729b434655ddc ||950b120bb14fe888c7 Resolution|--- |FIXED --- Comment #11 from Emmanuel Pescosta --- Git commit 3749b5552729b434655ddc950b120bb14fe888c7 by Emmanuel Pescosta, on behalf of Gregor Mi. Committed on 21/09/2017 at 13:41. Pushed by emmanuelp into branch 'master'. Select child folder when navigating to a parent folder Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view. REVIEW: 123253 Related: bug 335616 M +1-1CMakeLists.txt M +11 -0src/dolphinviewcontainer.cpp M +5-0src/dolphinviewcontainer.h https://commits.kde.org/dolphin/3749b5552729b434655ddc950b120bb14fe888c7 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #10 from Tsu Jan --- Thank you very much! Sorry that I wasn't able to do it! IMHO, this is one the 2 "important" problems of Dolphin -- none of which is very important -- the other one being the random 1-s delay at startup. If I find enough free time, I'll look into the second issue -- this time on phabricator. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #9 from Nate Graham --- Submitted the patch for you: https://phabricator.kde.org/D7914 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 Dr. Chapatin changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #8 from Tsu Jan --- > are you willing to let me take over the patch? Oh, that would be very kind of you! Yes, please! I haven't touched the patch for a long time; it may need to be updated. As far as I remember, at that time, some changes in Dolphin made the job very easy; just a few changes was enough for this functionality to be implemented. Thanks for your attention! -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #7 from Nate Graham --- I also don't participate in those kinds of lengthy discussions. I just grit my teeth and do it. ;) Again, it would be a shame to let this patch die. If you don't want to use KDE's Phabricator, are you willing to let me take over the patch? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #6 from Tsu Jan --- This isn't about advertising: I know for sure that GitHub is very practical, makes the contribution easy and doesn't waste anyone's time. In comparison, I started to try phabricator with Enlightenment but it wasn't promising. I also wanted to try it with KDE months ago; it was an *obstacle*. Add to this the limited free time each of us may have. KDE devs should have their reasons for not using github for active development, while many devs have their reasons to prefer it. These are facts without judgment. I don't participate in lengthy discussions about reasons. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #5 from Nate Graham --- Creating a Phabricator account only needs to happen once, then you can use it forever. And there are a lot of advantages to Phabricator over Github. Try it, you'll like it! :) It would be a shame to let this patch to fall through the cracks. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #4 from Tsu Jan --- If only KDE was developed on GtiHub... Sorry, but the current situation doesn't encourage any contribution. Believe me, KDE needs a lot of contribution. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED CC||[email protected] --- Comment #3 from Nate Graham --- Thanks so much for the patch, Tsu! Unfortunately, you caught us during a transitional time; reviewboard was being deprecated and your patch got missed. Can you re-upload it to to KDE's Phabricator instance? http://phabricator.kde.org/ Please add "Dolphin" and "KDE Applications" as group reviewers. I will make sure the patch gets noticed. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 Chris Holland changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #2 from Tsu Jan --- Added a patch here: https://git.reviewboard.kde.org/r/130002/diff/1/ -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 377392] Select Folder on Going up (Feature Request)
https://bugs.kde.org/show_bug.cgi?id=377392 --- Comment #1 from Tsu Jan --- Never mind! I found an easy way to add the feature in question; will attach a patch after some tests. -- You are receiving this mail because: You are watching all bug changes.
