[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=389826

a.stipp...@gmx.net changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/eli |https://commits.kde.org/eli
   |sa/157c9f04f4f99b5591980fe9 |sa/ab81facebd458c515087ba7f
   |7052682a3ca6963b|3e734b9b2efde955

--- Comment #12 from a.stipp...@gmx.net ---
Git commit ab81facebd458c515087ba7f3e734b9b2efde955 by Alexander Stippich, on
behalf of Mykola Krachkovsky.
Committed on 24/02/2018 at 14:06.
Pushed by astippich into branch 'master'.

To make theme size depend on DPI

Summary:

Added logicalDpi property to use for scaling UI elements size in Theme.qml

Reviewers: #elisa, astippich

Reviewed By: astippich

Subscribers: astippich, asn, mgallien

Tags: #elisa

Maniphest Tasks: T7530

Differential Revision: https://phabricator.kde.org/D10460

M  +2-0src/main.cpp
M  +28   -23   src/qml/Theme.qml

https://commits.kde.org/elisa/ab81facebd458c515087ba7f3e734b9b2efde955

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=389826

a.stipp...@gmx.net changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/eli
   ||sa/157c9f04f4f99b5591980fe9
   ||7052682a3ca6963b
 Status|CONFIRMED   |RESOLVED

--- Comment #11 from a.stipp...@gmx.net ---
Git commit 157c9f04f4f99b5591980fe97052682a3ca6963b by Alexander Stippich.
Committed on 21/02/2018 at 19:16.
Pushed by astippich into branch 'master'.

To make theme size depend on DPI

Summary:

Added logicalDpi property to use for scaling UI elements size in Theme.qml

Reviewers: #elisa, astippich

Reviewed By: astippich

Subscribers: astippich, asn, mgallien

Tags: #elisa

Maniphest Tasks: T7530

Differential Revision: https://phabricator.kde.org/D10460

M  +2-0src/main.cpp
M  +28   -23   src/qml/Theme.qml

https://commits.kde.org/elisa/157c9f04f4f99b5591980fe97052682a3ca6963b

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Matthieu Gallien]

https://bugs.kde.org/show_bug.cgi?id=389826

--- Comment #10 from Matthieu Gallien  ---
Thanks a lot for your review on Phabricator.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389826

--- Comment #9 from Nate Graham  ---
Thanks, you did great! The Elisa team will take a look at it as soon as they're
able.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Mykola Krachkovsky]

https://bugs.kde.org/show_bug.cgi?id=389826

--- Comment #8 from Mykola Krachkovsky  ---
PS for testing xrdb may be used:
xrdb -merge <<< 'Xft.dpi: 96'
xrdb -merge <<< 'Xft.dpi: 144'
or any other value.
As this value is system wide, it's better to revert to original after changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Mykola Krachkovsky]

https://bugs.kde.org/show_bug.cgi?id=389826

--- Comment #7 from Mykola Krachkovsky  ---
Hope, I've done it ok:
https://phabricator.kde.org/D10460

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Mykola Krachkovsky]

https://bugs.kde.org/show_bug.cgi?id=389826

--- Comment #6 from Mykola Krachkovsky  ---
Yes, ok I'll do it. But before I need to make patch correct. As I've found
Screen.pixelDensity is physical DPI (or DPmm). But when logical DPI != physical
DPI that's bad. And more, it's changed when screen is changed. And I can't find
logical DPI in QML Screen object. So I'm not sure what's best option, to export
logical dpi to QML: root context setContextProperty or call qmlRegisterType for
wrapper around primary screen. Or maybe there is a simpler way to export
function into QML.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389826

--- Comment #5 from Nate Graham  ---
Thank you for the patch! However, patches in bug report tend to get lost.
Please submit it with Phabricator instead. See:

-
https://community.kde.org/Get_Involved/Bug_Reporting#Submit_patches_using_Phabricator.2C_not_the_bug_tracker
- https://community.kde.org/Infrastructure/Phabricator

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Mykola Krachkovsky]

https://bugs.kde.org/show_bug.cgi?id=389826

--- Comment #4 from Mykola Krachkovsky  ---
Created attachment 110530
  --> https://bugs.kde.org/attachment.cgi?id=110530=edit
To make theme sizes depend on DPI

Hi, I've made something like a patch, not sure is it considered ok, but at
least it makes Elisa great again ;) for HiDPI

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Mykola Krachkovsky]

https://bugs.kde.org/show_bug.cgi?id=389826

--- Comment #3 from Mykola Krachkovsky  ---
Sorry, for response delay. Surely I can test patches. I could try even to make
it if I'll get some hint where to start to look.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Lim Yuen Hoe]

https://bugs.kde.org/show_bug.cgi?id=389826

Lim Yuen Hoe  changed:

   What|Removed |Added

 CC||yuenho...@gmail.com

--- Comment #2 from Lim Yuen Hoe  ---
I have a high dpi display and am seeing similar issues. I can test any related
patches - though maybe not necessarily promptly :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Matthieu Gallien]

https://bugs.kde.org/show_bug.cgi?id=389826

Matthieu Gallien  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Matthieu Gallien  ---
Currently, I am lacking proper hardware to test and fix issues.
A second important thing is that we are planning to move to Qt Quick Controls
v2 only. Some of the fix for HighDPI would have be different in this case.
If someone from the Elisa team produces patches, could you test them ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 389826] Elisa looks bad with non-96 DPI

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389826

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.