[frameworks-karchive] [Bug 407537] KArchive cannot read some files created with quazip
https://bugs.kde.org/show_bug.cgi?id=407537 qusai changed: What|Removed |Added CC||qusaialkate...@gmail.com --- Comment #11 from qusai --- gog -- You are receiving this mail because: You are watching all bug changes.
[frameworks-karchive] [Bug 407537] KArchive cannot read some files created with quazip
https://bugs.kde.org/show_bug.cgi?id=407537 Martin Sandsmark changed: What|Removed |Added CC||martin.sandsm...@kde.org --- Comment #10 from Martin Sandsmark --- Looked at the attached file with a hex editor. I think the problem is that quazip writes weird data_descriptor sizes (gpf bit 8 is set so we have to guess the next header, and seekToNextHeaderToken ends up 12 bytes after where it should be, which is coincidentally the size of the data descriptor). I guess the quazip people misunderstood the "optional" part in the spec (you either write the whole data descriptor or you don't, you don't just write the signature). Or I'm reading something wrong. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-karchive] [Bug 407537] KArchive cannot read some files created with quazip
https://bugs.kde.org/show_bug.cgi?id=407537 Boudewijn Rempt changed: What|Removed |Added Assignee|b...@valdyas.org|fa...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-karchive] [Bug 407537] KArchive cannot read some files created with quazip
https://bugs.kde.org/show_bug.cgi?id=407537 --- Comment #9 from Boudewijn Rempt --- Git commit 77d87639051c2115aa516897cbb094cc4d8bbb19 by Boudewijn Rempt. Committed on 18/05/2019 at 06:43. Pushed by rempt into branch 'krita/4.2'. Add a legacy zip store for writing backwards-compatible kra files Use the Quazip store for reading and writing 64 bits zip files, the Legacy store for writing 32 bits zip files. It's still not ideal, having two zip implementations (and a third one hidden inside Qt), but this gives maximal compatibility. Vectors and colorize masks load again as well. Related: bug 407601, bug 407630 M +1-0CMakeLists.txt M +2-0libs/store/CMakeLists.txt A +272 -0libs/store/KoLegacyZipStore.cpp [License: LGPL (v2+)] A +73 -0libs/store/KoLegacyZipStore.h [License: LGPL (v2+)] M +27 -2libs/store/KoStore.cpp M +2-0libs/store/KoStore_p.h https://invent.kde.org/kde/krita/commit/77d87639051c2115aa516897cbb094cc4d8bbb19 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-karchive] [Bug 407537] KArchive cannot read some files created with quazip
https://bugs.kde.org/show_bug.cgi?id=407537 --- Comment #8 from Boudewijn Rempt --- Git commit 4cb990274f8664d4eb3311af7755c8ff6065150c by Boudewijn Rempt. Committed on 17/05/2019 at 09:40. Pushed by rempt into branch 'master'. Add a legacy zip store for writing backwards-compatible kra files Use the Quazip store for reading and writing 64 bits zip files, the Legacy store for writing 32 bits zip files. It's still not ideal, having two zip implementations (and a third one hidden inside Qt), but this gives maximal compatibility. Vectors and colorize masks load again as well. Related: bug 407601, bug 407630 M +1-0CMakeLists.txt M +2-0libs/store/CMakeLists.txt A +272 -0libs/store/KoLegacyZipStore.cpp [License: LGPL (v2+)] A +73 -0libs/store/KoLegacyZipStore.h [License: LGPL (v2+)] M +27 -2libs/store/KoStore.cpp M +2-0libs/store/KoStore_p.h https://invent.kde.org/kde/krita/commit/4cb990274f8664d4eb3311af7755c8ff6065150c -- You are receiving this mail because: You are watching all bug changes.
[frameworks-karchive] [Bug 407537] KArchive cannot read some files created with quazip
https://bugs.kde.org/show_bug.cgi?id=407537 --- Comment #7 from David REVOY --- I built the fix and I confirm it is fixed. I could 'save as' the two problematics *.kra with git~master and they immediately recovered a preview thumbnail in Dolphin and are now readable by my image viewer. Thank you Boud! -- You are receiving this mail because: You are watching all bug changes.
[frameworks-karchive] [Bug 407537] KArchive cannot read some files created with quazip
https://bugs.kde.org/show_bug.cgi?id=407537 --- Comment #6 from Boudewijn Rempt --- Git commit e752d278e48b984f80286c9d0016c69b17d522d4 by Boudewijn Rempt. Committed on 16/05/2019 at 09:44. Pushed by rempt into branch 'krita/4.2'. Add a legacy zip store that uses KArchive KArchive's KZip cannot read all files that Quazip saves. This is a bug in KArchive, but it breaks older versions of krita that cannot load some files saved in 4.2 anymore. So, only use quazip if 64 bits saving is enabled. M +1-0CMakeLists.txt M +2-0libs/store/CMakeLists.txt A +272 -0libs/store/KoLegacyZipStore.cpp [License: LGPL (v2+)] A +73 -0libs/store/KoLegacyZipStore.h [License: LGPL (v2+)] M +28 -2libs/store/KoStore.cpp M +2-0libs/store/KoStore_p.h https://invent.kde.org/kde/krita/commit/e752d278e48b984f80286c9d0016c69b17d522d4 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-karchive] [Bug 407537] KArchive cannot read some files created with quazip
https://bugs.kde.org/show_bug.cgi?id=407537 Boudewijn Rempt changed: What|Removed |Added Status|ASSIGNED|CONFIRMED Component|File formats|general Version|4.2.0-alpha |5.58.0 CC||kdelibs-b...@kde.org Product|krita |frameworks-karchive --- Comment #5 from Boudewijn Rempt --- The file linked to in the report can be read with most zip tools, but not kzip. I think that this is a bug in kzip's zip implementation. -- You are receiving this mail because: You are watching all bug changes.
