[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Patrick Silva changed: What|Removed |Added CC||dario.ri...@gmail.com --- Comment #17 from Patrick Silva --- *** Bug 422233 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added Blocks||421898 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=421898 [Bug 421898] commit 53b41bc90 broken: kcmshell5 and systemsettings5 can't find any modules -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Wolfgang Bauer changed: What|Removed |Added CC||hithaishi.maldeniya@gmail.c ||om --- Comment #16 from Wolfgang Bauer --- *** Bug 421828 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 David Faure changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram |eworks/kcmutils/commit/0f44 |eworks/kcmutils/commit/53b4 |2313d3357ef5d3cf1d341994466 |1bc90b354ce7642f29d0f0a0464 |0d49d146d |b32b29860 --- Comment #15 from David Faure --- Git commit 53b41bc90b354ce7642f29d0f0a0464b32b29860 by David Faure. Committed on 21/05/2020 at 08:23. Pushed by dfaure into branch 'master'. Fix crash when loading an external app KCM like yast This re-instates the use of KService as a first-class citizen in KCModuleInfo, apparently needed for non-plugins. A unittest ensures that the very basic use of service() on such a desktop file doesn't crash. M +4-1CMakeLists.txt A +7-0autotests/CMakeLists.txt A +8-0autotests/YaST-systemsettings.desktop [TRAILING SPACE] ** A +42 -0autotests/kplugininfotest.cpp [License: LGPL (v2/3+eV)] M +59 -17 src/kcmoduleinfo.cpp The files marked with ** at the end have a problem. either the file contains a trailing space or the file contains a call to a potentially dangerous code. Please read: http://community.kde.org/Sysadmin/CommitHooks#Email_notifications Either fix the trailing space or review the dangerous code. https://invent.kde.org/frameworks/kcmutils/commit/53b41bc90b354ce7642f29d0f0a0464b32b29860 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Suzuco changed: What|Removed |Added CC||whilesh...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #14 from Ahmad Samir --- (In reply to Christoph Feck from comment #13) > It looks like gitlab closes issues when committing to work branches... dfaure just forgot to name the branch work/ :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Christoph Feck changed: What|Removed |Added Ever confirmed|1 |0 Status|RESOLVED|REPORTED Resolution|FIXED |--- --- Comment #13 from Christoph Feck --- It looks like gitlab closes issues when committing to work branches... -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Nate Graham changed: What|Removed |Added Version Fixed In||5.71 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 --- Comment #12 from Wolfgang Bauer --- (In reply to David Faure from comment #11) > My apologies for this regression. I had no idea such "fake" KCMs existed. > > https://invent.kde.org/frameworks/kcmutils/-/merge_requests/2 Thank you! I can confirm that it fixes the problem here, YaST starts now again as before. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 --- Comment #11 from David Faure --- My apologies for this regression. I had no idea such "fake" KCMs existed. https://invent.kde.org/frameworks/kcmutils/-/merge_requests/2 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 David Faure changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/fram ||eworks/kcmutils/commit/0f44 ||2313d3357ef5d3cf1d341994466 ||0d49d146d Resolution|--- |FIXED --- Comment #10 from David Faure --- Git commit 0f442313d3357ef5d3cf1d3419944660d49d146d by David Faure. Committed on 20/05/2020 at 20:50. Pushed by dfaure into branch '2020_05_fix_yast_crash'. Fix crash when loading an external app KCM like yast This re-instates the use of KService as a first-class citizen in KCModuleInfo, apparently needed for non-plugins. A unittest ensures that the very basic use of service() on such a desktop file doesn't crash. M +2-1CMakeLists.txt A +7-0autotests/CMakeLists.txt A +8-0autotests/YaST-systemsettings.desktop [TRAILING SPACE] ** A +42 -0autotests/kplugininfotest.cpp [License: LGPL (v2/3+eV)] M +53 -18 src/kcmoduleinfo.cpp The files marked with ** at the end have a problem. either the file contains a trailing space or the file contains a call to a potentially dangerous code. Please read: http://community.kde.org/Sysadmin/CommitHooks#Email_notifications Either fix the trailing space or review the dangerous code. https://invent.kde.org/frameworks/kcmutils/commit/0f442313d3357ef5d3cf1d3419944660d49d146d -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 David Faure changed: What|Removed |Added Assignee|kdelibs-b...@kde.org|fa...@kde.org Status|CONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 --- Comment #9 from Rik Mills --- (In reply to Wolfgang Bauer from comment #8) > You might have misunderstood me though. I wanted to say that a KF5 update is > probably not supposed to break that IMHO. I think I did, and agree. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 --- Comment #8 from Wolfgang Bauer --- (In reply to Wolfgang Bauer from comment #7) > (In reply to Rik Mills from comment #6) > > The Kubuntu one does set X-KDE-ServiceTypes=SystemSettingsExternalApp, but > > it still crashes. > Sure (like openSUSE's YaST), that's exactly what broke by that commit. You might have misunderstood me though. I wanted to say that a KF5 update is probably not supposed to break that IMHO. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 --- Comment #7 from Wolfgang Bauer --- (In reply to Rik Mills from comment #6) > The Kubuntu one does set X-KDE-ServiceTypes=SystemSettingsExternalApp, but > it still crashes. Sure (like openSUSE's YaST), that's exactly what broke by that commit. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 --- Comment #6 from Rik Mills --- (In reply to Wolfgang Bauer from comment #5) > Btw, launching external apps from systemsettings is somewhat "documented" in > https://invent.kde.org/plasma/systemsettings/-/blob/master/examples/external- > application.txt (by using "X-KDE-ServiceTypes=SystemSettingsExternalApp", > systemsettings does install a corresponding kservicetypes file too), so a > KF5 update probably shouldn't break that IMHO. The Kubuntu one does set X-KDE-ServiceTypes=SystemSettingsExternalApp, but it still crashes. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 --- Comment #5 from Wolfgang Bauer --- It crashes in KCModuleInfo::service() because d->pluginInfo is not valid. Avoiding the crash would be easy by adding a check for d->pluginInfo.isValid() there, but launching external applications would still not work as they are not really plugins (and the mentioned commit basically removes support for that). Btw, launching external apps from systemsettings is somewhat "documented" in https://invent.kde.org/plasma/systemsettings/-/blob/master/examples/external-application.txt (by using "X-KDE-ServiceTypes=SystemSettingsExternalApp", systemsettings does install a corresponding kservicetypes file too), so a KF5 update probably shouldn't break that IMHO. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Rik Mills changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Rik Mills changed: What|Removed |Added CC||fa...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Rik Mills changed: What|Removed |Added CC||rikmi...@kde.org --- Comment #4 from Rik Mills --- The same crash can been seen in Kubuntu when trying to launch the external software-properties app (driver manager) via systemsettings. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 chris.tay...@cantab.net changed: What|Removed |Added CC||chris.tay...@cantab.net -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcmutils] [Bug 421566] System setting crash
https://bugs.kde.org/show_bug.cgi?id=421566 Wolfgang Bauer changed: What|Removed |Added Version|5.18.5 |5.70.0 Product|systemsettings |frameworks-kcmutils Assignee|plasma-b...@kde.org |kdelibs-b...@kde.org Component|general |general -- You are receiving this mail because: You are watching all bug changes.
