[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 Boudewijn Rempt changed: What|Removed |Added Resolution|WAITINGFORINFO |FIXED Status|NEEDSINFO |RESOLVED --- Comment #15 from Boudewijn Rempt --- Thanks for testing, let's close it :-) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 --- Comment #14 from Alvin Wong --- I think this bug would have been obsolete since the 2018 sprint when I fixed (or attempted to fix) this. Anyway, I tried the 4.3.0-beta1 with a fresh profile and it correctly used the Traditional Chinese interface language by default. Didn't test any further than that. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 Boudewijn Rempt changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|CONFIRMED |NEEDSINFO --- Comment #13 from Boudewijn Rempt --- Can anyone check whether this is still the case with the 4.3.0-beta1? See https://download.kde.org/unstable/krita/4.3.0-beta1/ -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 --- Comment #12 from wolthera --- Git commit 93ef7c8ef97e3ba5a1349ba38408269205a9d2b8 by Wolthera van Hovell tot Westerflier. Committed on 06/09/2016 at 14:17. Pushed by woltherav into branch 'master'. Merge in new internal color picker dialog! Tremble, dear commit reader, for a new era of color picking has arrived! This is the second part of my Google Summer of Code 206 project. It is a internal color selector, that can handle wide-gamut colors, pick colors from the screen (which is smart enough to identify Krita canvases and pick the correct color managed color that way). It also changes properly using the lut manager exposure controls, and it’s main element, the visual color selector can use the advanced color selector config. This selector is also intergrated into a kis_color_button and used where ever I could port it reliably. It’ll also show up in the pop-up palette. Furthermore, this merge contains little palette usability things, like being able to see the swatch name, search by swatch name and have the split->layer functionality use a palette to name the resultant layers. Also allows custom-pattern to be mindful of the active selection. Anyway, needs a lot of testing! CCMAIL:[email protected] Ref T2337 Ref T2438 Squashed commit of the following: commit 1cf8527877d316b0c3149494535740b7ff3e5c6f Author: Wolthera van Hovell tot Westerflier Date: Tue Sep 6 16:16:24 2016 +0200 Fix build commit d39cecc36ab9fa2f32de8fa3cefe7072c1824dcf Author: Wolthera van Hovell tot Westerflier Date: Tue Sep 6 15:32:08 2016 +0200 Rename the internal color selector dialog to reflect it being a dialog commit afc8658b4114df00644061105b4ed56f08cc257b Merge: 27d4034 91bdcfe Author: Wolthera van Hovell tot Westerflier Date: Tue Sep 6 15:22:33 2016 +0200 Merge branch 'master' into krita-testing-wolthera commit 27d4034efe5d37cde00bb3dd33cab985f6deacd2 Author: Wolthera van Hovell tot Westerflier Date: Sat Sep 3 16:35:23 2016 +0200 Fix screencolor picker label. Ref T2438 commit 29d34d885455f1e5fbfd3ba0e1c5c92974d4f2bf Author: Wolthera van Hovell tot Westerflier Date: Sat Sep 3 16:20:07 2016 +0200 Fix color conversion issues with the selector. Now the selector will show grayscale on a mask, and will update upon changing the image color space. Ref T2438 commit 3dc397583dbb93b4a362abce1ad6df50ee2c7485 Author: Wolthera van Hovell tot Westerflier Date: Fri Sep 2 17:47:53 2016 +0200 Simplify Gradient Map filter and make it usable as a filter layer. There's some awkwardness with the first two generic gradients as the color isn't stored, but this is good for now. Fixes T1837 commit 4a4f704e1700a24f214a844879df09128df64b95 Author: Boudewijn Rempt Date: Fri Sep 2 17:34:00 2016 +0200 Fix drawing the gradient commit 13f83919be65000fc1682940afe6c81fdcc8c1ae Author: Julian Thijssen Date: Fri Sep 2 17:30:51 2016 +0200 Nearest neighbour filtering applies on all zoom levels commit 0a4a62bc9370878441d57f87ed50fbbc7d394ef7 Author: Boudewijn Rempt Date: Fri Sep 2 16:36:02 2016 +0200 Refactor KisColorSource to use KoColor in a saner way commit 58bf4b9ab601c6f5f0aa593c5e86c20ee994e545 Author: Boudewijn Rempt Date: Fri Sep 2 16:21:40 2016 +0200 Make KoSegmentGradient::colorAt threadsafe commit 54df09f834a5fa36db6b98742f7ac05ec9b90170 Author: Boudewijn Rempt Date: Fri Sep 2 16:21:19 2016 +0200 Make this class safe It means we don't cache the QImage, but there is no alternative commit 362c78b89d997845e0fdd7764dd896d031ac632c Author: Boudewijn Rempt Date: Fri Sep 2 16:21:02 2016 +0200 Warn that this class is not threadsafe commit cd02553f552f01cd73c2ec57874195f82d4110f3 Author: Boudewijn Rempt Date: Fri Sep 2 16:06:51 2016 +0200 Make KoStopGradient::colorAt threadsave Sneakily, the "buffer" variable was made a class variable. Marking it mutable allows us to change it from a const function, which hides the fact that this is global data (doubly hidden by there not being an m_ prefix), which makes the const function thread unsafe. commit 904cc82dbdc387e93a478a4a661b7122ce8b965e Author: Boudewijn Rempt Date: Fri Sep 2 15:56:24 2016 +0200 Also revert the patch commit 349b5e776205e844268835f603f36bf89c8eb7b3 Author: Boudewijn Rempt Date: Fri Sep 2 14:57:27 2016 +0200 Try harder to find the tag files on Windows and OSX This is yet another KoResourcePaths problem... Related: bug 366757, bug 360453, bug 348837 commit dbaa7bcdcdaf3ce139227988dca4ba2e6a85f191 Author: Boudewijn Rempt Date: Fri Sep 2 13:56:14 2016 +0200 Fix logic error... I shouldn't code during a sprint, only afterwards commit 71692523af5cd589e3b5059b8960a00b446c8e20 Author: Boudewijn Rempt Date: Fri Sep 2 12:09:42 2016 +0200 Fix typo commit 88bf822c445752d10ea962e88b8e31c8ad8cf337 Author: Boudewijn Rempt Date: Fri Sep 2 11:56:59 2016 +0
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 --- Comment #11 from wolthera --- Git commit 88bf822c445752d10ea962e88b8e31c8ad8cf337 by Wolthera van Hovell tot Westerflier, on behalf of Boudewijn Rempt. Committed on 02/09/2016 at 16:23. Pushed by woltherav into branch 'krita-testing-wolthera'. Go back to ki18n 5.17 for now To avoid the system-language bug until it's fixed. M +2-23rdparty/ext_frameworks/CMakeLists.txt http://commits.kde.org/krita/88bf822c445752d10ea962e88b8e31c8ad8cf337 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 --- Comment #10 from [email protected] --- It appears to me that commenting out the call to `appendLanguagesFromQLocale` in https://git.reviewboard.kde.org/r/127275/#review98823 does "fix" the regression in Krita. But with no klanguageoverrides set, it wouldn't use the OS (Windows) UI language (which is *not* a regression, this didn't work with ki18n 5.17 either.) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 --- Comment #9 from Boudewijn Rempt --- Git commit d4ecbb219cd85ebefafd28769ad14d89a399468e by Boudewijn Rempt. Committed on 02/09/2016 at 09:56. Pushed by rempt into branch 'master'. Go back to ki18n 5.17 for now To avoid the system-language bug until it's fixed. M +2-23rdparty/ext_frameworks/CMakeLists.txt http://commits.kde.org/krita/d4ecbb219cd85ebefafd28769ad14d89a399468e -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 --- Comment #8 from Boudewijn Rempt --- See https://git.reviewboard.kde.org/r/127275/#review98823 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 Friedrich W. H. Kossebau changed: What|Removed |Added CC||[email protected] --- Comment #7 from Friedrich W. H. Kossebau --- I tried to reproduce the issue on linux (opensuse tumbleweed) with ki18n 5.24. But everything works as intended for me, even with exactly the setup you gave (using zh_TW ). Looking at the code I could not see anything suspicious, also any added qdebug statements always had values expected. There are some windows specific codepath though, which also changed since ki18n 5.17 (which I understood did not show this bug) . On my recent commits to ki18n I did not touch those parts, so no idea what influence they have. There is one commit which might be especially suspective, perhaps you would talk to the author: https://quickgit.kde.org/?p=ki18n.git&a=commit&h=26750a15fba059d3a703131e9cd400893aa596a6 (see also https://git.reviewboard.kde.org/r/127275/ where I commented about some issue with this patch) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 --- Comment #6 from Boudewijn Rempt --- Git commit fe21cb5b011fa7ded9cd00f83e75b3299aeb7739 by Boudewijn Rempt. Committed on 31/08/2016 at 07:30. Pushed by rempt into branch 'master'. Only set one language for the LANG variable M +1-1krita/main.cc http://commits.kde.org/krita/fe21cb5b011fa7ded9cd00f83e75b3299aeb7739 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 --- Comment #5 from [email protected] --- It appears that setting the "Fallback language" to a language other than "American English" or the one set for primary language would make the bug disappear. For the record I tried these combinations: (For all occasions highlighted here, both the Windows language and the "Primary language" in Krita is set to Chinese (Traditional).) - Fallback language not set: Krita shows English - Fallback language set to American English: Krita shows English - Fallback language set to British English: Krita shows Traditional Chinese - Fallback language set to Japanese: Krita shows Traditional Chinese - First fallback language set to Japanese, second fallback language set to American English: Krita shows Traditional Chinese - First fallback language set to American English, second fallback language set to Japanese: Krita shows English - First fallback language set to British English, second fallback language set to American English: Krita shows Traditional Chinese - First fallback language set to American English, second fallback language set to British English: Krita shows English -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 368007] Krita 3.0.1 RC doesn't load a system language of OS
https://bugs.kde.org/show_bug.cgi?id=368007 Boudewijn Rempt changed: What|Removed |Added CC||[email protected], ||[email protected] Component|general |general Product|krita |frameworks-ki18n Status|UNCONFIRMED |CONFIRMED Version|git master |5.24.0 Assignee|[email protected] |[email protected] Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
