[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-05-19 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=365363

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-22 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #22 from Pulfer  ---
(In reply to Michael Pyne from comment #21)
> As far as fixing it, that's rather far outside of what I will be able to
> accomplish unless the cause is already fully identified/diagnosed,
> especially given that it's KDE4. :(

Thanx for your help anyway :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-22 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #21 from Michael Pyne  ---
I'd recommend instead adding the env variable to your system startup scripts
using whatever method is appropriate (/etc/local.d or something like that?). 
You don't want to manually edit the distro startkde if you can avoid it.

As far as fixing it, that's rather far outside of what I will be able to
accomplish unless the cause is already fully identified/diagnosed, especially
given that it's KDE4. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-20 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #20 from Pulfer  ---
(In reply to Michael Pyne from comment #19)
> If this is the problem, then running your KDE desktop with the env var
> "KDE_IS_PRELINKED" set to 1 should cause Dolphin to work with icon theme
> changes even when run from KRunner. (This env var disables the kdeinit trick)

Thanx for the hint, it fixes the issue indeed. :-) Should I add
KDE_IS_PRELINKED export to startkde script in my distro's package? Or maybe you
can fix kdeinit to handle icon theme changes even if KDE_IS_PRELINKED is not
set to 1?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-20 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #19 from Michael Pyne  ---
I suspect the behavior you're seeing when running another Dolphin instance from
KRunner (not kicker ;)) is related to an optimization enabled by default in KDE
4 that is supposed to speed up startup of KDE apps (by routing startup through
an always-running kdeinit that clones another copy of itself and morphs into
the right application).

If this is the problem, then running your KDE desktop with the env var
"KDE_IS_PRELINKED" set to 1 should cause Dolphin to work with icon theme
changes even when run from KRunner. (This env var disables the kdeinit trick)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-20 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #18 from Pulfer  ---
I also can reproduce this issue in RHEL 7 (kdelibs-4.14.8 +
kde-workspace-4.11.19 + kde-baseapps-4.10.5).

And it looks like it's not exactly a cache issue. Something seems to pass
incorrect current icon theme to Dolphin when it's run from Kicker/Alt+F2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-20 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #17 from Pulfer  ---
(In reply to Michael Pyne from comment #16)
> That's always seemed to work for me but if it doesn't work for you then
> maybe then will help with debugging the problem.

I remember it worked for me in past too. But something has changed since that
and I haven't figured out what exactly.

Some more info:
1. Close all dolphin windows
Run kcmshell4 icons from konsole, change icon theme
Start dolphin from konsole, see new icon theme properly applied

2. Close all dolphin windows
Run kcmshell4 icons from konsole, change icon theme
Start dolphin either from kicker or Alt+F2, see old cached icon theme. Old
cache is NOT replaced.

3. Start dolphin
Run kcmshell4 icons from konsole, change icon theme
Switch to dolphin window, icons are still old but they change to new theme on
entering directories etc. Old cache is replaced.

If I modify /usr/share/applications/kde4/dolphin.desktop this way:
-Exec=dolphin %i -caption %c %u
+Exec=strace dolphin %i -caption %c %u

starting dolphin from kicker or Alt+F2 works like if it was started from
konsole (all icons are properly refreshed, old cache is not used).

Your help with debugging this issue would be appreciated :-)

P.S. Versions used for testing:
KDE Workspace 4.11.22 + dolphin-4.14.3 + kdelibs 4.14.29
KDE Workspace 4.11.22 + dolphin-15.04.3 + kdelibs 4.14.29

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-19 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #16 from Michael Pyne  ---
Deleting the icon-cache on-disk only ensures that a new icon cache is created
for newly-run applications.  It doesn't, by itself, invalidate any existing
icons in any icon caches already existing somewhere in the desktop session in
running applications.

Fixing those icons is supposed to be handled separately (some kind of IPC
message sent by the kcm to all running apps telling them that there's been a
theme or style update, which should cause them to flush their individual icon
caches among other fixes).

That's always seemed to work for me but if it doesn't work for you then maybe
then will help with debugging the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-19 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=365363

Pulfer  changed:

   What|Removed |Added

 Attachment #104649|KDE Workspace 4.11.22 + |KDE Workspace 4.11.22 +
description|dolphin-4.14.3 with messed  |dolphin-4.14.3 + kdelibs
   |up icons|4.14.29 with messed up
   ||icons

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-19 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #15 from Pulfer  ---
Created attachment 104649
  --> https://bugs.kde.org/attachment.cgi?id=104649=edit
KDE Workspace 4.11.22 + dolphin-4.14.3 with messed up icons

KDE Workspace 4.11.22 + dolphin-4.14.3. First icons theme was Rosa, then it was
changed to Breeze. Even after reboot icons in Dolphin are messed up (Breeze for
toolbar and Rosa for folders).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-19 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #14 from Pulfer  ---
(In reply to Wolfgang Bauer from comment #13)
> I just tried here and I see nothing wrong with kdelibs anyway:
> - Changing the icon theme in systemsettings(4) applies it to (running) KDE4
> applications immediately (including systemsettings)

But sometimes it leaves old icons in cache, resulting mix of old and new theme
icons.

Deleting /var/tmp/kdecache-$USER/icon-cache.kcache from startkde fixes this
issue but only after re-login. Deleting icon-cache.kcache from the running KDE
4 session doesn't help.

I didn't try to investigate why it happens yet. The issue applies only to KDE 4
session. In Plasma 5 session changing icons works perfectly for both KDE4 and
KF5 applications.

Well, maybe it's a wontfix issue anyway because KDE 4 Workspace is obsolete and
no longer supported in upstream.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-18 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #13 from Wolfgang Bauer  ---
(In reply to Pulfer from comment #12)
> Michael, can you do this for kdelibs too?
???
I doubt that this applies to kdelibs/Qt4 at all.

Actually it was a regression in Frameworks 5.23.0, when KIconTheme::current()
was extended to try to get the icon theme from more places than just
kdeglobals:
https://cgit.kde.org/kiconthemes.git/commit/?id=1425523dad0ba4f3acb9d0caa0ff772fd0a1a7e2
(this change hasn't been backported to the KDE4 version, and I'm not sure it
would even make sense for Qt4)

I just tried here and I see nothing wrong with kdelibs anyway:
- Changing the icon theme in systemsettings(4) applies it to (running) KDE4
applications immediately (including systemsettings)
- Changing the icon theme in systemsettings5 forwards the change to KDE4
applications too (also running ones).

(tested with Frameworks 5.31.0, Plasma/systemsettings5 5.9.3, kdelibs 4.14.30)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2017-03-15 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #12 from Pulfer  ---
(In reply to Michael Pyne from comment #7)
> Created attachment 102826 [details]
> Reset QIcon's assigned icon theme along with KDE global config

Michael, can you do this for kdelibs too?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2016-12-20 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=365363

Michael Pyne  changed:

   What|Removed |Added

   Version Fixed In||5.30
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kic
   ||onthemes/39e3815c6fc03fc079
   ||2e6a3c61245b09a75dfebc

--- Comment #11 from Michael Pyne  ---
Git commit 39e3815c6fc03fc0792e6a3c61245b09a75dfebc by Michael Pyne.
Committed on 21/12/2016 at 01:03.
Pushed by mpyne into branch 'master'.

Inform QIconLoader also when the desktop icon theme is changed.

This change is needed because KIconTheme will defer to QIconLoader's
concept of the current icon theme in preference to our own global
config, if that current icon theme is set.

Qt normally leaves it unset but once it starts loading icons through our
platform plugin, it will remember which theme was in use.

This means when we change the configured icon theme, that we would
sometimes accidentally continue to load icons from the old icon theme
(the one remembered by Qt).

Thanks to Wolfgang Bauer for debugging the issue, narrowing the
potential causes of the bug was instrumental in fixing it!
FIXED-IN:5.30

M  +12   -1src/kiconloader.cpp

https://commits.kde.org/kiconthemes/39e3815c6fc03fc0792e6a3c61245b09a75dfebc

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2016-12-20 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #10 from Christoph Feck  ---
Thanks for the analysis and patch. If you think the patch could have negative
side effects, I suggest to post a review request. Otherwise, please commit
soon, so that we get some testing until the next KF5 release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2016-12-20 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=365363

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2016-12-19 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=365363

--- Comment #9 from Wolfgang Bauer  ---
The patch works.

Running applications (including systemsettings5) now immediately use the new
icon theme after you change it and click Apply. This should also prevent old
icons being added to the cache AFAICT.

And as a result, the systemsettings module also preselects the new theme now if
you close and reopen it (without closing systemsettings5 completely).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kiconthemes] [Bug 365363] Changing icons from System Settings is broken

2016-12-16 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=365363

Michael Pyne  changed:

   What|Removed |Added

 CC||mp...@kde.org

--- Comment #7 from Michael Pyne  ---
Created attachment 102826
  --> https://bugs.kde.org/attachment.cgi?id=102826=edit
Reset QIcon's assigned icon theme along with KDE global config

I wish I'd seen this bug earlier, this is a good investigation into the issue. 
I think I've reproduced this before but didn't get this far before I had to
move on to other things.

The attached patch might help, if the cause of the issue is indeed in
KIconTheme::current().  It resets Qt's assigned icon themes for programs
running at the time of the theme change (this should be ensured by placing the
update code within _k_refreshIcons, which should be called in each running KDE
program at runtime when the icon theme is updated).

However I haven't had a chance to test thoroughly, so let me know if there are
still problems.

-- 
You are receiving this mail because:
You are watching all bug changes.