[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Unknown]

https://bugs.kde.org/show_bug.cgi?id=116617

third="Beedell", first="Roke", second="Julian Lockhart" 
 changed:

   What|Removed |Added

 CC||rvdois+RVU4Z9@rokejulianloc
   ||khart.anonaddy.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=116617

--- Comment #22 from funkybom...@gmail.com ---
(In reply to Christoph Feck from comment #21)
> It would really need to be investigated per-application. I expected this
> change causing a multitude of bug reports, see also comment 12.
> 
> Regarding ark, does it work if you use "zip" from command line? Depending on
> the used ark plugin, it is probably a libarchive or zip command issue. I
> suggest to report your findings in a new ticket.

I tried using the zip command in the terminal and it still causes the same
problem (does not preserve the xattrs).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=116617

--- Comment #21 from Christoph Feck  ---
It would really need to be investigated per-application. I expected this change
causing a multitude of bug reports, see also comment 12.

Regarding ark, does it work if you use "zip" from command line? Depending on
the used ark plugin, it is probably a libarchive or zip command issue. I
suggest to report your findings in a new ticket.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=116617

--- Comment #20 from funkybom...@gmail.com ---
I just tested this patch in KDE Neon Testing edition with:

Plasma: 5.20.2
KDE Frameworks: 5.76.0
Qt: 5.15.0
I seems to be working very well, at least when saving/updating a .txt file that
already has xattrs with Kate. Well done! :)

I had less success when I tried to add some xattrs in a .zip file and then
added an extra file into this .zip file using Ark. It would seem that Ark is
not respecting the preservation of the xattrs during saving/updating... 

Should I file a new bug, or should this be addressed in the context of the
current bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.76

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/fd0959409
   ||f356d2c7baecb849f5090112391
   ||3a63
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #19 from Nate Graham  ---
Git commit fd0959409f356d2c7baecb849f50901123913a63 by Nate Graham, on behalf
of Gleb Popov.
Committed on 29/10/2020 at 22:28.
Pushed by ngraham into branch 'master'.

Support for xattrs on kio copy/move

Summary:
This patch adds support to KIO to preserve xattr of files and directories on
copy or move.
Working for copy/move including overwrite and rename cases.
Not working for "write into" when coping folders have name conflict. I'm
against adding to this user case as the name of the action don't imply
overwrite.

Tested only on Linux.

Reviewers: dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise

Reviewed By: dfaure, usta

Subscribers: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho,
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane,
spoorun, nicolasfella, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17816

M  +146  -5autotests/jobtest.cpp
M  +7-0autotests/jobtest.h
M  +3-0src/ioslaves/file/ConfigureChecks.cmake
M  +4-1src/ioslaves/file/config-kioslave-file.h.cmake
M  +1-0src/ioslaves/file/file.h
M  +126  -3src/ioslaves/file/file_unix.cpp

https://invent.kde.org/frameworks/kio/commit/fd0959409f356d2c7baecb849f50901123913a63

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=116617

hoperidesal...@protonmail.ch changed:

   What|Removed |Added

 CC||hoperidesalone@protonmail.c
   ||h

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

 CC||tagwer...@innerjoin.org

--- Comment #18 from Nate Graham  ---
*** Bug 418225 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

 CC||tmarshall7...@gmail.com

--- Comment #17 from Nate Graham  ---
*** Bug 415473 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Toby Fox]

https://bugs.kde.org/show_bug.cgi?id=116617

Toby Fox  changed:

   What|Removed |Added

 CC||toby...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[aubin]

https://bugs.kde.org/show_bug.cgi?id=116617

aubin  changed:

   What|Removed |Added

 CC||aubin@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=116617

Alex Bikadorov  changed:

   What|Removed |Added

 Blocks||341887


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=341887
[Bug 341887] copy preserve attributes option missing, regression in behavior
-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Cochise César]

https://bugs.kde.org/show_bug.cgi?id=116617

Cochise César  changed:

   What|Removed |Added

 CC||cochisece...@zoho.com

--- Comment #16 from Cochise César  ---
I'm working on a solution for this.
Comments are welcome.
https://phabricator.kde.org/D17816

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=116617

Michael D  changed:

   What|Removed |Added

 CC||nortex...@gmail.com

--- Comment #15 from Michael D  ---
(In reply to Christoph Feck from comment #12)
> 1) "when saving a file with extended file attributes" might be impossible to
> fix, because applications would need to load the attributes together with
> the file to be able to save them later. Are there existing applications
> (either by KDE or not) that keep existing extended attributes when saving?
> Also with "Save As..."?

If I understand correctly, saving a file in Okular preserves xattrs. I have a
bunch of files tagged (within Dolphin) that I edit in okular and save (not save
as) and the xattrs remain intact. Is this a problem in other applications?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Störm Poorun]

https://bugs.kde.org/show_bug.cgi?id=116617

Störm Poorun  changed:

   What|Removed |Added

   Platform|Gentoo Packages |unspecified
 CC||s...@olan.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=116617

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=116617

--- Comment #14 from Christoph Feck  ---
Having a file manager copying metadata should be possible to solve. My comment,
however, was about the first situation from comment #11.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[JKFRT]

https://bugs.kde.org/show_bug.cgi?id=116617

JKFRT  changed:

   What|Removed |Added

 CC||gr...@yahoo.com.sg

--- Comment #13 from JKFRT  ---
(In reply to Christoph Feck from comment #12)
> 1) "when saving a file with extended file attributes" might be impossible to
> fix, because applications would need to load the attributes together with
> the file to be able to save them later. Are there existing applications
> (either by KDE or not) that keep existing extended attributes when saving?
> Also with "Save As..."?

Not sure if I understand the question right, but Thunar (xfce) does preserve
extended attributes when copying files around.
Perhaps some of the code base can be borrowed regarding this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=116617

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=116617

neg...@negora.com changed:

   What|Removed |Added

 CC||neg...@negora.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=116617

--- Comment #12 from Christoph Feck  ---
1) "when saving a file with extended file attributes" might be impossible to
fix, because applications would need to load the attributes together with the
file to be able to save them later. Are there existing applications (either by
KDE or not) that keep existing extended attributes when saving? Also with "Save
As..."?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=116617

--- Comment #11 from funkybom...@gmail.com ---
I have just posted a bounty for this bug. I'd like to see this issue fixed for
both situations: 
1) when saving a file with extended file attributes
2) when copying a file/folder with extended file attributes

I know that this issue is multifaceted and serious, so this is my attempt to
give it some renewed visibility and momentum!

Please note that I will need to see it solved in the KDE Neon Developer edition
before I release the reward!
Happy coding! :)

relevant bug reports:
https://bugs.kde.org/show_bug.cgi?id=370543
https://bugs.kde.org/show_bug.cgi?id=274327
https://bugs.kde.org/show_bug.cgi?id=116617

bounty page:
https://www.bountysource.com/issues/54395598-please-add-extended-attribute-support-setxattr-getxattr

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[r4nd0m]

https://bugs.kde.org/show_bug.cgi?id=116617

r4nd0m  changed:

   What|Removed |Added

 CC||opalinsp+...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

 CC||alex.bikado...@kdemail.net

--- Comment #8 from Nate Graham  ---
*** Bug 370371 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

 CC||funkybom...@gmail.com

--- Comment #9 from Nate Graham  ---
*** Bug 370543 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

 CC||grosser.meister.morti@gmx.n
   ||et

--- Comment #10 from Nate Graham  ---
*** Bug 274327 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

 CC||davidmarch...@gmail.com

--- Comment #7 from Nate Graham  ---
*** Bug 342152 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

 CC||oa...@yahoo.com

--- Comment #6 from Nate Graham  ---
*** Bug 224635 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 116617] Please add Extended Attribute support (setxattr, getxattr)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=116617

Nate Graham  changed:

   What|Removed |Added

  Component|general |general
Product|kio |frameworks-kio
 CC||kdelibs-b...@kde.org,
   ||pointedst...@zoho.com
   Severity|wishlist|major
 Status|REOPENED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.