[frameworks-kio] [Bug 322837] Can't open files beginning with colon (:)

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=322837

Ahmad Samir  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.78
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/c5dbb7c54
   ||52f1af637540efdf09061765c0f
   ||fb2d

--- Comment #9 from Ahmad Samir  ---
Git commit c5dbb7c5452f1af637540efdf09061765c0ffb2d by Ahmad Samir.
Committed on 12/12/2020 at 10:15.
Pushed by dfaure into branch 'master'.

KFileWidget: allow files that begin with a ':' to be selected

The issue was that a ':' at the beginning denotes a Qt Resource and in that
case QDir::isAbsolutePath() would return true. The bug is fixed by guarding
against that condition in slotOk().

Also guard other QDir::isAbsolutePath() usage the same way.

Since this logic will be used in various places use a helper function,
isAbsoluteLocalPath() (thanks to dfaure for coming up with that name),
in pathhelpers_p.h.

Extend the unit tests.
FIXED-IN: 5.78

M  +15   -6autotests/kfilewidgettest.cpp
M  +5-6src/filewidgets/kfilewidget.cpp
M  +10   -0src/pathhelpers_p.h

https://invent.kde.org/frameworks/kio/commit/c5dbb7c5452f1af637540efdf09061765c0ffb2d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 322837] Can't open files beginning with colon (:)

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=322837

--- Comment #8 from Ahmad Samir  ---
I've opened bug 430216.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 322837] Can't open files beginning with colon (:)

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=322837

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #7 from Ahmad Samir  ---
That MR only covers the kfilewidget case; for kate I'll open a separate report
to track the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 322837] Can't open files beginning with colon (:)

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=322837

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #6 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kio/-/merge_requests/250

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 322837] Can't open files beginning with colon (:)

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=322837

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 322837] Can't open files beginning with colon (:)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=322837

Nate Graham  changed:

   What|Removed |Added

 CC||pe...@hack-libre.org

--- Comment #5 from Nate Graham  ---
*** Bug 312226 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 322837] Can't open files beginning with colon (:)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=322837

Nate Graham  changed:

   What|Removed |Added

 CC||usnay12...@isomedia.com

--- Comment #4 from Nate Graham  ---
*** Bug 267371 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 322837] Can't open files beginning with colon (:)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=322837

Nate Graham  changed:

   What|Removed |Added

   Assignee|kdelibs-b...@kde.org|fa...@kde.org
 CC||kdelibs-b...@kde.org,
   ||n...@kde.org
   Keywords||usability
Summary|Can't select files  |Can't open files beginning
   |beginning with colon (:) or |with colon (:)
   |tilde (~), or containing|
   |quote (").  |
  Component|general |Open/save dialogs
Version|4.10.5  |5.45.0
Product|kfile   |frameworks-kio

--- Comment #3 from Nate Graham  ---
Using this bug to track just the colon issue, since we have other bugs for the
other characters.

-- 
You are receiving this mail because:
You are watching all bug changes.