[frameworks-kio] [Bug 391738] Dolphin needlesly scans /sys for no good reason

2018-03-13 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=391738

--- Comment #2 from Kai Uwe Broulik  ---
Git commit 3b642556c2039fac6443c4b956c66ff176f65f15 by Kai Uwe Broulik.
Committed on 13/03/2018 at 16:00.
Pushed by broulik into branch 'master'.

[UDevManager] Already filter for subsystem before querying

This does some rough filtering in advance before creating our wrapper items
with properties and all.
UDev default 70-uaccess.rules assumes, ID_MEDIA_PLAYER is always in "usb"
subsystem

Differential Revision: https://phabricator.kde.org/D11290

M  +1-1src/solid/devices/backends/udev/udevdevice.cpp
M  +24   -10   src/solid/devices/backends/udev/udevmanager.cpp

https://commits.kde.org/solid/3b642556c2039fac6443c4b956c66ff176f65f15

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 391738] Dolphin needlesly scans /sys for no good reason

2018-03-12 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=391738

Michael Pyne  changed:

   What|Removed |Added

 CC||mp...@kde.org

--- Comment #1 from Michael Pyne  ---
There may be something here.  If you just grep for /sys/ in the uncompressed
log and remove the rest of the strace output you get 10k lines of syscalls:

 $ kde@midna ~ $ grep '\/sys\/' log.txt | cut -f 3- -d ' ' | wc -l
10896

If you replace the file names in quotes with a token file name and then remove
duplicates, there are only 18 types of syscalls made (and even these could be
further condensed with a bit more inspection):

 $ kde@midna ~ $ grep '\/sys\/' log.txt | cut -f 3- -d ' ' | sed -e 's,)
=.*$,),g' -e 's,"[^"]*",file,g' | sort | uniq | wc -l
18

These syscalls appear to be a sequence of syscalls involving a given file under
/dev, e.g.

/sys/devices/pci:00/:00:18.0
/sys/devices/pci:00/:00:18.0/ID_MEDIA_PLAYER
/sys/devices/pci:00/:00:18.0/subsystem
/sys/devices/pci:00/:00:18.0/uevent

I'm not sure what code is responsible for these calls though, or even if it's
KDE-related at all, which would be important in troubleshooting further.  It
could as well be in UDisks or some other distro-provided library, the strace
output is not limited to KDE-based code.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 391738] Dolphin needlesly scans /sys for no good reason

2018-03-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=391738

Nate Graham  changed:

   What|Removed |Added

Product|dolphin |frameworks-kio
Version|17.12.3 |5.44.0
  Component|general |general
 CC||kdelibs-b...@kde.org
   Assignee|dolphin-bugs-n...@kde.org   |fa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.