[frameworks-kio] [Bug 79903] Wish: Replace technical term "Filter" with "File format" or "File type" when dialog displays a combobox of file types

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=79903

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.59
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kio
   ||/f066660ffcbe578884c5e8
   ||0cef53b16be50d

--- Comment #8 from Nate Graham  ---
Git commit f066660ffcbe578884c5e80cef53b16be50d by Nate Graham.
Committed on 06/05/2019 at 16:15.
Pushed by ngraham into branch 'master'.

[FileWidget] Replace "Filter:" with "File type:" when saving with a limited
list of mimetypes

Summary:
The Filter combobox currently always has the label "Filter:" This is
appropriate in most
cases, but becomes inaccurate when saving with a limited list of mimetypes. In
this case,
the combobox loses its text field and becomes a file type chooser rather than a
filter.

This patch changes the label to "File type:" for that use case.
FIXED-IN: 5.59

Test Plan:
Opening a file: no changes
{F6803789}

Saving a file with no mimetype filter: no changes
{F6803788}

Saving a file with a limited list of mimetypes: label is changed
{F6803790}

Reviewers: #vdg, elvisangelaccio, GB_2

Reviewed By: elvisangelaccio

Subscribers: pino, apol, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T8552

Differential Revision: https://phabricator.kde.org/D20964

M  +34   -9src/filewidgets/kfilewidget.cpp

https://commits.kde.org/kio/f066660ffcbe578884c5e80cef53b16be50d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 79903] Wish: Replace technical term "Filter" with "File format" or "File type" when dialog displays a combobox of file types

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=79903

--- Comment #7 from Nate Graham  ---
PatchL https://phabricator.kde.org/D20964

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 79903] Wish: Replace technical term "Filter" with "File format" or "File type" when dialog displays a combobox of file types

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=79903

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 79903] Wish: Replace technical term "Filter" with "File format" or "File type" when dialog displays a combobox of file types

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=79903

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INTENTIONAL |---
Summary|Wish: Replace technical |Wish: Replace technical
   |term "Filter" with "File|term "Filter" with "File
   |format" or "File type"  |format" or "File type" when
   ||dialog displays a combobox
   ||of file types

--- Comment #6 from Nate Graham  ---
It's the correct term when there's a filter field. But in save dialogs which
define a list of supported mimetypes that the file can be saved as, the text
field disappears and becomes a combobox with file type options. In this case,
"File format" or "File type" would be the correct string.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 79903] Wish: Replace technical term "Filter" with "File format" or "File type"

[Björn Feber]

https://bugs.kde.org/show_bug.cgi?id=79903

Björn Feber  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |INTENTIONAL
 CC||bfe...@protonmail.com

--- Comment #5 from Björn Feber  ---
"Filter" is the correct word, you can enter any string in the label (not
necessarily a file type) and the view will be filtered accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 79903] Wish: Replace technical term "Filter" with "File format" or "File type"

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=79903

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 79903] Wish: Replace technical term "Filter" with "File format" or "File type"

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=79903

Nate Graham  changed:

   What|Removed |Added

Summary|Wish: Replace technical |Wish: Replace technical
   |term 'filter' with 'format' |term "Filter" with "File
   ||format" or "File type"

-- 
You are receiving this mail because:
You are watching all bug changes.