[frameworks-kirigami] [Bug 383725] Not fully visible top list item after scrolling in Discover

2018-02-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=383725

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 383725] Not fully visible top list item after scrolling in Discover

2017-08-30 Thread Alexander Mentyu
https://bugs.kde.org/show_bug.cgi?id=383725

--- Comment #6 from Alexander Mentyu  ---
Can't reproduce anymore in KDE neon 

kirigami-gallery 2.2.0+p16.04+git20170830

plasma-discover 5.10.5+p16.04+git20170825.1638-0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 383725] Not fully visible top list item after scrolling in Discover

2017-08-28 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=383725

--- Comment #5 from Marco Martin  ---
can this be tried again in kirigami master after the above commit?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 383725] Not fully visible top list item after scrolling in Discover

2017-08-28 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=383725

--- Comment #4 from Marco Martin  ---
Git commit 3c2d1e23e45c03321e110dabfe77c89d3c3e0703 by Marco Martin.
Committed on 28/08/2017 at 13:28.
Pushed by mart into branch 'master'.

don't take into account the header 2 times when scrolling

flickableItem.topMargin already comprises the header item,
so the calculation where to stop scrolling was wrong, giving the erratic
behavior
Related: bug 382191

M  +0-4src/controls/templates/private/ScrollView.qml

https://commits.kde.org/kirigami/3c2d1e23e45c03321e110dabfe77c89d3c3e0703

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 383725] Not fully visible top list item after scrolling in Discover

2017-08-28 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=383725

Marco Martin  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|FIXED   |---

--- Comment #3 from Marco Martin  ---
sorry, the commit closed the wrong bug

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 383725] Not fully visible top list item after scrolling in Discover

2017-08-28 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=383725

Marco Martin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kir
   ||igami/d37a938f2a13286f629d0
   ||a16d0b2efe78ab463d4
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Marco Martin  ---
Git commit d37a938f2a13286f629d0a16d0b2efe78ab463d4 by Marco Martin.
Committed on 28/08/2017 at 12:23.
Pushed by mart into branch 'master'.

adress FIXME: remove resetTimer

remove resetTimer from refreshableScrollView: doesn't seem
to be necessary anymoe, was an hack and breaks top margin sometimes

together with previous commit, fixes 383725 and 383772
Related: bug 383772

M  +0-29   src/controls/private/RefreshableScrollView.qml

https://commits.kde.org/kirigami/d37a938f2a13286f629d0a16d0b2efe78ab463d4

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 383725] Not fully visible top list item after scrolling in Discover

2017-08-19 Thread Alexander Mentyu
https://bugs.kde.org/show_bug.cgi?id=383725

--- Comment #1 from Alexander Mentyu  ---
Created attachment 107376
  --> https://bugs.kde.org/attachment.cgi?id=107376&action=edit
not-fully-visible-top-list-item-2

-- 
You are receiving this mail because:
You are watching all bug changes.