[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=369646

Nate Graham  changed:

   What|Removed |Added

 CC||tuxfus...@gmail.com

--- Comment #12 from Nate Graham  ---
*** Bug 384682 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=369646

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kne
   ||wstuff/7d3992479ea1e7a2ad52
   ||3a79c73434c44c61f38c
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #11 from Nate Graham  ---
Git commit 7d3992479ea1e7a2ad523a79c73434c44c61f38c by Nathaniel Graham, on
behalf of Gregor Mi.
Committed on 15/10/2017 at 21:20.
Pushed by ngraham into branch 'master'.

KMoreTools: Update and fix desktopfiles

Summary:

Updates to KMoreTools:
- add minor code comments and update developer README
- update desktop files including fix for PartitionManager and KDiskFree
- add a script to easily update the desktop files
- add FSearch and AngrySearch to search tools
- add new grouping "screenrecorder" with Peek and Simples Screen Recorder
- add new grouping "mouse-tools"
- add new grouping "font-tools"
- add new grouping "language-dictionary"

The change is so big because of the update desktop files. The interface did not
change.

Reviewers: ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham

Reviewed By: elvisangelaccio, ngraham

Subscribers: ngraham, ltoscano, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D7130

M  +2-2autotests/kmoretools/kmoretoolstest.cpp
M  +4-0autotests/kmoretools/kmoretoolstest2.cpp
M  +17   -7data/kmoretools-desktopfiles/_INFO
A  +62   -0data/kmoretools-desktopfiles/_update_all_files.sh
A  +9-0data/kmoretools-desktopfiles/angrysearch.desktop
M  +88   -84   data/kmoretools-desktopfiles/catfish.desktop
A  +77   -0data/kmoretools-desktopfiles/com.uploadedlobster.peek.desktop
A  +7-0data/kmoretools-desktopfiles/ding.desktop
M  +1-77   data/kmoretools-desktopfiles/disk.desktop
D  +---data/kmoretools-desktopfiles/filelight.png
A  +32   -0data/kmoretools-desktopfiles/filelight.svg
A  +159  -0data/kmoretools-desktopfiles/fontinst.desktop
A  +20   -0data/kmoretools-desktopfiles/fontmatrix.desktop
A  +15   -0data/kmoretools-desktopfiles/fsearch.desktop
M  +24   -94   data/kmoretools-desktopfiles/giggle.desktop
M  +0-38   data/kmoretools-desktopfiles/git-cola-folder-handler.desktop
M  +1-73   data/kmoretools-desktopfiles/git-cola.desktop
M  +56   -82   data/kmoretools-desktopfiles/gitg.desktop
M  +144  -64   data/kmoretools-desktopfiles/gnome-search-tool.desktop
M  +176  -75   data/kmoretools-desktopfiles/gparted.desktop
A  +161  -0data/kmoretools-desktopfiles/gucharmap.desktop
M  +3-64   data/kmoretools-desktopfiles/htop.desktop
D  +0-87   data/kmoretools-desktopfiles/kdf.desktop
A  +13   -0data/kmoretools-desktopfiles/kding.desktop
D  +0-127  data/kmoretools-desktopfiles/ksystemlog.desktop
M  +304  -102  data/kmoretools-desktopfiles/org.gnome.clocks.desktop [TRAILING
SPACE] **
M  +71   -29   data/kmoretools-desktopfiles/org.kde.filelight.desktop
A  +156  -0data/kmoretools-desktopfiles/org.kde.kcharselect.desktop
[TRAILING SPACE] ** [TRAILING SPACE] **
A  +151  -0data/kmoretools-desktopfiles/org.kde.kdf.desktop [TRAILING
SPACE] ** [TRAILING SPACE] **
M  +68   -36   data/kmoretools-desktopfiles/org.kde.kfind.desktop
A  +219  -0data/kmoretools-desktopfiles/org.kde.kmousetool.desktop
D  +0-89   data/kmoretools-desktopfiles/org.kde.kscreengenie.desktop
D  +0-90   data/kmoretools-desktopfiles/org.kde.ksnapshot.desktop
M  +139  -13   data/kmoretools-desktopfiles/org.kde.ksysguard.desktop
A  +188  -0data/kmoretools-desktopfiles/org.kde.ksystemlog.desktop
M  +74   -12   data/kmoretools-desktopfiles/org.kde.ktimer.desktop
R  +67   -33   data/kmoretools-desktopfiles/org.kde.partitionmanager.desktop
[from: data/kmoretools-desktopfiles/org.kde.PartitionManager.desktop - 052%
similarity]
A  +252  -0data/kmoretools-desktopfiles/org.kde.spectacle.desktop
M  +60   -113  data/kmoretools-desktopfiles/shutter.desktop
M  +3841 -245  data/kmoretools-desktopfiles/shutter.svg
A  +11   -0data/kmoretools-desktopfiles/simplescreenrecorder.desktop
M  +102  -74   data/kmoretools-desktopfiles/xfce4-taskmanager.desktop
M  +31   -17   src/kmoretools/kmoretoolspresets.cpp
M  +13   -1src/kmoretools/kmoretoolspresets.h
M  +17   -4tests/kmoretools/kmoretoolstest_interactive.cpp

The files marked with ** at the end have a problem. either the file contains a
trailing space or the file contains a call to a potentially dangerous code.
Please read: http://community.kde.org/Sysadmin/CommitHooks#Email_notifications
Either fix the trailing space or review the dangerous code.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=369646

Christoph Feck  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=384682

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=369646

Nate Graham  changed:

   What|Removed |Added

 CC||clintontheg...@gmail.com

--- Comment #10 from Nate Graham  ---
*** Bug 380326 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=369646

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Gregor Mi]

https://bugs.kde.org/show_bug.cgi?id=369646

--- Comment #9 from Gregor Mi  ---
The patch is ready at https://phabricator.kde.org/D7130. Someone needs to have
a final look and give a Ship it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=369646

--- Comment #8 from Christoph Feck  ---
Gregor, any progress with comment #7?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=369646

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Gregor Mi]

https://bugs.kde.org/show_bug.cgi?id=369646

--- Comment #7 from Gregor Mi  ---
The desktop file name changed to lower case from
/usr/share/applications/org.kde.PartitionManager.desktop to
/usr/share/applications/org.kde.partitionmanager.desktop

I'll provide a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=369646

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||p.r.worr...@gmail.com

--- Comment #6 from Elvis Angelaccio  ---
*** Bug 374683 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[João Vidal da Silva]

https://bugs.kde.org/show_bug.cgi?id=369646

--- Comment #5 from João Vidal da Silva  ---
(In reply to Gregor Mi from comment #2)

> /opt/kf5/share/applications/org.kde.PartitionManager.desktop
> (...)
> Maybe the cause is that partitionmanager is now the KF5 version which is
> located in the /opt/kf5/... directory?
> (...)
> The "Name" in the desktop file has changed (see
> https://lxr.kde.org/source/frameworks/knewstuff/data/kmoretools-desktopfiles/
> org.kde.PartitionManager.desktop ("Name=KDE Partition Manager") vs. the
> installed one ("Name=KDE Partition Manager/KF5")) but this should not be the
> cause.

I'm running Manjaro, an Arch based distro, and just as with Andrius Štikonas
both desktop files (org.kde.PartitionManager.desktop from partitionmanager and
from knewstuff) are locate at /usr/share/... and both have Name=KDE Partition
Manager.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Andrius Štikonas]

https://bugs.kde.org/show_bug.cgi?id=369646

Andrius Štikonas  changed:

   What|Removed |Added

 CC||andr...@stikonas.eu

--- Comment #4 from Andrius Štikonas  ---
(In reply to Gregor Mi from comment #2)

> Maybe the cause is that partitionmanager is now the KF5 version which is
> located in the /opt/kf5/... directory?

On my system partitionmanager is installed into /usr and it is still listed as
not installed.

P.S. I also didn't know about this hidden feature in dolphin before seeing this
bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 369646] The 'free' menu in Dolphin's status bar incorrectly lists KDE Partition Manager as not installed

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=369646

Elvis Angelaccio  changed:

   What|Removed |Added

  Component|bars: status|general
Version|16.08.1 |5.27.0
 CC||kdelibs-b...@kde.org
   Assignee|dolphin-bugs-n...@kde.org   |jpwhit...@kde.org
Product|dolphin |frameworks-knewstuff

--- Comment #3 from Elvis Angelaccio  ---
I'd say let's move this to KNewStuff, since it's where this menu is created.

-- 
You are receiving this mail because:
You are watching all bug changes.