[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Ammy changed: What|Removed |Added CC||aman...@outlook.com --- Comment #67 from Ammy --- The font style "Regular" string is still being added in kdeglobals when selecting a font via System Settings! This is a brand new Plasma install on Arch Linux with qt 5.11.x and Plasma 5.14.3. Removing "Regular" does fix the issue with bold fonts, but isn't the patch above help to not insert font styles anymore? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Gianni changed: What|Removed |Added CC||gianni_2...@hotmail.it -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #65 from Fabian Vogt --- Git commit 2e971be576d24a82974eaf2397d4703fca0188d8 by Fabian Vogt, on behalf of R.J.V. Bertin. Committed on 12/06/2018 at 16:45. Pushed by fvogt into branch 'master'. KDE platform plugin: don't force default stylename on user-specified fonts Summary: Applying the default, hardwired QFont::styleName to one of the standard fonts which then gets changed to a user-selected font can break expectations because of the way Qt handles such canonical stylenames, letting them override the effects of other QFont methods invoked subsequently. It can for instance become impossible to make the font bold afterwards: see https://bugs.kde.org/show_bug.cgi?id=378523, https://bugreports.qt.io/browse/QTBUG-63792 or https://bugs.kde.org/show_bug.cgi?id=387467 . This may be a Qt "feature" that's here to stay, sadly. The change proposed here makes it possible (again) for users to prevent font weight rendering regressions by removing the stylename extension from configuration files manually as documented in several locations. This approach is useless when the KDE platform theme plugin then applies the default stylename, an issue that can be avoided by calling QFont::setStyleName() only when no user-specified font is available. Evidently the manual intervention could be replaced with a change in the way font settings are stored; this would also require the current change. Test Plan: Works as intended on Linux. An equivalent modification in my osx-integration fork of the platform theme plugin for Mac has the same effect (without it "Segoe UI Semi-bold" is no longer made bold where it should in dialogs). I don't think there are possible side-effects: - a stylename still gets set either if there is no user-selected font or if that selection includes a stylename extension - font specifications should still contain all the required information they always had; not applying a guessed stylename only means that no conflict can arise with the combined set of numeric style and weight attributes. Reviewers: #frameworks, davidedmundson, graesslin, cfeck, dfaure Reviewed By: dfaure Subscribers: bkchr, ahmadsamir, rdieter, abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D9070 M +4-1src/platformtheme/kfontsettingsdata.cpp https://commits.kde.org/plasma-integration/2e971be576d24a82974eaf2397d4703fca0188d8 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 nia1048...@gmail.com changed: What|Removed |Added CC||nia1048...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Christoph Feckchanged: What|Removed |Added CC||j...@xyinn.org --- Comment #64 from Christoph Feck --- *** Bug 393751 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #63 from Ahmad Samir--- *** Bug 390629 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Ahmad Samirchanged: What|Removed |Added CC||ken20...@ukr.net --- Comment #62 from Ahmad Samir --- *** Bug 391445 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Kenyon Ralphchanged: What|Removed |Added CC||ken...@kenyonralph.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Jarkko Torvinenchanged: What|Removed |Added CC||jarkko.torvi...@iki.fi -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #61 from RJVB--- On Sunday April 15 2018 11:53:17 Dominik Haumann wrote: > For Kate, this has just been fixed for KDE Frameworks 5.56: ^^ Really? Patience, Watson, Patience! :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #60 from Dominik Haumann--- For Kate, this has just been fixed for KDE Frameworks 5.56: https://phabricator.kde.org/D12221 Baybe other apps can / should have a similar fix. The fix is young, though, and not yet we'll tested. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Andrew Udvarechanged: What|Removed |Added CC||audv...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Erik Quaeghebeurchanged: What|Removed |Added CC||k...@equaeghe.nospammail.net -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Erik Quaeghebeurchanged: What|Removed |Added CC|k...@equaeghe.nospammail.net | -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Matthew Schultzchanged: What|Removed |Added CC||matt...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Christoph Feckchanged: What|Removed |Added CC||pgkos.bugzi...@yahoo.com --- Comment #59 from Christoph Feck --- *** Bug 376094 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #58 from Stefano--- (In reply to Yaroslav Sidlovsky from comment #57) > (In reply to Stefano from comment #56) > > (In reply to Maciej Mrozowski from comment #38) > > > As workaround, remove ",Regular" from related config files. Those are, > > > among > > > [...] > > I tried this workaround. It works for kate/kwrite, but not for konsole, > > which remains without bolds. > > It works for me after I removed _all_ `,Regular` entries from > ~/.config/kdeglobals You are right. After removing the "Regular" attribute to every font entry including every non-monospace font, now bold works even on konsole. I guess that touching the font settings would make the issue return. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #57 from Yaroslav Sidlovsky--- (In reply to Stefano from comment #56) > (In reply to Maciej Mrozowski from comment #38) > > As workaround, remove ",Regular" from related config files. Those are, among > > others: > > ~/.config/kdeglobals (fallback) > > ~/.config/kateschemarc (for text editors) > > terminal: > > ~/.config/konsolerc > > ~/.local/share/konsole/*.profile > > You might want to locate config file specific to application you use (in ex. > > komparerc, etc). > > I tried this workaround. It works for kate/kwrite, but not for konsole, > which remains without bolds. It works for me after I removed _all_ `,Regular` entries from ~/.config/kdeglobals -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #56 from Stefano--- (In reply to Maciej Mrozowski from comment #38) > As workaround, remove ",Regular" from related config files. Those are, among > others: > ~/.config/kdeglobals (fallback) > ~/.config/kateschemarc (for text editors) > terminal: > ~/.config/konsolerc > ~/.local/share/konsole/*.profile > You might want to locate config file specific to application you use (in ex. > komparerc, etc). I tried this workaround. It works for kate/kwrite, but not for konsole, which remains without bolds. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added CC||erist...@cryptolab.net --- Comment #55 from Nate Graham --- *** Bug 392379 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Yaroslav Sidlovskychanged: What|Removed |Added CC||zawer...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Ahmad Samirchanged: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=391445 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=390629 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=389725 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #54 from Erik Quaeghebeur--- (In reply to Christoph Feck from comment #49) > If this ticket gets fixed by no longer writing the style name to the > configuration files, this would not fix your issue. So there really needs to > be a separate ticket for that. I've created Bug 389725. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #53 from Erik Quaeghebeur--- (In reply to Christoph Feck from comment #52) > No, the reporter there stated that removing the style names from the kate > config files fixed the issue for him. Then that is a resolved duplicate of this? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #52 from Christoph Feck--- No, the reporter there stated that removing the style names from the kate config files fixed the issue for him. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #51 from Erik Quaeghebeur--- (In reply to Christoph Feck from comment #49) > If this ticket gets fixed by no longer writing the style name to the > configuration files, this would not fix your issue. So there really needs to > be a separate ticket for that. Perhaps it is Bug 376094, where at least the WAITINGFORINFO should be lifted? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #50 from Christoph Feck--- To be more specific, starting with comment #5 we see two different issues discussed, which (according to that comment) is specific to Konsole. I added a comment to bug 384445 asking for clarification. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #49 from Christoph Feck--- If this ticket gets fixed by no longer writing the style name to the configuration files, this would not fix your issue. So there really needs to be a separate ticket for that. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #48 from Mike Lui--- Is that the right course of action? The original bug report was that bolded text did not work in Konsole. Many of the bugs marked as duplicates of this bug reported the same thing. Now there needs to be another bug report for the workaround for the original bug? Shouldn't there be one bug report to enable bold text? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #47 from Christoph Feck--- For which bug? If manually removing the style name from config files does not fix the non-bold issue, then you are seeing a different bug, which you might need to report separately. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #46 from nfx...@gmail.com --- When is a bug fix scheduled? This is getting annoying. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #45 from Jack Kiefer--- Again, folks, please see Mike Lui's comment above: > The non-bold bug in Konsole now appears to be independent of ",Regular" > appearing in the listed files. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #44 from Denis Lisov--- (In reply to Denis Lisov from comment #43) > At the moment bold works correctly > for me, but I'm on unstable Gentoo, so KDE 5.11.5, frameworks 5.42.0, Qt > 5.9.3. (correction: Plasma 5.11.5, frameworks 5.42.0, Qt 5.9.3, apps 17.12.1) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #43 from Denis Lisov--- (In reply to Fonic from comment #41) > Tested this on Gentoo Linux amd64, KDE Plasma 5.11.5, KDE Frameworks 5.40.0, > Qt 5.7.1 (all current stable as of 01/27/18), seems to have no effect at > all, same issues regarding bold/italic in all applications. > > I'm suffering from this since upgrading after KDE 5.11.x was stabilized on > Gentoo a couple of days ago. Very annoying. > > Also, I don't have any ',Regular' strings in any of the configuration files. I've seen this issue without ',Regular' too. However, at some moment it transformed into this one (i.e., the ',Regular' parts appeared in files) and after removing them the problem was gone. At the moment bold works correctly for me, but I'm on unstable Gentoo, so KDE 5.11.5, frameworks 5.42.0, Qt 5.9.3. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #42 from Christoph Feck--- > I don't have any ',Regular' strings in any of the configuration files Then you are having a different issue. This ticket is about KFontRequester adding those style names whenever a font is selected. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Fonicchanged: What|Removed |Added CC||fonic.max...@live.com --- Comment #41 from Fonic --- (In reply to RJVB from comment #40) > You could try rebuilding the plasma-integration plugin with this patch > applied: > https://phabricator.kde.org/D9070 Tested this on Gentoo Linux amd64, KDE Plasma 5.11.5, KDE Frameworks 5.40.0, Qt 5.7.1 (all current stable as of 01/27/18), seems to have no effect at all, same issues regarding bold/italic in all applications. I'm suffering from this since upgrading after KDE 5.11.x was stabilized on Gentoo a couple of days ago. Very annoying. Also, I don't have any ',Regular' strings in any of the configuration files. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #40 from RJVB--- You could try rebuilding the plasma-integration plugin with this patch applied: https://phabricator.kde.org/D9070 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #39 from Erik Quaeghebeur--- (In reply to Maciej Mrozowski from comment #38) > As workaround, remove ",Regular" from related config files. There are no ",Regular" strings in there for me, and I still have the problem. That was already noted in comment 16; I should have been explicit about this. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Maciej Mrozowskichanged: What|Removed |Added CC||reave...@gmail.com --- Comment #38 from Maciej Mrozowski --- As workaround, remove ",Regular" from related config files. Those are, among others: ~/.config/kdeglobals (fallback) ~/.config/kateschemarc (for text editors) terminal: ~/.config/konsolerc ~/.local/share/konsole/*.profile You might want to locate config file specific to application you use (in ex. komparerc, etc). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Erik Quaeghebeurchanged: What|Removed |Added CC||kdebugs@equaeghe.nospammail ||.net --- Comment #37 from Erik Quaeghebeur --- Is there any workaround still available? (Qt 5.7.1, Frameworks 5.40.0, Plasma 5.11.5, Applications 17.08.3) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 talkingod...@gmail.com changed: What|Removed |Added CC||talkingod...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #36 from RJVB--- I thought a fix existed for the font requester that makes it not set the stylename? That should be all that's needed here. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #35 from Jack Kiefer--- (In reply to Dominik Haumann from comment #34) > Any news on this? *gentle ping* For real. There's been multiple Konsole updates, but I keep going back to my older hacky patched version... -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #34 from Dominik Haumann--- Any news on this? *gentle ping* -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 David Zaslavskychanged: What|Removed |Added CC||diaz...@ellipsix.net -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #33 from RJVB--- (In reply to Christoph Feck from comment #32) > A good fix would be in KFontRequester. Indeed, that's one central place where a workaround/fix can be implement. However, > There is no need to workaround it in widget styles or even applications. I don't think that can be guaranteed. Applications can use Qt's native font dialog for instance (that might even be the default behaviour when not running under a Plasma setting). And widget styles can be used in "pure Qt" applications. > Unfortunately I have no development environment right now, but I can review > any patches made to KFontRequester::nearestExistingFont(). Would the function I added to QtCurve be appropriate? QFont Style::FontHelper::fontStripStyleName(const QFont ) const { const QString = f.styleName(); if (styleName.isEmpty()) { // we can simply return the input font return f; } else { // Check for a mismatch between styleString and styleName; when // found the font probably had a style name set directly instead of // receiving it e.g. via the FontDialog. This means its attributes // may still correspond to the original font, not to the current style. // Do a database lookup to get a consistent QFont instance to work with, // so that methods like setWeight(), setStyle() will work as expected. QFont g = (m_fntDB->styleString(f) != styleName) ? m_fntDB->font(f.family(), styleName, f.pointSize()) : QFont(f.family(), f.pointSize(), f.weight()); if (auto s = f.pixelSize() > 0) { g.setPixelSize(s); } g.setStyleHint(f.styleHint(), f.styleStrategy()); g.setStyle(f.style()); if (f.underline()) { g.setUnderline(true); } if (f.strikeOut()) { g.setStrikeOut(true); } if (f.fixedPitch()) { g.setFixedPitch(true); } return g; } } -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #32 from Christoph Feck--- A good fix would be in KFontRequester. It should clear the styleName after database lookup, if the same font is found when only using the family, weight and style attributes, possibly by doing two such lookups. There is no need to workaround it in widget styles or even applications. Unfortunately I have no development environment right now, but I can review any patches made to KFontRequester::nearestExistingFont(). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #31 from Nate Graham--- So should we patch Breeze and Oxygen in the same way? Or is there no real way for us to avoid app-specific patches like https://phabricator.kde.org/D8610? FWIW I've noticed that as of Plasma 5.11 and Qt 5.9.1, Bold text appears correctly in Dolphin and Gwenview's URL bars. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #30 from RJVB--- I think your guess is as good as mine. There appears to be a consensus among the Qt devs that the style name will continue to work as it does currently, despite some disagreement on the details (like whether the font dialog should always set a style name). Some day there may be API to unset attributes. That's not currently possible, for instance, QFont::setBold(false) will tell the font engine that you want a font that's not bold. That's not necessarily the font you started out with after you called setBold(true). Until that time we'll need some kind(s) of workaround (like the function to recreate a font without stylename I committed to QtCurve) and KDE code should probably aim to avoid using the style name as far as possible. This would have been easier if there were a KFont class... It could be very useful to have a more capable (geeky) font explorer that exposes some more of the information that Qt uses internally, like a font's PANOSE data. I keep reading that style names aren't needed for fonts that can be represented in that system, but AFAIK I have only fonts that are in that category (and wouldn't know how to identify a font that isn't). That makes it hard to test the workarounds and to figure out if code can determine reliably when a style name can NOT be avoided. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #29 from Nate Graham--- RJVB, I really appreciate all the work you've done on this multifaceted issue. What's the current status and what's our path forward? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #28 from RJVB--- > This is a QFont issue, True. > now it adds the styleName to the QFont description when using toString(). Only when a style name has been set AFAIK. > An observation, the only ",Regular" that seems to matter in kdeglobals is > the "font=" entry, the other ones don't affect this bug. This theory is That's only because the other fonts are rarely if ever set to bold or italic - on your desktop. The widget style you use can also do this kind of thing (we just committed a workaround in QtCurve). And evidently it doesn't matter what style you chose (though the platform integration plugin indeed has a new habit of setting the style name to "regular" regardless of what the user chose. > https://codereview.qt-project.org/#/c/181645/ (which was accepted IIUC). Yes, it's in 5.9(.3) but not yet in 5.8.0 . It also doesn't fix the whole issue, it just makes it a bit less "viral". -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Ahmad Samirchanged: What|Removed |Added CC||a.samir...@gmail.com --- Comment #27 from Ahmad Samir --- The Summary of this bug should be changed, I think. This is a QFont issue, now it adds the styleName to the QFont description when using toString(). An observation, the only ",Regular" that seems to matter in kdeglobals is the "font=" entry, the other ones don't affect this bug. This theory is backed by this upstream code review https://codereview.qt-project.org/#/c/181645/ (which was accepted IIUC). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #26 from RJVB--- FYI: I thought it might be good to have a central ticket related to font handling in general, not to specific things like "setBold doesn't work": https://bugreports.qt.io/browse/QTBUG-65037 It includes a WIP function to strip the style name, but that may have unexpected results due to how QFonts work internally (= return a different font from the same family). Please don't hesitate to chime in there. Dominik is right that this is a very annoying issue which potentially far-reaching implications. Styles may also use setBold() to render certain UI elements, and they'll typically do that on the fly. This will either not work anymore or it will become significantly more costly. Come to think of it: I use a "semibold" generic UI font and have long been noticing (in applications that offer style selection, like the oxygen-demo) that trying Breeze and then switching back to another style leaves the generic font in "Regular" weight. I understand now that Breeze is only partly to blame for this. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Médéric Boquienchanged: What|Removed |Added CC|mboqu...@free.fr| -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #25 from RJVB--- > if (font.bold()) > { > font.setStyleName(QStringLiteral("Bold")); > } What if you do `font.setWeight(QFont::Bold)` instead, possibly overriding the styleName with `font.setStyleName(QString())` (supposing that indeed clears the property)? The impression I'm getting here is that the styleName property is something that's best left untouched except when you want "to match the font with irregular styles" (citing the 5.8.0 documentation for QFont). That documentation also suggests the properties in question might not be possible to capture with the other QFont attributes but I'd take that with a grain of salt. Qt determines that styleName somehow and presumably that's from metadata stored in the font and relayed through libfreetype of CoreText (styleName is apparently not used on other platforms, yet). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added See Also||https://bugreports.qt.io/br ||owse/QTBUG-63792 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added CC||rjvber...@gmail.com --- Comment #24 from Nate Graham --- *** Bug 387467 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #23 from RJVB--- Probably a redundant observation, but doing something like QSettings().setValue("font", font) instead of QSettings().setValue("font", font.toString()) saves the font in the legacy way, without the problematic stylename extension. To react to Nate's remark: all required information IS already contained in the fontspec string, esp. weight is represented as a standardised numerical value (e.g. 63 = medium/semibold, regular is 57, bold is 75). Qt does have some remaining issues with the less usual weights (AFAICT) and saving the exact stylename could help. The problem is that this is font-specific: some fonts have Medium where others call that Semibold (in all kinds of spellings) or even demi-bold - which is how other fonts call their actual bold face. So a canonical stylename shouldn't be inherited, should be regenerated on the fly when queried and should be overridden by any of the other methods of changing how a font looks (other than size). It's of course possible that Qt only have to fix their QFont::setBold() implementation but they will almost certainly not do that in all affected (older) versions. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 RJVBchanged: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=387467 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added Keywords||usability -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Dominik Haumannchanged: What|Removed |Added Priority|NOR |VHI --- Comment #22 from Dominik Haumann --- Imho this is a grave issue. Essentially, it breaks entire Kate, KDevelop, Kile. And possibly any other application the relies on bold font face. Changing prio to HI. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added CC||nfx...@gmail.com --- Comment #21 from Nate Graham --- *** Bug 387401 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Martin van Eschanged: What|Removed |Added CC||b...@mrvanes.com --- Comment #20 from Martin van Es --- You're right, it seems related to changes in Qt, I've mentioned the problem upstream and some replies. https://bugreports.qt.io/browse/QTBUG-63792 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 gabriel.rill...@gmail.com changed: What|Removed |Added CC||gabriel.rill...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 kafeichanged: What|Removed |Added CC||matthewisrip...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added URL||https://github.com/qt/qtbas ||e/commit/5dd907bf639f43be7f ||2cdfdd44ec3795f1b31bf6 --- Comment #19 from Nate Graham --- Hmm, that's strange--I can perfectly reproduce the issue as well as the workaround in KDE Neon dev unstable. Regardless, after digging into the code, I'm starting to wonder whether or not this really is an issue in KFontRequester. It seems that the cause was a change to QFont in Qt (https://github.com/qt/qtbase/commit/5dd907bf639f43be7f2cdfdd44ec3795f1b31bf6) that added font style information. That seems like an important and useful change--we *should* save font style information! Only in a few situations should that be overridden. So I'm leaning towards fixing all affected KDE apps to work with the new QFont save string, because we *should* keep the font style information, but those apps need some new code because previously they didn't have to content with style information being available. We even already have patches for a couple of affected apps. Thoughts, Christoph? Or have I misunderstood something? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #18 from Mike Lui--- (In reply to Mike Lui from comment #17) > (In reply to Nate Graham from comment #15) > > So the problem persists even if none of those files have any occurrences of > > ",Regular" in them? Or something re-adds ",Regular" to those files? > > See my Comment 5. > I also noticed the workaround stopped working for me in the reported > versions. > I haven't pinpointed at which version the workaround stopped working for me. To clarify, I'm not seeing ",Regular" re-added. The non-bold bug in Konsole now appears to be independent of ",Regular" appearing in the listed files. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #17 from Mike Lui--- (In reply to Nate Graham from comment #15) > So the problem persists even if none of those files have any occurrences of > ",Regular" in them? Or something re-adds ",Regular" to those files? See my Comment 5. I also noticed the workaround stopped working for me in the reported versions. I haven't pinpointed at which version the workaround stopped working for me. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #16 from Jack Kiefer--- (In reply to Nate Graham from comment #15) > So the problem persists even if none of those files have any occurrences of > ",Regular" in them? Or something re-adds ",Regular" to those files? That is correct. I believe it might re-add the ",Regular" in my attempts to fiddle with the font settings, but the problem definitely persists if none of the files have any occurrences of ",Regular" For reference, I'm running KDE neon 5.11.3 with Qt version 5.9.1 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #15 from Nate Graham--- So the problem persists even if none of those files have any occurrences of ",Regular" in them? Or something re-adds ",Regular" to those files? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #14 from Jack Kiefer--- (In reply to Nate Graham from comment #13) > Workaround: remove every occurrence of ",Regular" from the following files: > > ~/.local/share/konsole/*.profile > ~/.config/kdeglobals > > You have to do kdeglobals too, not just your Konsole profile files. Unfortunately, this workaround did not actually end up working for me. I can't tell for sure, but it seems to me that Konsole tends to ignore the changes in the files and sometimes even overwrite them. The only fix that's worked for me so far is the patch above. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added Status|REOPENED|CONFIRMED --- Comment #13 from Nate Graham --- Workaround: remove every occurrence of ",Regular" from the following files: ~/.local/share/konsole/*.profile ~/.config/kdeglobals You have to do kdeglobals too, not just your Konsole profile files. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added CC||aayush.agarwal...@yahoo.com --- Comment #12 from Nate Graham --- *** Bug 384445 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added CC||mboqu...@free.fr --- Comment #11 from Nate Graham --- *** Bug 343539 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added CC||k...@ashka.me --- Comment #10 from Nate Graham --- *** Bug 387043 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #9 from Jack Kiefer--- Sure thing. Submitted here: https://phabricator.kde.org/D8610 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #8 from Nate Graham--- Would you be able to submit that as a patch on https://phabricator.kde.org/? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Jack Kieferchanged: What|Removed |Added CC||jack.c.kie...@gmail.com --- Comment #7 from Jack Kiefer --- Slightly different hack to get this fixed for Konsole 17.08. I was able to modify the same code block (https://github.com/KDE/konsole/blob/Applications/17.08/src/TerminalDisplay.cpp#L826): if (font.bold() != useBold || font.underline() != useUnderline || font.italic() != useItalic || font.strikeOut() != useStrikeOut || font.overline() != useOverline) { font.setBold(useBold); font.setUnderline(useUnderline); font.setItalic(useItalic); font.setStrikeOut(useStrikeOut); font.setOverline(useOverline); if (font.bold()) { font.setStyleName(QStringLiteral("Bold")); } painter.setFont(font); } I was having access issues with the QString constructor, but calling instead calling QStringLiteral was a success (and more efficient, I hear). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Christoph Feckchanged: What|Removed |Added CC||pul...@list.ru --- Comment #6 from Christoph Feck --- *** Bug 376630 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 --- Comment #5 from Mike Lui--- With the latest ArchLinux packages: Konsole no longer shows any bold font, regardless of whether the style (regular) is set in the profile or not This may be konsole specific, as kate does not have this problem All fonts in the following files have no style (regular, bold, italic, et al) saved with them: ~/.local/share/konsole/Default.profile (in use) ~/.config/konsolerc ~/.config/kdeglobals ~/.kde4/share/config/kdeglobals Tested with a new KDE user profile, as well. plasma-framework 5.39.0 qt5-base 5.9.2 konsole 17.08.2 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Denis Lisovchanged: What|Removed |Added CC||dennis.lis...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Dr. Chapatinchanged: What|Removed |Added CC||yy...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Eugenechanged: What|Removed |Added CC||bertyf...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Nate Grahamchanged: What|Removed |Added CC||pointedst...@zoho.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Christoph Feckchanged: What|Removed |Added CC||d_tas...@hotmail.com --- Comment #4 from Christoph Feck --- *** Bug 383665 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Simon Andricchanged: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwidgetsaddons] [Bug 378523] KFontRequester: Fonts are saved with face name preventing bold/italic to work
https://bugs.kde.org/show_bug.cgi?id=378523 Christoph Feckchanged: What|Removed |Added CC||kdelibs-b...@kde.org Resolution|INVALID |--- Ever confirmed|0 |1 Status|RESOLVED|REOPENED Version|16.12.3 |unspecified Product|konsole |frameworks-kwidgetsaddons Assignee|konsole-de...@kde.org |cf...@kde.org Component|font|general Summary|Bold fonts not displaying |KFontRequester: Fonts are |when proper settings|saved with face name |checked |preventing bold/italic to ||work --- Comment #3 from Christoph Feck --- I analyzed the issue and came to the conclusion that it is a bug in KFontRequester not correctly handling the font matching since Qt 5.8.0. The issue is that KFontRequester tries to find the selected font (or the nearest matching font) in the QFontDatabase. If it finds it there, it actually updates the selected font to what it found there. For example, if you had selected "Noto Sans", it will scan the database including selected weight and style attributes, and find "Noto Sans Regular" as the best match. Once this match is saved, however, the attributes implied by the font face name takes precedence over the attributes specified by the application. -- You are receiving this mail because: You are watching all bug changes.