[frameworks-syntax-highlighting] [Bug 390309] Markdown: Bold style not applied when underscore(s) presented in text surrounded by ** or __

[Nibaldo G.]

https://bugs.kde.org/show_bug.cgi?id=390309

Nibaldo G.  changed:

   What|Removed |Added

   Version Fixed In||5.62.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 390309] Markdown: Bold style not applied when underscore(s) presented in text surrounded by ** or __

[Nibaldo G.]

https://bugs.kde.org/show_bug.cgi?id=390309

Nibaldo G.  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
  Latest Commit||https://commits.kde.org/syn
   ||tax-highlighting/c461c5a78f
   ||c8f952a31d7ea846ebd2eeb2278
   ||cd6

--- Comment #1 from Nibaldo G.  ---
Git commit c461c5a78fc8f952a31d7ea846ebd2eeb2278cd6 by Nibaldo González.
Committed on 24/08/2019 at 09:45.
Pushed by ngonzalez into branch 'master'.

Markdown: multiple improvements and fixes

Summary:
## Improve & fix detection of bold/italic text

In bold and italic text highlighting, underscores and asterics aren't allowed
inside, for example `**some_text**` isn't highlighted correctly. I have
improved regex to detect bold and italic text: now asterisks, underscores and
escapes are allowed inside.
{F7273185}

## Improve fenced code blocks

The way to write fenced code blocks varies depending on the
Markdown/MultiMarkdown implementation. Some support only 3 backticks, others
more than 3 backticks, others both; and others 3 tildes (`~`). [1]

Therefore, I think it's a good idea to support all implementations: code blocks
can be written with 3 backticks or more, or with 3 tildes or more . Other
editors, such as Visutal Studio Code, Atom and Sublime Text highlight fenced
code blocks in this way.
Unfortunately, this is only possible using dynamic rules with several RegExpr,
which isn't very optimal. I have no problem modifying that if you don't like
it.
{F7273187}

**Also:**
* Add folding in fenced code blocks.
* Add more keywords to identify languages.
* Add to highlight in fenced code blocks the languages that are already loaded
by default, since they are included via IncludeRules (JavaScript, TypeScript,
JSX, SQL, Mustache/Handlebars, reST & Doxygen).
* Add more languages in the code blocks. Some of the most popular languages are
included [3] [4]: C, Go, Java, JavaScript, TypeScript, Matlab, Perl, R & Ruby.

## Improve code blocks

* Highlight single code with more than one backticks. [2]
   {F7273189}
* Fix: highlight indented code only after an empty line.
   {F7273193}

## Improve highlighting of links and references
{F7273195}

## Improve metadata highlighting

Previously, some metadata Keys were highlighted anywhere in the document.  Now
the metadata is highlighted only on the first line of the Markdown document.
[6] [7]
{F7273196}

## Improves list detection

Through dynamic rules, the indentation of lists is captured, in order to
correctly highlight the indented content in them.
Now the text within the lists is highlighted using "dsNormal", so as not to
saturate Markdown documents with many colors.
{F7273197}

## Add support of inline HTML

`IncludeRules` is used to highlight only HTML tags. [8]

## Others

* Highlight checkboxs in lists.
   {F7273202}
* Add escape characters [5].
* Add `##Alerts` and `##Modelines` in the comments.
* Some minor improvements, such as replacing some RegExpr rules and adding
`column="0"` in some rules.

**Sources:**
* [1] Fenced Markdown code blocks:

* [2] Markdown Syntax Documentation. Code:

* [3] GitHut - Programming Languages and GitHub: 
* [4] Most Popular and Influential Programming Languages of 2018:

* [5] Markdown Syntax Documentation. Backslash escapes:

* [6] MutiMarkdown Metadata:

* [7] Markdown metadata format:

* [8] Markdown Syntax Documentation. Inline HTML:


Reviewers: cullmann, dhaumann, #framework_syntax_highlighting

Reviewed By: dhaumann, #framework_syntax_highlighting

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D23371

M  +40   -11   autotests/folding/example.rmd.fold
M  +453  -53   autotests/folding/test.markdown.fold
M  +2-2autotests/html/basic.markdown.html
M  +35   -6autotests/html/example.rmd.html
M  +414  -14   autotests/html/test.markdown.html
M  +29   -0autotests/input/example.rmd
M  +405  -5autotests/input/test.markdown
M  +3-3autotests/reference/basic.markdown.ref
M  +37   -8autotests/reference/example.rmd.ref
M  +467  -67   autotests/reference/test.markdown.ref
M  +567  -133  data/syntax/markdown.xml
M  +104  -12 

[frameworks-syntax-highlighting] [Bug 390309] Markdown: Bold style not applied when underscore(s) presented in text surrounded by ** or __

[Nibaldo G.]

https://bugs.kde.org/show_bug.cgi?id=390309

Nibaldo G.  changed:

   What|Removed |Added

   Assignee|kwrite-bugs-n...@kde.org|nibg...@gmail.com
 CC||nibg...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 390309] Markdown: Bold style not applied when underscore(s) presented in text surrounded by ** or __

[Dominik Haumann]

https://bugs.kde.org/show_bug.cgi?id=390309

Dominik Haumann  changed:

   What|Removed |Added

Summary|Bold style not applied when |Markdown: Bold style not
   |underscore(s) presented in  |applied when underscore(s)
   |text surrounded by ** or __ |presented in text
   ||surrounded by ** or __
  Component|syntax  |syntax
Version|17.12.0 |unspecified
Product|kate|frameworks-syntax-highlight
   ||ing

-- 
You are receiving this mail because:
You are watching all bug changes.