[frameworks-syntax-highlighting] [Bug 406816] All default themes depend on system UI colors
https://bugs.kde.org/show_bug.cgi?id=406816 Dominik Haumann changed: What|Removed |Added Version Fixed In||5.59 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/syn ||tax-highlighting/bbc465981b ||d55ca5449f5d22e972fccbe994e ||24f --- Comment #3 from Dominik Haumann --- Git commit bbc465981bd55ca5449f5d22e972fccbe994e24f by Dominik Haumann. Committed on 22/05/2019 at 20:09. Pushed by dhaumann into branch 'master'. SyntaxHighlighter: Fix foreground color for text without special highlighting Summary: QTextDocument seems to use the widget palette (or application palette) when drawing text. That is, by default the palette's foreground color is used when no special QTextCharFormat is specified. This patch changes applyFormat() such that the foreground color is always set to avoid the fallback to the QPalette's foreground color. Related: bug 406821 FIXED-IN: 5.59 Test Plan: make && make test + manual testing with the codeeditor example Reviewers: vkrause, cullmann, kossebau Reviewed By: cullmann Subscribers: kwrite-devel, kde-frameworks-devel Tags: #kate, #frameworks Differential Revision: https://phabricator.kde.org/D21295 M +0-1examples/codeeditor/codeeditor.cpp M +4-4src/lib/syntaxhighlighter.cpp https://commits.kde.org/syntax-highlighting/bbc465981bd55ca5449f5d22e972fccbe994e24f -- You are receiving this mail because: You are watching all bug changes.
[frameworks-syntax-highlighting] [Bug 406816] All default themes depend on system UI colors
https://bugs.kde.org/show_bug.cgi?id=406816 Nate Graham changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-syntax-highlighting] [Bug 406816] All default themes depend on system UI colors
https://bugs.kde.org/show_bug.cgi?id=406816 --- Comment #2 from Friedrich W. H. Kossebau --- This was filed in the context of https://phabricator.kde.org/D20766#454924 so I forgot to add more details here, will see to do ASAP. Then as said in that review comment, could also be the symptom is due to a potential bug 406821. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-syntax-highlighting] [Bug 406816] All default themes depend on system UI colors
https://bugs.kde.org/show_bug.cgi?id=406816 --- Comment #1 from Dominik Haumann --- @Friedrich: This should not be the case. However, "some colors" is too vague, could you be more precise? What highlighting file? What code example? What theme? The colors are defined in frameworks/syntax-highlighting/data/themes/*.theme. Could it be the case that you are using xml highlighting files that have hard-coded colors? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-syntax-highlighting] [Bug 406816] All default themes depend on system UI colors
https://bugs.kde.org/show_bug.cgi?id=406816 Christoph Feck changed: What|Removed |Added Keywords||accessibility -- You are receiving this mail because: You are watching all bug changes.
[frameworks-syntax-highlighting] [Bug 406816] All default themes depend on system UI colors
https://bugs.kde.org/show_bug.cgi?id=406816 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
