[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=164847

--- Comment #16 from Nate Graham  ---
https://mail.kde.org/mailman/listinfo/sysadmin

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=164847

--- Comment #15 from Henrik Fehlauer  ---
I guess it'll come down to who is going to put in the work to implement this.
What list would be best?

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=164847

--- Comment #14 from Nate Graham  ---
What you describe would be really nice, but it's probably a question for the
KDE sysadmins. Would you be able to start an email thread about that?

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=164847

--- Comment #13 from Henrik Fehlauer  ---
I know, but that's not what I meant. In theory the commit hooks should be able
to figure out on their own (based on the branch and the next release coming up
as determined by various metadata and/or CMake version magic) what the next
release is going to be called.

I'm too lazy to always include this myself ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=164847

--- Comment #12 from Nate Graham  ---
Yes, Phabricator will add it automatically if you include the "FIXED-IN:" tag
to the revision's Summary section:

FIXED-IN: KDE Applications 18.04

See also:
- https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
- https://techbase.kde.org/Development/Git/Configuration#Commit_Template

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=164847

--- Comment #11 from Henrik Fehlauer  ---
> Added
> Version Fixed In||KDE Applications 18.04
Is there a way to automate this? At least https://www.kde.org/announcements/ is
able to do it, maybe we could bend the commit hooks to do something similar?
(It's a user-visible thing only anyway.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=164847

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||KDE Applications 18.04

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=164847

Henrik Fehlauer  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/gwe
   ||nview/4a87ed952ec209d4407fa
   ||d664a76a2e1afd59b95
 Resolution|--- |FIXED

--- Comment #10 from Henrik Fehlauer  ---
Git commit 4a87ed952ec209d4407fad664a76a2e1afd59b95 by Henrik Fehlauer, on
behalf of Huon Imberger.
Committed on 14/02/2018 at 17:24.
Pushed by rkflx into branch 'master'.

Add options to disable some/all buttons when hovering over thumbnails

Summary:
Adds three options:

  1) Show all (previous behaviour, now default)
  2) Show only selection buttons (hide fullscreen and rotate buttons in Browse
View)
  3) Hide all buttons

This option affects Browse View, Image View Thumbnail Bar, and the Importer
tool `gwenview_importer`.

Reviewers: rkflx, ngraham

Reviewed By: rkflx, ngraham

Subscribers: ngraham

Differential Revision: https://phabricator.kde.org/D10421

M  +25   -5app/browsemainpage.cpp
M  +7-0app/configdialog.cpp
M  +1-0app/configdialog.h
M  +60   -16   app/generalconfigpage.ui
M  +1-1app/viewmainpage.cpp
M  +12   -1importer/thumbnailpage.cpp
M  +10   -0lib/gwenviewconfig.kcfg
A  +48   -0lib/thumbnailactions.h [License: GPL (v2)]
M  +2-1lib/thumbnailview/thumbnailbarview.cpp

https://commits.kde.org/gwenview/4a87ed952ec209d4407fad664a76a2e1afd59b95

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=164847

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=164847

--- Comment #9 from Nate Graham  ---
I think I follow your drift, Henrik... ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=164847

--- Comment #8 from Henrik Fehlauer  ---
Indeed ("Show selection marker" – TIL).

I think then I would be fine with having the config option.

Perhaps this bug is a good case to point future contributors to, as it is easy
with very tangible results? (hint, hint ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=164847

--- Comment #7 from Nate Graham  ---
You can turn those buttons off in Dolphin! :) I do, in fact. I'd be in favor of
a button to turn the overlay buttons off here in Gwenview (even though I
personally don't mind them).

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 164847] Option for turning off overlay buttons on thumbnails

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=164847

Henrik Fehlauer  changed:

   What|Removed |Added

   Keywords||junior-jobs
 CC||rk...@lab12.net
Summary|option for turning off  |Option for turning off
   |toolbox |overlay buttons on
   ||thumbnails

--- Comment #6 from Henrik Fehlauer  ---
I'm undecided on this one. I can see why someone would find the buttons
annoying. On the other hand, adding yet another config option for something we
got only very few complaints about might not be worth it. After all, in Dolphin
you have similar buttons to select files.

-- 
You are receiving this mail because:
You are watching all bug changes.