[gwenview] [Bug 195579] Implement a "Fill Screen" zoom mode that always fits the narrower axis of the image
https://bugs.kde.org/show_bug.cgi?id=195579 --- Comment #8 from Henrik Fehlauer --- You have to thank Silas, I only added the JJ tag ;) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 195579] Implement a "Fill Screen" zoom mode that always fits the narrower axis of the image
https://bugs.kde.org/show_bug.cgi?id=195579 --- Comment #7 from Eike Hein --- Pretty amazing - 9 years after I filed this :) Thanks! -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 195579] Implement a "Fill Screen" zoom mode that always fits the narrower axis of the image
https://bugs.kde.org/show_bug.cgi?id=195579 Henrik Fehlauer changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/gwe ||nview/ba63c8a44f463b883c03c ||77c942809cd238a6594 Status|REOPENED|RESOLVED --- Comment #6 from Henrik Fehlauer --- Git commit ba63c8a44f463b883c03c77c942809cd238a6594 by Henrik Fehlauer, on behalf of Silas Lenz. Committed on 28/02/2018 at 09:16. Pushed by rkflx into branch 'master'. Replace "Fit Width" feature with "Fill" Summary: Fit width is arguably less useful than a more general Fill feature. This replaces "Fit Width" with "Fill", fitting width or height, depending on what fills the window. Test Plan: Use Fill with landscape and portrait pictures with the window in landscape and portrait size. Reviewers: #gwenview, ngraham, rkflx Reviewed By: #gwenview, ngraham, rkflx Subscribers: rkflx, muhlenpfordt, ngraham, #gwenview Tags: #gwenview Differential Revision: https://phabricator.kde.org/D10844 M +5-4doc/index.docbook M +5-5lib/documentview/abstractdocumentviewadapter.h M +15 -13 lib/documentview/abstractimageview.cpp M +4-4lib/documentview/abstractimageview.h M +19 -24 lib/documentview/documentview.cpp M +6-6lib/documentview/documentview.h M +19 -19 lib/documentview/documentviewcontroller.cpp M +1-1lib/documentview/documentviewcontroller.h M +5-5lib/documentview/documentviewsynchronizer.cpp M +1-1lib/documentview/documentviewsynchronizer.h M +6-6lib/documentview/rasterimageview.cpp M +7-7lib/documentview/rasterimageviewadapter.cpp M +3-3lib/documentview/rasterimageviewadapter.h M +9-9lib/documentview/svgviewadapter.cpp M +3-3lib/documentview/svgviewadapter.h M +13 -12 lib/zoomwidget.cpp M +1-1lib/zoomwidget.h https://commits.kde.org/gwenview/ba63c8a44f463b883c03c77c942809cd238a6594 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 195579] Implement a "Fill Screen" zoom mode that always fits the narrower axis of the image
https://bugs.kde.org/show_bug.cgi?id=195579 Henrik Fehlauer changed: What|Removed |Added CC||[email protected] Keywords||junior-jobs --- Comment #5 from Henrik Fehlauer --- +1 on the idea. The new button should just replace the recently added "Fit Width" button. How about naming this just "Fill"? I'm always annoyed by how much space the switcher now takes, but don't really like making it a combobox either. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 195579] Implement a "Fill Screen" zoom mode that always fits the narrower axis of the image
https://bugs.kde.org/show_bug.cgi?id=195579 Eike Hein changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #4 from Eike Hein --- Fill is not the same as fit. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 195579] Implement a "Fill Screen" zoom mode that always fits the narrower axis of the image
https://bugs.kde.org/show_bug.cgi?id=195579 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED CC||[email protected] --- Comment #3 from Nate Graham --- As of at least Gwenview 16.12.3, there's now a "Fit" mode that does just this! -- You are receiving this mail because: You are watching all bug changes.
