[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659
Peter Mühlenpfordt changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/gwe
||nview/1e9a4482d9007991730f1
||8aa95735563038be84e
Status|CONFIRMED |RESOLVED
--- Comment #11 from Peter Mühlenpfordt ---
Git commit 1e9a4482d9007991730f18aa95735563038be84e by Peter Mühlenpfordt.
Committed on 02/02/2018 at 08:03.
Pushed by muhlenpfordt into branch 'master'.
Exit fullscreen browse mode with Escape
Summary:
Previous versions of gwenview used {key Esc} to exit fullscreen mode.
By changing shortcut handling of {key Esc} this does not work anymore.
This patch adds an `eventFilter()` to leave fullscreen from browse
mode with {key Esc}.
Test Plan:
1. Open gwenview in browse mode
2. Switch to fullscreen mode (e.g. {key F11})
3. Press {key Esc}
-> Should switch back to windowed browse mode
Reviewers: ngraham, rkflx
Reviewed By: rkflx
Differential Revision: https://phabricator.kde.org/D10182
M +18 -0app/browsemainpage.cpp
M +3-0app/browsemainpage.h
https://commits.kde.org/gwenview/1e9a4482d9007991730f18aa95735563038be84e
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 --- Comment #10 from Henrik Fehlauer --- > I don't think Escape should go back to start page. > But what about setting a default shortcut, e.g. Ctrl+Home? In "kcmshell5 standard_actions" there already is a standard action with an associated shortcut for "Home". Perhaps we could just port the "Start Page" action to that? It's still a bit hard to reach, preventing frequent usage. More ideas: - When going up in "/", instead of doing nothing switch to the Start page (a bit weird, though). - Implement proper navigation history (maybe there's already some support in KF5, still not trivially done I guess). -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 --- Comment #9 from Peter Mühlenpfordt --- Added a patch for this here: https://phabricator.kde.org/D10182 I don't think Escape should go back to start page. But what about setting a default shortcut, e.g. Ctrl+Home? Clearing the selection in browse mode would be a possibility. Unlike dolphin, gwenview has a default shortcut for Escape and the unselect should only trigger if the shortcut action does nothing (like goto browse mode in browse mode). I don't see any general way to solve this. Dolphin does not clear the selection if any action uses shortcut Escape. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 --- Comment #8 from Henrik Fehlauer --- > in addition we could make ⎋ switch from (normal) Browse mode > to the "Start Page" Alternatively, this could clear the selection (just like in Dolphin). -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 Henrik Fehlauer changed: What|Removed |Added CC||de...@ukn8.de --- Comment #7 from Henrik Fehlauer --- Continuing the discussion from https://phabricator.kde.org/D9943#193322: > What's the desired behavior? Should ⎋ always exit fullscreen browse mode, > i.e. removing the shortcut config? This should be possible with the > ShortcutOverride event. Setting a shortcut for "Full Screen Mode" acts as a toggle, so that we probably don't need to have a separate configurable shortcut for the "Leave Fullscreen Mode" action and maybe we could remove it from the shortcut config dialog? I don't understand why we have this action, as even the context menu in Fullscreen says "Exit Fullscreen Mode" and has said toggle shortcut. "Leave Fullscreen Mode" is only used in the top right corner, we could try to change that to the normal "Exit Fullscreen Mode" action. > As far as I see, it's not possible to have two actions in the > KActionCollection with the same shortcut, even if they only trigger in > different situations. That's my understanding, too. > Ok, I'll try to do it this way: > - fullscreen view mode →fullscreen browse mode with ⎋ or whatever > configured shortcut > - fullscreen browse mode → windowed browse mode with ⎋ Yup, exactly like I would imagine how this should work. (Thinking more about that, in addition we could make ⎋ switch from (normal) Browse mode to the "Start Page", then it would be symmetrical to the Enter key, which cycles "Start Page" → Browse → View. Currently you have a hard time going back to Start, even though there are useful links to your tags, bookmarks and devices there…) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 Nate Graham changed: What|Removed |Added Keywords||junior-jobs, usability -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 Dr. Chapatin changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 Nate Graham changed: What|Removed |Added Summary|Esc key does not exit full |Esc key does not exit full |screen mode |screen mode by default --- Comment #6 from Nate Graham --- Ah good point. -- You are receiving this mail because: You are watching all bug changes.
