[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 Christoph Cullmann changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #24 from Christoph Cullmann --- Hmm, I tried to reproduce my issue, I fail. Perhaps it really just was that corruption :/ Will re-open if I am able to get the behavior again... -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #23 from Christoph Cullmann --- > nvm, the commits went in after tars were created. uf :=) sorry for the issue :/ I will first investigate the stuff here more before opening some request. Somehow this now works for me even with my patch reverted. Perhaps I made the error to not test enough after the memory corruption fix https://commits.kde.org/gwenview/64700e39e989001cc60a179f449695c104bf030b and that was really the main culprit. I have taken a look in the stable branch, that Q_FOREACH => for conversion that introduced this issue was done after we branched off. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #22 from Christoph Feck --- nvm, the commits went in after tars were created. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #21 from Christoph Feck --- Just in case, I am also (still) monitoring all gwenview bug mails. Was the cause for null pixmaps found? If not, I need to respin the 19.08.2 tarball. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #20 from Christoph Cullmann --- And I want to thank Tom for showing that my change was wrong! Thanks for that! -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #19 from Christoph Cullmann --- I will re-investigate my issue + the "wrong" fix. I will post a review request if I find again a workable solution. Perhaps all is already fine after the memory corruption fix https://commits.kde.org/gwenview/64700e39e989001cc60a179f449695c104bf030b and my issues were just after-effects... -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #18 from Nate Graham --- I triage all new bugs filed anywhere, but hadn't gotten to today's crop of bugs yet. :) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #17 from Tom Moebert --- Sry, I'm only occasionally coming here and currently don't really have time to look at the bugs into detail. I thought Nate receives and tracks all the gwenview bugs. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #16 from Christoph Cullmann --- Btw., as you are interested here: Is there interest to get the gwenview bug mails? I think at the moment they just go to a black hole, or? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #15 from Christoph Cullmann --- Hmm, ok. Thanks for the helpful debugging. Then I got just lucky never to hit that case. I need to retry this later at home. I still not get why this commit shall fix then my issues at all, as if it works, it should return the same factor as the qreal overload in QPixmap... -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #14 from Tom Moebert --- Yes: (gdb) print thumbnailPix.isNull() $9 = true -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #13 from Christoph Cullmann --- Hmm, is that a null-pixmap? In any case, I am now confused why this did fix the rendering issues for me. I need to try this with the correct monitor setup again. Locally I can not get the bad rendering with any scale factor now... -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #12 from Tom Moebert ---
Thread 1 "gwenview" hit Breakpoint 1,
Gwenview::ThumbnailBarItemDelegate::sizeHint (this=0x9b3090, index=...)
at /home/tom/Programme/gwenview/lib/thumbnailview/thumbnailbarview.cpp:180
180 auto prf= thumbnailPix.devicePixelRatioF();
(gdb) s
QPaintDevice::devicePixelRatioF (this=0x7fffcd00) at
/usr/include/qt5/QtGui/qpaintdevice.h:87
87 qreal devicePixelRatioF() const { return
metric(PdmDevicePixelRatioScaled) / devicePixelRatioFScale(); }
(gdb) s
QPixmap::metric (this=0x7fffcd00,
metric=QPaintDevice::PdmDevicePixelRatioScaled) at image/qpixmap.cpp:1476
1476return data ? data->metric(metric) : 0;
(gdb) print data
$7 = {d = 0x0}
(gdb) print devicePixelRatioFScale()
$5 = 65536
It seems that "data" of type QExplicitlySharedDataPointer is
not set to an instance.
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #11 from Christoph Cullmann --- Git commit 0bdba41e1dbc9ba48b52e43495091c43270d8be9 by Christoph Cullmann. Committed on 09/10/2019 at 14:05. Pushed by cullmann into branch 'master'. Revert "fix fractional scaling" This reverts commit 769b6e17a0a1e46777ddc87ef1cc9ce3e8807a16. devicePixelRatioF seems to be a bad idea for QPixmap, thought I can't reproduce the crashs here M +1-1lib/documentview/rasterimageview.cpp M +2-2lib/thumbnailview/previewitemdelegate.cpp M +2-2lib/thumbnailview/thumbnailbarview.cpp https://commits.kde.org/gwenview/0bdba41e1dbc9ba48b52e43495091c43270d8be9 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #10 from Christoph Cullmann --- Hmm, I am astonished. Actually, QPixmap has a own overload "qreal devicePixelRatio" (https://doc.qt.io/qt-5/qpixmap.html#devicePixelRatio) that overwrites the wrong https://doc.qt.io/qt-5/qpaintdevice.html#devicePixelRatio The QPixmap variant is save, the other not. Thought for me this commit did for sure remove all artifacts. That is strange :/ Let's revert that again. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #9 from Christoph Cullmann --- I see :/ The issue is: null pixmaps are broken with this, could that be? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #8 from Christoph Cullmann --- Hmm, I tried to look how auto prf= thumbnailPix.devicePixelRatioF(); auto pr = thumbnailPix.devicePixelRatio(); are computed internally for pixmaps. For the that looks normally done via the ::metric function and pixmaps should consistently use there something like image.devicePixelRatio() * QPaintDevice::devicePixelRatioFScale(); Could you step into the thumbnailPix.devicePixelRatioF() call where it ends up? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #7 from Tom Moebert ---
For me crashes in
#4 0x77591475 in operator/ (s=..., c=0) at
/usr/include/qt5/QtCore/qsize.h:196
194 inline const QSize operator/(const QSize , qreal c)
195 {
196 Q_ASSERT(!qFuzzyIsNull(c));
197 return QSize(qRound(s.wd/c), qRound(s.ht/c));
198 }
when c==0 .
Test code:
auto prf= thumbnailPix.devicePixelRatioF();
auto pr = thumbnailPix.devicePixelRatio();
(gdb) print prf
$3 = 0
(gdb) print pr
$2 = 1
(gdb) ptype prf
type = double
(gdb) ptype pr
type = double
Full call stack:
Thread 1 "gwenview" received signal SIGABRT, Aborted.
0x7fffee76b160 in raise () from /lib64/libc.so.6
(gdb) bt
#0 0x7fffee76b160 in raise () from /lib64/libc.so.6
#1 0x7fffee76c741 in abort () from /lib64/libc.so.6
#2 0x7fffef46b907 in QMessageLogger::fatal(char const*, ...) const () from
/usr/lib64/libQt5Core.so.5
#3 0x7fffef466dd6 in qt_assert(char const*, char const*, int) () from
/usr/lib64/libQt5Core.so.5
#4 0x77591475 in operator/ (s=..., c=0) at
/usr/include/qt5/QtCore/qsize.h:196
#5 0x7761dcce in Gwenview::ThumbnailBarItemDelegate::sizeHint
(this=0x9b4650, index=...)
at /home/tom/Programme/gwenview/lib/thumbnailview/thumbnailbarview.cpp:182
#6 0x71540e5a in ?? () from /usr/lib64/libQt5Widgets.so.5
#7 0x715491f4 in ?? () from /usr/lib64/libQt5Widgets.so.5
#8 0x71540bf3 in ?? () from /usr/lib64/libQt5Widgets.so.5
#9 0x7154ac5a in QListView::doItemsLayout() () from
/usr/lib64/libQt5Widgets.so.5
#10 0x712b9513 in ?? () from /usr/lib64/libQt5Widgets.so.5
#11 0x71545160 in QListView::rectForIndex(QModelIndex const&) const ()
from /usr/lib64/libQt5Widgets.so.5
#12 0x715451ae in QListView::visualRect(QModelIndex const&) const ()
from /usr/lib64/libQt5Widgets.so.5
#13 0x7154686c in QListView::scrollTo(QModelIndex const&,
QAbstractItemView::ScrollHint) ()
from /usr/lib64/libQt5Widgets.so.5
#14 0x77623b67 in Gwenview::ThumbnailView::scrollToSelectedIndex
(this=0xa6f0e0)
at /home/tom/Programme/gwenview/lib/thumbnailview/thumbnailview.cpp:843
#15 0x0047545e in Gwenview::MainWindow::slotDirListerCompleted
(this=0x7f5670)
at /home/tom/Programme/gwenview/app/mainwindow.cpp:1302
#16 0x004a61b0 in Gwenview::MainWindow::qt_static_metacall
(_o=0x7f5670,
_c=QMetaObject::InvokeMetaMethod, _id=15, _a=0x7fffd2a0)
at
/home/tom/Programme/gwenview/build/app/gwenview_autogen/EWIEGA46WW/moc_mainwindow.cpp:238
#17 0x7fffef68e535 in QMetaObject::activate(QObject*, int, int, void**) ()
from /usr/lib64/libQt5Core.so.5
#18 0x76583947 in ?? () from /usr/lib64/libKF5KIOCore.so.5
#19 0x76583b36 in ?? () from /usr/lib64/libKF5KIOCore.so.5
#20 0x7fffef68f0a2 in QObject::event(QEvent*) () from
/usr/lib64/libQt5Core.so.5
#21 0x712c03dc in QApplicationPrivate::notify_helper(QObject*, QEvent*)
()
from /usr/lib64/libQt5Widgets.so.5
#22 0x712c7ca4 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib64/libQt5Widgets.so.5
#23 0x7fffef65f8d8 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib64/libQt5Core.so.5
#24 0x7fffef66204d in QCoreApplicationPrivate::sendPostedEvents(QObject*,
int, QThreadData*) ()
from /usr/lib64/libQt5Core.so.5
#25 0x7fffef6b9323 in ?? () from /usr/lib64/libQt5Core.so.5
#26 0x7fffe9152e87 in g_main_context_dispatch () from
/usr/lib64/libglib-2.0.so.0
#27 0x7fffe9153230 in ?? () from /usr/lib64/libglib-2.0.so.0
#28 0x7fffe91532bc in g_main_context_iteration () from
/usr/lib64/libglib-2.0.so.0
#29 0x7fffef6b894f in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib64/libQt5Core.so.5
#30 0x7fffef65d90a in
QEventLoop::exec(QFlags) ()
from /usr/lib64/libQt5Core.so.5
#31 0x7fffef6669b4 in QCoreApplication::exec() () from
/usr/lib64/libQt5Core.so.5
#32 0x00472361 in main (argc=1, argv=0x7fffdbb8) at
/home/tom/Programme/gwenview/app/main.cpp:163
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 Christoph Cullmann changed: What|Removed |Added Version Fixed In|19.08.3 | -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #6 from Christoph Cullmann --- Git commit 2ff212adc2adfc0d50f88abdb7a312250780aa3d by Christoph Cullmann. Committed on 09/10/2019 at 13:40. Pushed by cullmann into branch 'Applications/19.08'. Revert "fix fractional scaling" This reverts commit 113d418203aad7bf6fb09b53a3d70dda30fbd524. => there are reports that this might lead to crashs I can not reproduce that, but better be safe than sorry M +1-1lib/documentview/rasterimageview.cpp M +2-2lib/thumbnailview/previewitemdelegate.cpp M +2-2lib/thumbnailview/thumbnailbarview.cpp https://commits.kde.org/gwenview/2ff212adc2adfc0d50f88abdb7a312250780aa3d -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #5 from Christoph Cullmann --- I will revert the commit in stable just to be sure, if it is faulty, one has more time in master to think about it. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #4 from Christoph Cullmann --- I tried my patch with: 1) No scaling => works 2) Scaling 1.5 => works with, without unusable 3) Scaling 2.0 => works If you can reproduce a crash, please show here, we can then revert the commit. (especially in the 19.08 branch) For me the only reproducable "random" crash was before commit https://commits.kde.org/gwenview/64700e39e989001cc60a179f449695c104bf030b There I got random crashs during "any" operation. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 Christoph Cullmann changed: What|Removed |Added CC||tom.m...@googlemail.com -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 Christoph Cullmann changed: What|Removed |Added Ever confirmed|0 |1 Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 --- Comment #3 from Christoph Cullmann --- There seems to be issues with this: https://github.com/KDE/gwenview/commit/769b6e17a0a1e46777ddc87ef1cc9ce3e8807a16#commitcomment-35426113 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 Christoph Cullmann changed: What|Removed |Added CC||cullm...@kde.org Version Fixed In||19.08.3 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 Christoph Cullmann changed: What|Removed |Added Latest Commit|https://commits.kde.org/gwe |https://commits.kde.org/gwe |nview/769b6e17a0a1e46777ddc |nview/113d418203aad7bf6fb09 |87ef1cc9ce3e8807a16 |b53a3d70dda30fbd524 --- Comment #2 from Christoph Cullmann --- Git commit 113d418203aad7bf6fb09b53a3d70dda30fbd524 by Christoph Cullmann. Committed on 08/10/2019 at 20:24. Pushed by cullmann into branch 'Applications/19.08'. fix fractional scaling M +1-1lib/documentview/rasterimageview.cpp M +2-2lib/thumbnailview/previewitemdelegate.cpp M +2-2lib/thumbnailview/thumbnailbarview.cpp https://commits.kde.org/gwenview/113d418203aad7bf6fb09b53a3d70dda30fbd524 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 412738] Issue with multi-head + fractional scaling
https://bugs.kde.org/show_bug.cgi?id=412738 Christoph Cullmann changed: What|Removed |Added Latest Commit||https://commits.kde.org/gwe ||nview/769b6e17a0a1e46777ddc ||87ef1cc9ce3e8807a16 Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #1 from Christoph Cullmann --- Git commit 769b6e17a0a1e46777ddc87ef1cc9ce3e8807a16 by Christoph Cullmann. Committed on 08/10/2019 at 20:22. Pushed by cullmann into branch 'master'. fix fractional scaling M +1-1lib/documentview/rasterimageview.cpp M +2-2lib/thumbnailview/previewitemdelegate.cpp M +2-2lib/thumbnailview/thumbnailbarview.cpp https://commits.kde.org/gwenview/769b6e17a0a1e46777ddc87ef1cc9ce3e8807a16 -- You are receiving this mail because: You are watching all bug changes.
