[juk] [Bug 392705] Drag and drop does not work: Sorting in play lists and play queue does not work

2019-06-25 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=392705

--- Comment #5 from Michael D  ---
Thanks for the fixes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 392705] Drag and drop does not work: Sorting in play lists and play queue does not work

2019-06-23 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=392705

Michael Pyne  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||19.04.3
  Latest Commit||https://invent.kde.org/kde/
   ||juk/commit/55a6bd7170e5b2ca
   ||6e9f826232574f2136a1648a

--- Comment #4 from Michael Pyne  ---
Git commit 55a6bd7170e5b2ca6e9f826232574f2136a1648a by Michael Pyne.
Committed on 23/06/2019 at 19:13.
Pushed by mpyne into branch 'Applications/19.04'.

Fix drag-and-drop of playlist items onto a playlist icon.

This allows you to drag music tracks onto a different playlist, by
dropping the selected tracks onto the name of a different playlist.

There still seem to be other bugs (Dragging items onto play queue
doesn't enable play queue automatically; some playlists aren't properly
saved for some reason). But those will have to be fixed in other
commits.

FIXED-IN:19.04.3

M  +45   -2playlistbox.cpp
M  +3-0playlistbox.h

https://invent.kde.org/kde/juk/commit/55a6bd7170e5b2ca6e9f826232574f2136a1648a

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 392705] Drag and drop does not work: Sorting in play lists and play queue does not work

2019-05-18 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=392705

--- Comment #3 from Michael Pyne  ---
Git commit dc2d9c8e0fe64ff6059b0f5ca927ff338e7eeca4 by Michael Pyne.
Committed on 18/05/2019 at 04:27.
Pushed by mpyne into branch 'Applications/19.04'.

Add 'override' decl to fix compiler warnings, fix drag-and-drop.

This should shave off some 1,000+ warnings over the course of a build
with GCC 9.1.

This only addresses class declarations native to JuK, but Taglib and to
a lesser extent Qt5 moc still have (or generate) code that can result in
compiler warnings about suggested override declarations.

In the process I noticed that an existing drag-and-drop support function
(Playlist::decode) is no longer overriding Qt virtual functions, so it
has been turned into an auxiliary function to fix existing drag-and-drop
bugs from the KF5 port (tested by dropping files from Dolphin into a
playlist view).

Drag-and-drop from a playlist to another playlist (by dropping on the
playlist name) still remains broken for now.
FIXED-IN:19.04.2

M  +0-5collectionlist.cpp
M  +10   -10   collectionlist.h
M  +2-2coverdialog.cpp
M  +2-2coverinfo.cpp
M  +1-1deletedialog.h
M  +1-1directorylist.h
M  +2-1dynamicplaylist.cpp
M  +5-5dynamicplaylist.h
M  +2-2exampleoptions.h
M  +3-3filehandleproperties.h
M  +22   -22   filerenamer.h
M  +1-1filerenamerconfigdlg.h
M  +1-1filerenameroptions.h
M  +2-2folderplaylist.h
M  +5-5historyplaylist.h
M  +2-2juk-exception.h
M  +2-2juk.h
M  +1-3lyricswidget.h
M  +9-9nowplaying.h
M  +12   -15   playlist.cpp
M  +22   -23   playlist.h
M  +15   -15   playlistbox.h
M  +8-8playlistcollection.h
M  +1-1playlistitem.h
M  +2-2searchplaylist.h
M  +1-1searchwidget.h
M  +8-8slider.h
M  +1-1statuslabel.h
M  +6-6systemtray.h
M  +7-7tageditor.cpp
M  +1-1tageditor.h
M  +1-1tagguesserconfigdlg.h
M  +8-8tracksequenceiterator.h
M  +1-1treeviewitemplaylist.h
M  +9-9upcomingplaylist.h
M  +17   -12   viewmode.h
M  +2-2volumepopupbutton.h

https://invent.kde.org/kde/juk/commit/dc2d9c8e0fe64ff6059b0f5ca927ff338e7eeca4

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 392705] Drag and drop does not work: Sorting in play lists and play queue does not work

2019-02-28 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=392705

--- Comment #2 from Michael D  ---
Sorting by column in playlists works for me. Manjaro, juk 18.12.2. Drag and
drop doesn't, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 392705] Drag and drop does not work: Sorting in play lists and play queue does not work

2019-01-18 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=392705

Michael D  changed:

   What|Removed |Added

 CC||nortex...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 392705] Drag and drop does not work: Sorting in play lists and play queue does not work

2018-04-04 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=392705

Michael Pyne  changed:

   What|Removed |Added

   Severity|normal  |major
   Assignee|whee...@kde.org |mp...@kde.org
   Priority|NOR |HI
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Michael Pyne  ---
I've been tracking this myself but good to have a reported bug for it since I
haven't been able to fix it yet

-- 
You are receiving this mail because:
You are watching all bug changes.