[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=335855

Christoph Cullmann  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/ktexteditor/-/commit
   ||/5556b71f5eaa47146d8bc5cd7b
   ||a78181c58e0785

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=335855

Christoph Cullmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.102.0
 Status|CONFIRMED   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=335855

--- Comment #7 from Christoph Cullmann  ---
(In reply to Christoph Cullmann from comment #6)
> Must confess the initial example is still broken in my branch...

Should work now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=335855

--- Comment #6 from Christoph Cullmann  ---
Must confess the initial example is still broken in my branch...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=335855

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=335855

--- Comment #5 from Christoph Cullmann  ---
https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/451

If somebody has time, please test this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=335855

Christoph Cullmann  changed:

   What|Removed |Added

   Severity|minor   |wishlist

--- Comment #4 from Christoph Cullmann  ---
Still happens, but nothing will change if nobody provides at patch.

I would consider this no real issue, as such code is strange, there is no
reason to have empty lines after the start of such statements.

Naturally, if somebody provides a patch, this can be improved, all these things
are just imperfect heuristics.

See on https://kate-editor.org/join-us/ how to contribute.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Justin]

https://bugs.kde.org/show_bug.cgi?id=335855

Justin  changed:

   What|Removed |Added

 CC||justin.zo...@gmail.com
Version|16.04.1 |20.08.2

--- Comment #3 from Justin  ---
Still an issue as of 20.11.70

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=335855

sun...@hotmail.ru changed:

   What|Removed |Added

 CC||sun...@hotmail.ru

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=335855

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org

--- Comment #2 from Christoph Cullmann  ---
Valid bug, unfortunately ATM we only have one line look-ahead to 'know' if some
line should start a new folding section.

This means in these cases, that heuristic will fail, as the indentation level
is not increased (because empty lines are skipped for that).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 335855] code folding for python files misses some structures when body starts with empty lines

[Buovjaga via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=335855

Buovjaga  changed:

   What|Removed |Added

Summary|code folding for python |code folding for python
   |files misses some   |files misses some
   |structures when body starts |structures when body starts
   |with comment or empty lines |with empty lines
   Severity|normal  |minor
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||todven...@suomi24.fi
Version|3.13.0  |16.04.1

--- Comment #1 from Buovjaga  ---
I get the folding marks for the blocks with a comment, but not for the ones
with a blank line.

Arch Linux 64-bit
Kate 16.04.2
KDE Frameworks 5.22.0
Qt 5.6.1
xcb wm

-- 
You are receiving this mail because:
You are watching all bug changes.